[PATCH]: Update minimum MPC version to 0.8

[Kaveh R. Ghazi]

This patch bumps the minimum MPC version used by GCC to 0.8.

Note MPC is still optional, this patch doesn't change that.

I expect to make MPC hard-required soon, however I plan to post a
notice and transition period while everyone installs it on their
machines.  In the mean time, this will ensure people use the right
version.

Tested on x86_64-unknown-linux-gnu with and without mpc-0.8.  No
regressions.  I also verified that GCC's configure now rejects the
older MPC release.

Okay for mainline?

                Thanks,
                --Kaveh

(PS: I don't have write access to binutils, if someone would copy the
configure.ac bits there, I would appreciate it, thx.)



2009-10-08  Kaveh R. Ghazi  <ghazi@...>

        * configure.ac: Update minimum MPC version to 0.8.
        * configure: Regenerate.

gcc:
        * doc/install.texi: Update minimum MPC version to 0.8.

diff -rup orig/egcc-SVN20091008/configure.ac egcc-SVN20091008/configure.ac
--- orig/egcc-SVN20091008/configure.ac 2009-10-04 02:00:42.000000000 +0200
+++ egcc-SVN20091008/configure.ac 2009-10-08 20:06:06.000000000 +0200
@@ -1365,7 +1365,7 @@ if test -d ${srcdir}/gcc && test "x$have
     CFLAGS="$CFLAGS $mpcinc"
     AC_MSG_CHECKING([for the correct version of mpc.h])
     AC_TRY_COMPILE([#include <mpc.h>],[
-    #if MPC_VERSION < MPC_VERSION_NUM (0,7,0)
+    #if MPC_VERSION < MPC_VERSION_NUM (0,8,0)
     choke me
     #endif
     ], [AC_MSG_RESULT([yes]); have_mpc=maybe],
@@ -1412,6 +1412,7 @@ if test -d ${srcdir}/gcc && test "x$have
     mpc_neg (n, n, MPC_RNDNN);
     mpc_sqr (n, n, MPC_RNDNN);
     mpc_pow (n, n, n, MPC_RNDNN);
+    mpc_acosh (n, n, MPC_RNDNN);
     mpc_clear (n);
     ], [AC_MSG_RESULT([yes]); have_mpc=yes],
        [AC_MSG_RESULT([no]); have_mpc=no; mpclibs= ; mpcinc= ])
diff -rup orig/egcc-SVN20091008/gcc/doc/install.texi egcc-SVN20091008/gcc/doc/install.texi
--- orig/egcc-SVN20091008/gcc/doc/install.texi 2009-10-04 02:00:19.000000000 +0200
+++ egcc-SVN20091008/gcc/doc/install.texi 2009-10-08 20:07:14.000000000 +0200
@@ -344,7 +344,7 @@ not installed in your default library se

 Necessary to build libgcj, the GCJ runtime.

-@item MPC Library version 0.7.0 (or later)
+@item MPC Library version 0.8.0 (or later)

 Optional when building GCC@.  Having this library will enable
 additional optimizations on complex numbers.  It can be downloaded

[Basile Starynkevitch]

Kaveh R. GHAZI wrote:
> This patch bumps the minimum MPC version used by GCC to 0.8.
>
> Note MPC is still optional, this patch doesn't change that.
>
> I expect to make MPC hard-required soon, however I plan to post a
> notice and transition period while everyone installs it on their
> machines.  In the mean time, this will ensure people use the right
> version.


I noticed on my Debian/Sid - on which I just compiled MPC 0.8 with default prefix, so it goes into /usr/local - that if
there is an older version of MPC in /usr it is taken even if an explicit --with-mpc=/usr/local is passed to configure.

In other words, I had to remove the libmpc-dev package provided by Debian.

Regards.

--
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: [phone]
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mines, sont seulement les miennes} ***

[Kaveh R. Ghazi]

From: "Basile STARYNKEVITCH" <basile@...>

> I noticed on my Debian/Sid - on which I just compiled MPC 0.8 with default
> prefix, so it goes into /usr/local - that if there is an older version of
> MPC in /usr it is taken even if an explicit --with-mpc=/usr/local is
> passed to configure.
>
> In other words, I had to remove the libmpc-dev package provided by Debian.

(I assume you mean the /usr copy was used when you bootstrapped GCC.  Thanks
for testing that.)

You're not explicit about what step it fails on.  Configure?  Compiling some
*.c file?  Linking cc1?  etc.

Is this something unique to MPC or would GMP/MPFR have similar problems if
setup in the same /usr + /usr/local scenario?

        Thanks,
        --Kaveh

[Basile Starynkevitch]

Kaveh R. Ghazi wrote:

> From: "Basile STARYNKEVITCH" <basile@...>
>
>> I noticed on my Debian/Sid - on which I just compiled MPC 0.8 with
>> default prefix, so it goes into /usr/local - that if there is an older
>> version of MPC in /usr it is taken even if an explicit
>> --with-mpc=/usr/local is passed to configure.
>>
>> In other words, I had to remove the libmpc-dev package provided by
>> Debian.
>
> (I assume you mean the /usr copy was used when you bootstrapped GCC.  
> Thanks for testing that.)
>
> You're not explicit about what step it fails on.  Configure?  Compiling
> some *.c file?  Linking cc1?  etc.
>

If my memory is not wrong, the linking of cc1 failed because functions like mpc_asin are undefined. This is related to
HAVE_mpc_arc which depends on the version of MPC.

Yes, the /usr/include/mpc.h was used, from Debian.

Maybe a bullet-proof configure.ac could check for mpc_asin.

Regards.

--
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: [phone]
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mines, sont seulement les miennes} ***

[Kaveh R. Ghazi]

From: "Basile STARYNKEVITCH" <basile@...>

> If my memory is not wrong, the linking of cc1 failed because functions
> like mpc_asin are undefined. This is related to HAVE_mpc_arc which depends
> on the version of MPC.
>
> Yes, the /usr/include/mpc.h was used, from Debian.
>
> Maybe a bullet-proof configure.ac could check for mpc_asin.

My patch to enforce mpc-0.8 does that.  (Well it checks for mpc_acosh, but
that's just as good because the "arc" functions are all new as of 0.8).
I.e. it will reject the older 0.7 library.

        --Kaveh

[Kaveh R. Ghazi]

On Thu, 5 Nov 2009, Kaveh R. GHAZI wrote:

> 2009-10-08  Kaveh R. Ghazi  <ghazi@...>
>
> * configure.ac: Update minimum MPC version to 0.8.
> * configure: Regenerate.
>
> gcc:
> * doc/install.texi: Update minimum MPC version to 0.8.

Ping: http://gcc.gnu.org/ml/gcc-patches/2009-11/msg00297.html

                Thanks,
                --Kaveh

[Kaveh R. Ghazi]

On Thu, 12 Nov 2009, Kaveh R. GHAZI wrote:

> On Thu, 5 Nov 2009, Kaveh R. GHAZI wrote:
>
> > 2009-10-08  Kaveh R. Ghazi  <ghazi@...>
> >
> > * configure.ac: Update minimum MPC version to 0.8.
> > * configure: Regenerate.
> >
> > gcc:
> > * doc/install.texi: Update minimum MPC version to 0.8.

Ping x2: http://gcc.gnu.org/ml/gcc-patches/2009-11/msg00297.html

and: http://gcc.gnu.org/ml/gcc-patches/2009-11/msg00731.html

                Thanks,
                --Kaveh

[Kaveh R. Ghazi]

On Thu, 19 Nov 2009, Kaveh R. GHAZI wrote:

> On Thu, 12 Nov 2009, Kaveh R. GHAZI wrote:
>
> > On Thu, 5 Nov 2009, Kaveh R. GHAZI wrote:
> >
> > > 2009-10-08  Kaveh R. Ghazi  <ghazi@...>
> > >
> > > * configure.ac: Update minimum MPC version to 0.8.
> > > * configure: Regenerate.
> > >
> > > gcc:
> > > * doc/install.texi: Update minimum MPC version to 0.8.

Ping x3: http://gcc.gnu.org/ml/gcc-patches/2009-11/msg00297.html

and while you're at it, please look at this one:
http://gcc.gnu.org/ml/gcc-patches/2009-11/msg00731.html

                Thanks,
                --Kaveh