[PATCH]: fix libreadline5 linked applications sending meta_on or meta_off to stdout

View: New views
2 Messages — Rating Filter:   Alert me  

[PATCH]: fix libreadline5 linked applications sending meta_on or meta_off to stdout

by Chandru-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

This is a request to review the problem description and the patch following it in this mail.
I am sending this mail on behalf of  Carsten Jacobi.
Thanks,
Chandru


From: Carsten Jacobi
Problem Description:-
All libncurses5 and consequently libreadline5 linked applications send meta_on
or meta_off to stdout, this disturbs many programs

Steps to Reproduce:-

1. Start a python one-liner like this:
jacobi@mclint:~> python -c 'import readline' | xxd
0000000: 1b5b 3f31 3033 3468                      .[?1034h

The output can confuse many applications that don't expect it. There shouldn't be any output after this command!

A bug also exists in Gentoo Project:
http://bugs.gentoo.org/246091


Signed-off-by: Carsten Jacobi <jacobi@...>
---

--- ncurses-5.7/misc/terminfo.src.orig 2009-09-22 15:00:29.000000000 +0530
+++ ncurses-5.7/misc/terminfo.src 2009-09-22 15:01:22.000000000 +0530
@@ -3241,14 +3241,14 @@ xterm-basic|modern xterm terminal emulat
  kmous=\E[M, mc0=\E[i, mc4=\E[4i, mc5=\E[5i, meml=\El,
  memu=\Em, op=\E[39;49m, rc=\E8, rev=\E[7m, ri=\EM,
  rmacs=\E(B, rmam=\E[?7l, rmcup=\E[?1049l, rmir=\E[4l,
- rmkx=\E[?1l\E>, rmm=\E[?1034l, rmso=\E[27m, rmul=\E[24m,
+ rmkx=\E[?1l\E>, rmso=\E[27m, rmul=\E[24m,
  rs1=\Ec, rs2=\E[!p\E[?3;4l\E[4l\E>, sc=\E7,
  setab=\E[4%p1%dm, setaf=\E[3%p1%dm,
  setb=\E[4%?%p1%{1}%=%t4%e%p1%{3}%=%t6%e%p1%{4}%=%t1%e%p1%{6}%=%t3%e%p1%d%;m,
  setf=\E[3%?%p1%{1}%=%t4%e%p1%{3}%=%t6%e%p1%{4}%=%t1%e%p1%{6}%=%t3%e%p1%d%;m,
  sgr=%?%p9%t\E(0%e\E(B%;\E[0%?%p6%t;1%;%?%p2%t;4%;%?%p1%p3%|%t;7%;%?%p4%t;5%;%?%p7%t;8%;m,
  sgr0=\E(B\E[m, smacs=\E(0, smam=\E[?7h, smcup=\E[?1049h,
- smir=\E[4h, smkx=\E[?1h\E=, smm=\E[?1034h, smso=\E[7m,
+ smir=\E[4h, smkx=\E[?1h\E=, smso=\E[7m,
  smul=\E[4m, tbc=\E[3g, vpa=\E[%i%p1%dd, use=vt100+enq,
 
 # From: David J. MacKenzie <djm@...>, 14 Nov 1997






_______________________________________________
Bug-ncurses mailing list
Bug-ncurses@...
http://lists.gnu.org/mailman/listinfo/bug-ncurses

Re: [PATCH]: fix libreadline5 linked applications sending meta_on or meta_off to stdout

by Thomas Dickey-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Tue, 22 Sep 2009, Chandru wrote:

> This is a request to review the problem description and the patch following it in this mail.
> I am sending this mail on behalf of  Carsten Jacobi.
> Thanks,
> Chandru
>
>
> From: Carsten Jacobi
> Problem Description:-
> All libncurses5 and consequently libreadline5 linked applications send meta_on
> or meta_off to stdout, this disturbs many programs

that's a bug in libreadline5.

(good luck reporting there - maintainer's ignored my comments so far)

>
> Steps to Reproduce:-
>
> 1. Start a python one-liner like this:
> jacobi@mclint:~> python -c 'import readline' | xxd
> 0000000: 1b5b 3f31 3033 3468                      .[?1034h
>
> The output can confuse many applications that don't expect it. There shouldn't be any output after this command!
>
> A bug also exists in Gentoo Project:
> http://bugs.gentoo.org/246091
>
>
> Signed-off-by: Carsten Jacobi <jacobi@...>
> ---
>
> --- ncurses-5.7/misc/terminfo.src.orig 2009-09-22 15:00:29.000000000 +0530
> +++ ncurses-5.7/misc/terminfo.src 2009-09-22 15:01:22.000000000 +0530
> @@ -3241,14 +3241,14 @@ xterm-basic|modern xterm terminal emulat
> kmous=\E[M, mc0=\E[i, mc4=\E[4i, mc5=\E[5i, meml=\El,
> memu=\Em, op=\E[39;49m, rc=\E8, rev=\E[7m, ri=\EM,
> rmacs=\E(B, rmam=\E[?7l, rmcup=\E[?1049l, rmir=\E[4l,
> - rmkx=\E[?1l\E>, rmm=\E[?1034l, rmso=\E[27m, rmul=\E[24m,
> + rmkx=\E[?1l\E>, rmso=\E[27m, rmul=\E[24m,
> rs1=\Ec, rs2=\E[!p\E[?3;4l\E[4l\E>, sc=\E7,
> setab=\E[4%p1%dm, setaf=\E[3%p1%dm,
> setb=\E[4%?%p1%{1}%=%t4%e%p1%{3}%=%t6%e%p1%{4}%=%t1%e%p1%{6}%=%t3%e%p1%d%;m,
> setf=\E[3%?%p1%{1}%=%t4%e%p1%{3}%=%t6%e%p1%{4}%=%t1%e%p1%{6}%=%t3%e%p1%d%;m,
> sgr=%?%p9%t\E(0%e\E(B%;\E[0%?%p6%t;1%;%?%p2%t;4%;%?%p1%p3%|%t;7%;%?%p4%t;5%;%?%p7%t;8%;m,
> sgr0=\E(B\E[m, smacs=\E(0, smam=\E[?7h, smcup=\E[?1049h,
> - smir=\E[4h, smkx=\E[?1h\E=, smm=\E[?1034h, smso=\E[7m,
> + smir=\E[4h, smkx=\E[?1h\E=, smso=\E[7m,
> smul=\E[4m, tbc=\E[3g, vpa=\E[%i%p1%dd, use=vt100+enq,
>
> # From: David J. MacKenzie <djm@...>, 14 Nov 1997
>
>
>
>
>
>
> _______________________________________________
> Bug-ncurses mailing list
> Bug-ncurses@...
> http://lists.gnu.org/mailman/listinfo/bug-ncurses
>

--
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net


_______________________________________________
Bug-ncurses mailing list
Bug-ncurses@...
http://lists.gnu.org/mailman/listinfo/bug-ncurses