[PATCH] Add PCI-IDs for ASUS-F5SL and some SiS chips

[thacrazze]

Hello,

I made a patch. This patch  adding the PC-IDs for the ASUS F5SL-AP177D
Notebook and some SiS chips

> product ATI RADEON_M82_95C4 0x95c4 Mobility Radeon HD 3400 Series (M82)
adopted from: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=blob_plain;f=src/rhd_id.c
and http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-ati.git;a=blob_plain;f=src/ati_pciids_gen.h

> product SIS 7502 0x7502 7502 HD Sound
adopted from: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;f=sound/pci/hda/hda_intel.c;h=2b6bd3139b86d09203d5a9a0b4084a9d9d51e4ba;hp=288ab07648305576a4f2b754c6102e55a76502f5;hb=47672310789431c16de22f16934febf4d55b4bb0;hpb=a93bf99077886d209f8e72bc134e1ceb36e76aa2

For SiS 671 see:
http://www.sis.com/products/sis671.htm

And for SiS 966 and 968 see:
http://www.sis.com/products/sis966.htm
http://www.sis.com/products/sis968.htm
(useful for comparison with the already existing 965 PCI ID:
http://www.sis.com/products/sis965.htm)

This is my first patch. It would give me great pleasure if someone
commit this patch :)

The patch is attached.

Best regards,
thacrazze

[pcidevs+asus-f5sl.patch]

---

--- pcidevs.old 2008-09-07 16:47:44.000000000 +0200
+++ pcidevs 2008-09-07 17:16:13.000000000 +0200
@@ -1320,6 +1320,7 @@
 product ATI RS690_PPB_7915 0x7915 RS690 PCI to PCI-Express Port 1 Bridge
 product ATI RS690_PPB_7916 0x7916 RS690 PCI to PCI-Express Port 2 Bridge
 product ATI RS690_PPB_7917 0x7917 RS690 PCI to PCI-Express Port 3 Bridge
+product ATI RADEON_M82_95C4 0x95c4 Mobility Radeon HD 3400 Series (M82)
 product ATI RADEON_HD2600_XT 0x9588 Radeon HD2600 XT GDDR3
 product ATI RADEON_HD2600_HD 0xaa08 Radeon HD2600 HD Audio Controller
 
@@ -3583,7 +3584,9 @@
 product SIS 180_SATA 0x0180 180 SATA controller
 product SIS 181_SATA 0x0181 181 SATA controller
 product SIS 182_SATA 0x0182 182 SATA controller
+product SIS 183_SATA 0x0183 183 SATA controller
 product SIS 190 0x0190 190 Ethernet
+product SIS 191 0x0191 191 Gigabit Ethernet
 product SIS 5597_VGA 0x0200 5597/5598 integrated VGA
 product SIS 300 0x0300 300/305 AGP VGA
 product SIS 85C501 0x0406 85C501
@@ -3606,6 +3609,7 @@
 product SIS 655 0x0655 655 Host Bridge
 product SIS 658 0x0658 658 Host Bridge
 product SIS 661 0x0661 661 Host Bridge
+product SIS 671 0x0671 671 Host Bridge
 product SIS 730 0x0730 730 Host Bridge
 product SIS 733 0x0733 733 Host Bridge
 product SIS 735 0x0735 735 Host Bridge
@@ -3627,6 +3631,8 @@
 product SIS 963 0x0963 963 Host Bridge
 product SIS 964 0x0964 964 Host Bridge
 product SIS 965 0x0965 965 Host Bridge
+product SIS 966 0x0965 966 Host Bridge
+product SIS 968 0x0965 968 Host Bridge
 product SIS 5597_IDE 0x5513 5597/5598 IDE controller
 product SIS 5597_HB 0x5597 5597/5598 host bridge
 product SIS 530VGA 0x6306 530 GUI Accelerator+3D
@@ -3637,6 +3643,7 @@
 product SIS 7012_AC 0x7012 7012 AC-97 Sound
 product SIS 7016 0x7016 7016 10/100 Ethernet
 product SIS 7018 0x7018 7018 Sound
+product SIS 7502 0x7502 7502 HD Sound
 
 /* Silicon Motion products */
 product SILMOTION SM710 0x0710 LynxEM

---

[thacrazze]

I found two mistakes

Here I attached the corrected version

On Sun, Sep 7, 2008 at 5:39 PM, thacrazze <thacrazze@...> wrote:

> Hello,
>
> I made a patch. This patch  adding the PC-IDs for the ASUS F5SL-AP177D
> Notebook and some SiS chips
>
>> product ATI RADEON_M82_95C4   0x95c4  Mobility Radeon HD 3400 Series (M82)
> adopted from: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=blob_plain;f=src/rhd_id.c
> and http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-ati.git;a=blob_plain;f=src/ati_pciids_gen.h
>
>> product SIS 7502              0x7502  7502 HD Sound
> adopted from: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;f=sound/pci/hda/hda_intel.c;h=2b6bd3139b86d09203d5a9a0b4084a9d9d51e4ba;hp=288ab07648305576a4f2b754c6102e55a76502f5;hb=47672310789431c16de22f16934febf4d55b4bb0;hpb=a93bf99077886d209f8e72bc134e1ceb36e76aa2
>
> For SiS 671 see:
> http://www.sis.com/products/sis671.htm
>
> And for SiS 966 and 968 see:
> http://www.sis.com/products/sis966.htm
> http://www.sis.com/products/sis968.htm
> (useful for comparison with the already existing 965 PCI ID:
> http://www.sis.com/products/sis965.htm)
>
> This is my first patch. It would give me great pleasure if someone
> commit this patch :)
>
> The patch is attached.
>
> Best regards,
> thacrazze
>

[pcidevs+asus-f5sl.patch]

---

--- pcidevs.old 2008-09-07 16:47:44.000000000 +0200
+++ pcidevs 2008-09-07 17:57:37.000000000 +0200
@@ -1320,6 +1320,7 @@
 product ATI RS690_PPB_7915 0x7915 RS690 PCI to PCI-Express Port 1 Bridge
 product ATI RS690_PPB_7916 0x7916 RS690 PCI to PCI-Express Port 2 Bridge
 product ATI RS690_PPB_7917 0x7917 RS690 PCI to PCI-Express Port 3 Bridge
+product ATI RADEON_M82_95C4 0x95c4 Mobility Radeon HD 3400 Series (M82)
 product ATI RADEON_HD2600_XT 0x9588 Radeon HD2600 XT GDDR3
 product ATI RADEON_HD2600_HD 0xaa08 Radeon HD2600 HD Audio Controller
 
@@ -3583,7 +3584,9 @@
 product SIS 180_SATA 0x0180 180 SATA controller
 product SIS 181_SATA 0x0181 181 SATA controller
 product SIS 182_SATA 0x0182 182 SATA controller
+product SIS 183_SATA 0x0183 183 SATA controller
 product SIS 190 0x0190 190 Ethernet
+product SIS 191 0x0191 191 Gigabit Ethernet
 product SIS 5597_VGA 0x0200 5597/5598 integrated VGA
 product SIS 300 0x0300 300/305 AGP VGA
 product SIS 85C501 0x0406 85C501
@@ -3606,6 +3609,7 @@
 product SIS 655 0x0655 655 Host Bridge
 product SIS 658 0x0658 658 Host Bridge
 product SIS 661 0x0661 661 Host Bridge
+product SIS 671 0x0671 671 Host Bridge
 product SIS 730 0x0730 730 Host Bridge
 product SIS 733 0x0733 733 Host Bridge
 product SIS 735 0x0735 735 Host Bridge
@@ -3627,6 +3631,8 @@
 product SIS 963 0x0963 963 Host Bridge
 product SIS 964 0x0964 964 Host Bridge
 product SIS 965 0x0965 965 Host Bridge
+product SIS 966 0x0966 966 Host Bridge
+product SIS 968 0x0968 968 Host Bridge
 product SIS 5597_IDE 0x5513 5597/5598 IDE controller
 product SIS 5597_HB 0x5597 5597/5598 host bridge
 product SIS 530VGA 0x6306 530 GUI Accelerator+3D
@@ -3637,6 +3643,7 @@
 product SIS 7012_AC 0x7012 7012 AC-97 Sound
 product SIS 7016 0x7016 7016 10/100 Ethernet
 product SIS 7018 0x7018 7018 Sound
+product SIS 7502 0x7502 7502 HD Sound
 
 /* Silicon Motion products */
 product SILMOTION SM710 0x0710 LynxEM

---

[thacrazze]

No interest?

On Sun, Sep 7, 2008 at 5:59 PM, thacrazze <thacrazze@...> wrote:

> I found two mistakes
>
> Here I attached the corrected version
>
> On Sun, Sep 7, 2008 at 5:39 PM, thacrazze <thacrazze@...> wrote:
>> Hello,
>>
>> I made a patch. This patch  adding the PC-IDs for the ASUS F5SL-AP177D
>> Notebook and some SiS chips
>>
>>> product ATI RADEON_M82_95C4   0x95c4  Mobility Radeon HD 3400 Series (M82)
>> adopted from: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=blob_plain;f=src/rhd_id.c
>> and http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-ati.git;a=blob_plain;f=src/ati_pciids_gen.h
>>
>>> product SIS 7502              0x7502  7502 HD Sound
>> adopted from: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;f=sound/pci/hda/hda_intel.c;h=2b6bd3139b86d09203d5a9a0b4084a9d9d51e4ba;hp=288ab07648305576a4f2b754c6102e55a76502f5;hb=47672310789431c16de22f16934febf4d55b4bb0;hpb=a93bf99077886d209f8e72bc134e1ceb36e76aa2
>>
>> For SiS 671 see:
>> http://www.sis.com/products/sis671.htm
>>
>> And for SiS 966 and 968 see:
>> http://www.sis.com/products/sis966.htm
>> http://www.sis.com/products/sis968.htm
>> (useful for comparison with the already existing 965 PCI ID:
>> http://www.sis.com/products/sis965.htm)
>>
>> This is my first patch. It would give me great pleasure if someone
>> commit this patch :)
>>
>> The patch is attached.
>>
>> Best regards,
>> thacrazze
>>
>

[thacrazze]

NetBSD died for me. So much ignorance can't be good.

I fulliy agree with Charles M. Hannum opinion, see:
http://mail-index.netbsd.org/netbsd-users/2006/08/30/0016.html

On Sun, Sep 7, 2008 at 5:39 PM, thacrazze <thacrazze@...> wrote:

> Hello,
>
> I made a patch. This patch  adding the PC-IDs for the ASUS F5SL-AP177D
> Notebook and some SiS chips
>
>> product ATI RADEON_M82_95C4   0x95c4  Mobility Radeon HD 3400 Series (M82)
> adopted from: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=blob_plain;f=src/rhd_id.c
> and http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-ati.git;a=blob_plain;f=src/ati_pciids_gen.h
>
>> product SIS 7502              0x7502  7502 HD Sound
> adopted from: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;f=sound/pci/hda/hda_intel.c;h=2b6bd3139b86d09203d5a9a0b4084a9d9d51e4ba;hp=288ab07648305576a4f2b754c6102e55a76502f5;hb=47672310789431c16de22f16934febf4d55b4bb0;hpb=a93bf99077886d209f8e72bc134e1ceb36e76aa2
>
> For SiS 671 see:
> http://www.sis.com/products/sis671.htm
>
> And for SiS 966 and 968 see:
> http://www.sis.com/products/sis966.htm
> http://www.sis.com/products/sis968.htm
> (useful for comparison with the already existing 965 PCI ID:
> http://www.sis.com/products/sis965.htm)
>
> This is my first patch. It would give me great pleasure if someone
> commit this patch :)
>
> The patch is attached.
>
> Best regards,
> thacrazze
>

[Jeremy C. Reed]

> NetBSD died for me. So much ignorance can't be good.
>
> I fulliy agree with Charles M. Hannum opinion, see:

I am curious: by simply adding the pcidevs entries did it also give you
working support for these devices?

If so, please post patches to the PR bug system. You can't assume that the
interested and/or responsible developers are reading a discussion mailing
list. You are very quick to give up since you only posted revised version
a few days ago.

The opinion you linked to has nothing to do with your patch or ignoring a
posting.

NetBSD is a great operating system. Its developers, end-users and
community are knowledgable and very helpful. NetBSD is very innovative,
while being quite reliable and compatible for me. Yes, I have some
hardware needing support but overall my NetBSD experience is enjoyable and
even though I have much experience with many other operating systems
personally and professionally I continue to use NetBSD as my operating
system of choice. It is comfortable and matches my needs. I follow its
progress (and somewhat participate) and see a great future.

[Sarton O'Brien-2]

On Fri, Sep 12, 2008 at 05:42:46PM +0200, thacrazze wrote:
> NetBSD died for me. So much ignorance can't be good.

Don't take it to heart, there's a few people on here that tackle
problems together but the correct way as someone else said, is to
send-pr with your patch.

Interest is generally based on a mutual necessity, or having the
knowledge to share and the time willing. Some of us may know less
than you :S  This is just a mailling list.

Each to their own, but I think if you use the correct channels and
submit all the relevent info, you'd see a result.

Sarton

[thacrazze]

Thank you for the answers and sorry for my late answer.

Ok, I try to send the patch to PR.

But why has NetBSD for webcams but not for the most of the ethernet
chips? I think the project sets the wrong prioritys.

e.g. What is the use of my webcam if I do not have access to the
Internet with NetBSD because missing network drivers (no LAN, no
WLAN)?

Best regards,
thacrazze

[Martin Husemann]

On Thu, Sep 18, 2008 at 08:53:31PM +0200, thacrazze wrote:
> But why has NetBSD for webcams but not for the most of the ethernet
> chips? I think the project sets the wrong prioritys.

What are you talking about? Wich "most of the ethernet chips" do not work,
and what priorities do you assume (or why)? There is some misunderstanding
going on, obviously.

Martin

[Paul Goyette]

On Thu, 18 Sep 2008, thacrazze wrote:

> Thank you for the answers and sorry for my late answer.
>
> Ok, I try to send the patch to PR.
>
> But why has NetBSD for webcams but not for the most of the ethernet
> chips? I think the project sets the wrong prioritys.

NetBSD is a volunteer project. People write device drivers for the
hardware that they have and need.

Please feel free to write device drivers for your network cards!

> e.g. What is the use of my webcam if I do not have access to the
> Internet with NetBSD because missing network drivers (no LAN, no
> WLAN)?

See above!


----------------------------------------------------------------------
|   Paul Goyette   | PGP DSS Key fingerprint: |  E-mail addresses:   |
| Customer Service | FA29 0E3B 35AF E8AE 6651 |  paul@...   |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette@... |
----------------------------------------------------------------------

[Jeremy C. Reed]

> But why has NetBSD for webcams but not for the most of the ethernet
> chips? I think the project sets the wrong prioritys.
>
> e.g. What is the use of my webcam if I do not have access to the
> Internet with NetBSD because missing network drivers (no LAN, no
> WLAN)?

NetBSD is volunteer-ran, volunteer-developed open source operating system.
We shouldn't force volunteers to work on code. Volunteers work on what
they are interested in and many believe that is what gives the best
results. The level of involvement is based on the volunteer's own freetime
and level of interest and enjoyment. (Of course some volunteers work
directly on what they personally need or their company requests even if
not enjoyable.)

Nevertheless, money talks. And NetBSD has a foundation that can accept
and distribute funding. Or as another option consider using a bounty such
as http://wiki.netbsd.se/Bounties

I have often seen kind volunteers work on projects outside of their common
interest area simple because they want to benefit others, learn more, or
trade projects.

By the way, if we had required our recent video/webcam expert(s) to code
network drivers instead, we most likely would have not gained either code.

[thacrazze]

Debian, Arch Linux is also a volunteer-ran, volunteer-developed open
source operating system. And on these operating systems works my
ethernet, wireless lan, sound, 3d acceleration, power management
out-of-the-box.
On OpenBSD works at least my wireless network (ath driver) and the FN
keys (acpiasus driver) in contrast to NetBSD.

So now I say Good bye NetBSD for me.

--- PLEASE DON'T ANSWER TO THIS POST, I DONT READ IT ---

[Joerg Sonnenberger]

On Fri, Sep 19, 2008 at 10:36:26PM +0200, thacrazze wrote:
> Debian, Arch Linux is also a volunteer-ran, volunteer-developed open
> source operating system.

They all use the linux kernel, which to a non-trivial degree is nowaday
developed for profit. I haven't seen a patch for actual functionality
yet. Just adding the PCI IDs provides you with no functionality what so
ever. Frankly, the behavior shown in this thread doesn't make me want to
go and dig out changes from any other OS.

Joerg

[Thor Lancelot Simon]

On Tue, Sep 09, 2008 at 04:59:25PM +0200, thacrazze wrote:
>
> No interest?

Your patches don't *do* anything -- they don't add support for any new
devices, they just add their IDs to a file so their names are printed
more nicely, if the user even turns that on.

I'm not sure why you expected much interest in such a patch...

Thor

[Sarton O'Brien-2]

thacrazze wrote:
> Debian, Arch Linux is also a volunteer-ran, volunteer-developed open
> source operating system. And on these operating systems works my
> ethernet, wireless lan, sound, 3d acceleration, power management
> out-of-the-box.
> On OpenBSD works at least my wireless network (ath driver) and the FN
> keys (acpiasus driver) in contrast to NetBSD.
>
> So now I say Good bye NetBSD for me.
>  

I use archlinux and NetBSD. The two are good for completely different
reasons. It's about using the right tool for the job. Arch has 3d
acceleration out of the box? Now you're just lying. Yes there are
drivers for chipsets that NetBSD doesn't support but that's linux in
general. Ever heard the term 'Apples and oranges'?

There's lack of hardware support because people, volunteers, you,
haven't submitted any useful code when identifying what doesn't work.
Blame yourself.

You seem to need a new career ... or a better hobby.

Good luck.