[PATCH] Bug in 1.4.18: undefined variable: aSpamIds

Hi,
we've found bug in squirrelmail/plugins/filters/filters.php causing :
Undefined variable: aSpamIds in
/usr/share/squirrelmail/plugins/filters/filters.php on line 458

this prevents users from logging in.

Problem is in if (count($aSpamIds))... because this variable isn't initialized
always.

We've used attached patch, which should fix this.

Regards,
Michal Hlavinka


[squirrelmail.patch]

---

diff -up squirrelmail/plugins/filters/filters.php.orig squirrelmail/plugins/filters/filters.php
--- squirrelmail/plugins/filters/filters.php.orig 2009-05-19 08:38:20.756736040 +0200
+++ squirrelmail/plugins/filters/filters.php 2009-05-19 08:38:20.792605106 +0200
@@ -415,7 +415,7 @@ function spam_filters($imap_stream) {
     $messages = parseFetch($read, $search_array);
     
     $bulkquery = (strlen($SpamFilters_BulkQuery) > 0 ? true : false);
-
+    $aSpamIds = array();
     foreach($messages as $id=>$message) {
         if (isset($message['UID'])) {
             $MsgNum = $message['UID'];

---

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables
unlimited royalty-free distribution of the report engine
for externally facing server and web deployment.
http://p.sf.net/sfu/businessobjects
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-devel@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel

[Paul Lesniewski]

On Mon, May 18, 2009 at 11:46 PM, Michal Hlavinka <mhlavink@...> wrote:

> Hi,
> we've found bug in squirrelmail/plugins/filters/filters.php causing :
> Undefined variable: aSpamIds in
> /usr/share/squirrelmail/plugins/filters/filters.php on line 458
>
> this prevents users from logging in.
>
> Problem is in if (count($aSpamIds))... because this variable isn't initialized
> always.
>
> We've used attached patch, which should fix this.

Thanks for spotting this.  It had been corrected in our development
code, but somehow did not make its way into the stable code.  Hrmph.
I've committed the fix.

--
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables
unlimited royalty-free distribution of the report engine
for externally facing server and web deployment.
http://p.sf.net/sfu/businessobjects
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-devel@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel