[PATCH] Document that FT_Get_X11_Font_Format is an intrinsic call

View: New views
3 Messages — Rating Filter:   Alert me  

[PATCH] Document that FT_Get_X11_Font_Format is an intrinsic call

by Ralph Giles-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Working on the the freetype integration in ghostscript again, I went
looking for a way to identify whether an FT_Face was a "Type 1" or
"TrueType". There is a function which implements this, confusingly
named FT_Get_X11_Font_Format() because it was originally added (in
2002) for the benefit of XFree86, even though the documentation is
aware that PDF implementations also need this feature. I was concerned
about this being platform-dependent and traced through some of the
code; it is completely intrinsic to freetype and doesn't depend on X11
at all.
i
Please consider applying the attached documentation patch to clarify this.

Going further, what people think about making this part of the core
api as FT_Get_Face_Format()? Given the broader usage nowadays I think
that makes more sense than having it only in an optional module.

 -r

[0001-Document-that-FT_Get_X11_Font_Format-is-a-general.patch]

From 6783bc25ab1ce8128b0fd44d5052f49d284ecb8f Mon Sep 17 00:00:00 2001
From: Ralph Giles <giles@...>
Date: Wed, 26 Aug 2009 13:27:04 -0700
Subject: [PATCH] Document that FT_Get_X11_Font_Format() is a general call.

This function was originally added to return the underlying font
format in a way which was compatible with the needs of the XFree86
font server. However, a function of this sort is also necessary when
freetype is used by PDF interpreters which apply different rules
based on the font format.

The X11 namespace is confusing for such users. This commit ameliorates
that confusion by documenting that this function is in fact entirely
internal to freetype and doesn't depend on X11 in any way.
---
 include/freetype/ftxf86.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/include/freetype/ftxf86.h b/include/freetype/ftxf86.h
index ae9ff07..8c68afd 100644
--- a/include/freetype/ftxf86.h
+++ b/include/freetype/ftxf86.h
@@ -49,6 +49,9 @@ FT_BEGIN_HEADER
   /*   however, there are special cases (like in PDF devices) where it is  */
   /*   important to differentiate, in spite of FreeType's uniform API.     */
   /*                                                                       */
+  /*   This function is in the X11/xf86 namespace for historical reasons   */
+  /*   and in no way depends on that windowing system.                     */
+  /*                                                                       */
   /*************************************************************************/
 
 
--
1.6.0.4



_______________________________________________
Freetype-devel mailing list
Freetype-devel@...
http://lists.nongnu.org/mailman/listinfo/freetype-devel

Re: [PATCH] Document that FT_Get_X11_Font_Format is an intrinsic call

by Werner LEMBERG :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


> Please consider applying the attached documentation patch to clarify
> this.

Applied, thanks.

> Going further, what people think about making this part of the core
> api as FT_Get_Face_Format()?  Given the broader usage nowadays I
> think that makes more sense than having it only in an optional
> module.

I don't object.  Patches, please :-)


    Werner


_______________________________________________
Freetype-devel mailing list
Freetype-devel@...
http://lists.nongnu.org/mailman/listinfo/freetype-devel

Re: [PATCH] Document that FT_Get_X11_Font_Format is an intrinsic call

by Ralph Giles-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, Aug 28, 2009 at 12:09 AM, Werner LEMBERG<wl@...> wrote:

> Applied, thanks.

Thanks.

>> Going further, what people think about making this part of the core
>> api as FT_Get_Face_Format()?  Given the broader usage nowadays I
>> think that makes more sense than having it only in an optional
>> module.
>
> I don't object.  Patches, please :-)

Noted. :)

 -r


_______________________________________________
Freetype-devel mailing list
Freetype-devel@...
http://lists.nongnu.org/mailman/listinfo/freetype-devel