[PATCH] Fix KDE 4.3 oxygen window border "chin"

Hello,

I've attached a tiny patch for the oxygen window border to keep the side and bottom borders proportional over a greater range of border sizes.  The code comment suggested the bottom border is being fixed to a minimum of 7 pixels to maintain rounding.  This exceeds the default bottom border from KDE 4.2 and gives all windows, even for the default border size, a heavy looking "chin".  This also tends to make window items/widgets located in the bottom corners poorly balanced horizontally-to-vertically from the edges of the window.

The patch is very simple.  It just allows the bottom border to get little smaller.  There is no descernable effect the correct rounding of the bottom corners and the dotted grab handles remain visible.  For normal border sizes it also restores the balance that existed in KDE 4.2.

A pic is attached with the before and after.

Let me know if this patch is ok and I'll commit it.

Hope this helps,
Andrew Lake

[oxygenclient.diff]

---

Index: oxygenclient.cpp
===================================================================
--- oxygenclient.cpp (revision 998585)
+++ oxygenclient.cpp (working copy)
@@ -143,7 +143,7 @@
                 // Even for thin borders (2px wide) we want to preserve
                 // the rounded corners having a minimum height of 7px
                 if (lm == LM_BorderBottom) {
-                    return qMax(frameWidth, 7);
+                    return qMax(frameWidth, 3);
                 } else {
                     return frameWidth;
                 }

---

______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

Am Saturday 08 August 2009 07:06:27 schrieb Jamboarder:
> The patch is very simple.  It just allows the bottom border to get little
> smaller.  There is no descernable effect the correct rounding of the bottom
> corners and the dotted grab handles remain visible.  For normal border
> sizes it also restores the balance that existed in KDE 4.2.

Looking at the comment, it seems intended ;)

I have a slightly different version in my working copy, because I think when
frameWidth is less than 3 pixels, the bottomBorder should be 4 pixels to keep
rounding, but I am not 100 % sure either.

Christoph Feck (kdepepo)

[attachment removed]
______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

A Sábado, 8 de Agosto de 2009 06:06:27 Jamboarder você escreveu:

> Hello,
>
> I've attached a tiny patch for the oxygen window border to keep the side
> and bottom borders proportional over a greater range of border sizes.  The
> code comment suggested the bottom border is being fixed to a minimum of 7
> pixels to maintain rounding.  This exceeds the default bottom border from
> KDE 4.2 and gives all windows, even for the default border size, a heavy
> looking "chin".  This also tends to make window items/widgets located in
> the bottom corners poorly balanced horizontally-to-vertically from the
> edges of the window.
>
> The patch is very simple.  It just allows the bottom border to get little
> smaller.  There is no descernable effect the correct rounding of the bottom
> corners and the dotted grab handles remain visible.  For normal border
> sizes it also restores the balance that existed in KDE 4.2.
>
> A pic is attached with the before and after.
>
> Let me know if this patch is ok and I'll commit it.
>
> Hope this helps,
> Andrew Lake

just forward this patch to casper boemen for review on the code bit, i tend to
like the patch and what it does to the look, just worried on the hit area on
the corner becoming to small, think we could talk to kwin people to do some
magic in that  

--
Oxygen coordinator  
______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

A Sábado, 8 de Agosto de 2009 11:48:15 Nuno Pinheiro você escreveu:

> A Sábado, 8 de Agosto de 2009 06:06:27 Jamboarder você escreveu:
> > Hello,
> >
> > I've attached a tiny patch for the oxygen window border to keep the side
> > and bottom borders proportional over a greater range of border sizes.
> > The code comment suggested the bottom border is being fixed to a minimum
> > of 7 pixels to maintain rounding.  This exceeds the default bottom border
> > from KDE 4.2 and gives all windows, even for the default border size, a
> > heavy looking "chin".  This also tends to make window items/widgets
> > located in the bottom corners poorly balanced horizontally-to-vertically
> > from the edges of the window.
> >
> > The patch is very simple.  It just allows the bottom border to get little
> > smaller.  There is no descernable effect the correct rounding of the
> > bottom corners and the dotted grab handles remain visible.  For normal
> > border sizes it also restores the balance that existed in KDE 4.2.
> >
> > A pic is attached with the before and after.
> >
> > Let me know if this patch is ok and I'll commit it.
> >
> > Hope this helps,
> > Andrew Lake
>
> just forward this patch to casper boemen for review on the code bit, i tend
> to like the patch and what it does to the look, just worried on the hit
> area on the corner becoming to small, think we could talk to kwin people to
> do some magic in that

ok so the pacth is ok to go in but we need to make some changes into the
shadow code so that the hit area for the corner goes into the shadow area as
well making it easy to click the corner without much effort.
Composition is such a Godsend :).




--
Oxygen coordinator  
______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists

Am Saturday 08 August 2009 13:13:23 schrieb Nuno Pinheiro:
> [...] but we need to make some changes into the
> shadow code so that the hit area for the corner goes into the shadow area
> as well making it easy to click the corner without much effort.

The shadow itself should not be "clickable", but transparent to mouse events.
This only makes sense if you graphically indicate a bigger click region
(similar to what the BII or Modern System deco do at the corner).
______________________________________________________________________________
kde-artists@... |  https://mail.kde.org/mailman/listinfo/kde-artists