[PATCH] Fix natVMSecureRandomWin32.cc

[JonY-3]

Hi,

This patch fixes a compile problem with natVMSecureRandomWin32.cc for
mingw targets. It looks like a namespace issue.

OK?

Index: libjava/gnu/java/security/jce/prng/natVMSecureRandomWin32.cc
===================================================================
--- libjava/gnu/java/security/jce/prng/natVMSecureRandomWin32.cc (revision 150933)
+++ libjava/gnu/java/security/jce/prng/natVMSecureRandomWin32.cc (working copy)
@@ -26,7 +26,7 @@
 gnu::java::security::jce::prng::VMSecureRandom::natGenerateSeed(jbyteArray byte_array, jint offset, jint length)
 {
   if (length != 0)
-    throw new UnsupportedOperationException (
+    throw new java::lang::UnsupportedOperationException (
       JvNewStringLatin1 ("natGenerateSeed is not available for Win32 target."));
   return 0;
 }

[Tom Tromey]

>>>>> "JonY" == JonY  <10walls@...> writes:

JonY> This patch fixes a compile problem with natVMSecureRandomWin32.cc for
JonY> mingw targets. It looks like a namespace issue.

JonY> OK?

This is ok with a ChangeLog entry.

Tom

[JonY-3]

On 8/27/2009 23:50, Tom Tromey wrote:

>>>>>> "JonY" == JonY<10walls@...>  writes:
>
> JonY>  This patch fixes a compile problem with natVMSecureRandomWin32.cc for
> JonY>  mingw targets. It looks like a namespace issue.
>
> JonY>  OK?
>
> This is ok with a ChangeLog entry.
>
> Tom
>

Hi,
Is this OK?

2009-08-27  Jonathan Yong  <jon_y@...>

        * gnu/java/security/jce/prng/natVMSecureRandomWin32.cc: Correct
        UnsupportedOperationException namespace.

[JonY-3]

On 8/28/2009 00:01, JonY wrote:

> On 8/27/2009 23:50, Tom Tromey wrote:
>>>>>>> "JonY" == JonY<10walls@...> writes:
>>
>> JonY> This patch fixes a compile problem with
>> natVMSecureRandomWin32.cc for
>> JonY> mingw targets. It looks like a namespace issue.
>>
>> JonY> OK?
>>
>> This is ok with a ChangeLog entry.
>>
>> Tom
>>
>
> Hi,
> Is this OK?
>
> 2009-08-27 Jonathan Yong <jon_y@...>
>
> * gnu/java/security/jce/prng/natVMSecureRandomWin32.cc: Correct
> UnsupportedOperationException namespace.
>

Ping. Anybody with commit privileges?

[Dave Korn-6]

JonY wrote:

> On 8/28/2009 00:01, JonY wrote:
>> On 8/27/2009 23:50, Tom Tromey wrote:
>>>>>>>> "JonY" == JonY<10walls@...> writes:
>>>
>>> JonY> This patch fixes a compile problem with
>>> natVMSecureRandomWin32.cc for
>>> JonY> mingw targets. It looks like a namespace issue.
>>>
>>> JonY> OK?
>>>
>>> This is ok with a ChangeLog entry.
>>>
>>> Tom
>>>
>>
>> Hi,
>> Is this OK?
>>
>> 2009-08-27 Jonathan Yong <jon_y@...>
>>
>> * gnu/java/security/jce/prng/natVMSecureRandomWin32.cc: Correct
>> UnsupportedOperationException namespace.
>>
>
> Ping. Anybody with commit privileges?

  Hi Jon, I've noticed your patch; assuming nobody gets to it before me, I'll
check in your patch for you once I've got the go-ahead for my own libjava
patch that's currently awaiting review.

    cheers,
      DaveK

[JonY-3]

On 9/1/2009 07:37, Dave Korn wrote:

> JonY wrote:
>> On 8/28/2009 00:01, JonY wrote:
>>> On 8/27/2009 23:50, Tom Tromey wrote:
>>>>>>>>> "JonY" == JonY<10walls@...>  writes:
>>>>
>>>> JonY>  This patch fixes a compile problem with
>>>> natVMSecureRandomWin32.cc for
>>>> JonY>  mingw targets. It looks like a namespace issue.
>>>>
>>>> JonY>  OK?
>>>>
>>>> This is ok with a ChangeLog entry.
>>>>
>>>> Tom
>>>>
>>>
>>> Hi,
>>> Is this OK?
>>>
>>> 2009-08-27 Jonathan Yong<jon_y@...>
>>>
>>> * gnu/java/security/jce/prng/natVMSecureRandomWin32.cc: Correct
>>> UnsupportedOperationException namespace.
>>>
>>
>> Ping. Anybody with commit privileges?
>
>    Hi Jon, I've noticed your patch; assuming nobody gets to it before me, I'll
> check in your patch for you once I've got the go-ahead for my own libjava
> patch that's currently awaiting review.
>

Hi,

Ping. How goes the review?

[Dave Korn-6]

JonY wrote:

> On 9/1/2009 07:37, Dave Korn wrote:
>>
>>    Hi Jon, I've noticed your patch; assuming nobody gets to it before
>> me, I'll
>> check in your patch for you once I've got the go-ahead for my own libjava
>> patch that's currently awaiting review.
>>
>
> Hi,
>
> Ping. How goes the review?

  Taking some time, so I'll just go ahead with your patch.  I'll be updating
all my sandboxes to HEAD at the start of next week, and I'll check it in when
I do that; I'll ping you when it's there.

    cheers,
      DaveK

[JonY-3]

On 9/12/2009 23:16, Dave Korn wrote:

> JonY wrote:
>> On 9/1/2009 07:37, Dave Korn wrote:
>>>
>>>     Hi Jon, I've noticed your patch; assuming nobody gets to it before
>>> me, I'll
>>> check in your patch for you once I've got the go-ahead for my own libjava
>>> patch that's currently awaiting review.
>>>
>>
>> Hi,
>>
>> Ping. How goes the review?
>
>    Taking some time, so I'll just go ahead with your patch.  I'll be updating
> all my sandboxes to HEAD at the start of next week, and I'll check it in when
> I do that; I'll ping you when it's there.
>
>      cheers,
>        DaveK
>
>

OK, thanks.

[Dave Korn-6]

JonY wrote:

> On 8/27/2009 23:50, Tom Tromey wrote:
>>>>>>> "JonY" == JonY<10walls@...>  writes:
>>
>> JonY>  This patch fixes a compile problem with
>> natVMSecureRandomWin32.cc for
>> JonY>  mingw targets. It looks like a namespace issue.
>>
>> JonY>  OK?
>>
>> This is ok with a ChangeLog entry.
>>
>> Tom
>>
>
> Hi,
> Is this OK?
>
> 2009-08-27  Jonathan Yong  <jon_y@...>
>
>     * gnu/java/security/jce/prng/natVMSecureRandomWin32.cc: Correct
>     UnsupportedOperationException namespace.

  I have now checked in your patch for you, at r.151775.  Thanks very much for
helping out!

    cheers,
      DaveK


Index: libjava/ChangeLog
===================================================================
--- libjava/ChangeLog (revision 151773)
+++ libjava/ChangeLog (working copy)
@@ -1,3 +1,8 @@
[phone]  Jonathan Yong  <jon_y@...>
+
+ * gnu/java/security/jce/prng/natVMSecureRandomWin32.cc: Correct
+ UnsupportedOperationException namespace.
+
 2009-09-16  Andrew Haley  <aph@...>
 
  * libgcj_bc.c (__data_start, data_start, _end): Add dummy usage.
Index: libjava/gnu/java/security/jce/prng/natVMSecureRandomWin32.cc
===================================================================
--- libjava/gnu/java/security/jce/prng/natVMSecureRandomWin32.cc (revision 151773)
+++ libjava/gnu/java/security/jce/prng/natVMSecureRandomWin32.cc (working copy)
@@ -26,7 +26,7 @@ jint
 gnu::java::security::jce::prng::VMSecureRandom::natGenerateSeed(jbyteArray byte_array, jint offset, jint length)
 {
   if (length != 0)
-    throw new UnsupportedOperationException (
+    throw new java::lang::UnsupportedOperationException (
       JvNewStringLatin1 ("natGenerateSeed is not available for Win32 target."));
   return 0;
 }