[PATCH] Fix setting BCS in overlay/overlay.c

[Ville Skyttä]

Hi,

The attached patch fixes setting BCS in overlay/overlay.c.  Untested, but
should be Obviously Correct(tm).

[overlay-bcs.patch]

---

# HG changeset patch
# User "Ville Skyttä <ville.skytta@...>"
# Date 1230935937 -7200
# Node ID 66137d3980fdf1700c91d26cc79ea21b238d9b7d
# Parent  7b09e52604bc974cd6232e378e6d9264620cf2d2
Fix setting BCS.

diff -r 7b09e52604bc -r 66137d3980fd overlay/overlay.c
--- a/overlay/overlay.c Thu Dec 25 00:00:00 2008 +0100
+++ b/overlay/overlay.c Sat Jan 03 00:38:57 2009 +0200
@@ -279,7 +279,7 @@
     bcs.contrast = contrast;
     bcs.saturation = saturation;
 
-    if (ioctl(o->dev, EM8300_IOCTL_GETBCS, &bcs)==-1)
+    if (ioctl(o->dev, EM8300_IOCTL_SETBCS, &bcs)==-1)
         {
             perror("Failed setting bcs");
             return -1;

---

------------------------------------------------------------------------------

_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Nicolas Boullis]

Hi Ville,

On Sat, Jan 03, 2009 at 12:44:50AM +0200, Ville Skyttä wrote:
> Hi,
>
> The attached patch fixes setting BCS in overlay/overlay.c.  Untested, but
> should be Obviously Correct(tm).

You're right, it looks obviously correct.
Do you mind if I change the User of the patch to remove the extra quotes
and to change your email to the one you used for the former commits
(@users.sourceforge.net)?

Anyway, I'm curious:
 - Do you use video overlay?
 - As far as I can see, this overlay_set_bcs function is not used
   anywhere. Do you know a use for it?


Cheers,

Nicolas

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Ville Skyttä]

On Thursday 15 January 2009, Nicolas Boullis wrote:

> Hi Ville,
>
> On Sat, Jan 03, 2009 at 12:44:50AM +0200, Ville Skyttä wrote:
> > Hi,
> >
> > The attached patch fixes setting BCS in overlay/overlay.c.  Untested, but
> > should be Obviously Correct(tm).
>
> You're right, it looks obviously correct.
> Do you mind if I change the User of the patch to remove the extra quotes
> and to change your email to the one you used for the former commits
> (@users.sourceforge.net)?

No, go ahead.

> Anyway, I'm curious:
>  - Do you use video overlay?
>  - As far as I can see, this overlay_set_bcs function is not used
>    anywhere. Do you know a use for it?

No, I don't use overlay nor overlay_set_bcs (and I agree it doesn't seem to be
used anywhere), this is just something I came across when grepping through
em8300 sources when doing some small bcs related work for the vdr-dxr3
plugin.

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

[Nicolas Boullis]

Hi,

On Thu, Jan 15, 2009 at 09:37:23AM +0200, Ville Skyttä wrote:
> On Thursday 15 January 2009, Nicolas Boullis wrote:
> >
> > Do you mind if I change the User of the patch to remove the extra quotes
> > and to change your email to the one you used for the former commits
> > (@users.sourceforge.net)?
>
> No, go ahead.

OK; committed.


Thanks for your work,

Nicolas

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel