|
[PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
Hi
I think the current brush outline for fuzzy brushes is too big. The
attached patch improves the brush outline for fuzzy brushes (see
screenshot [1]). If using a higher threshold doesn't result in any
outline at all, the patch fallbacks to the old brush outline so that a
brush outline always is shown even if the brush only has low-intensity
values.
Does this patch make sense to anyone else?
/ Martin
[1] http://www.chromecode.com/temp/improve-fuzzy-brush-outline.png--
My GIMP Blog:
http://www.chromecode.com/[0001-app-Improve-brush-outline-for-fuzzy-brushes.patch]
>From c59b28cd84a94534cf9ad3c309d4666ca8a8eaf4 Mon Sep 17 00:00:00 2001
From: Martin Nordholts <martinn@...>
Date: Sun, 30 Aug 2009 11:40:44 +0200
Subject: [PATCH] app: Improve brush outline for fuzzy brushes
Use a 25% threshold instead of 0% so that we get a nicer outline for
fuzzy brushes. If the 25% doesn't result in a outline at all, fallback
to 0% though.
---
app/base/boundary.h | 4 ++--
app/paint/gimpbrushcore.c | 13 ++++++++++++-
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/app/base/boundary.h b/app/base/boundary.h
index 9577d9c..4cff8bb 100644
--- a/app/base/boundary.h
+++ b/app/base/boundary.h
@@ -19,8 +19,8 @@
#define __BOUNDARY_H__
-/* half intensity for mask */
-#define BOUNDARY_HALF_WAY 127
+#define BOUNDARY_ONE_QUARTER 64
+#define BOUNDARY_HALF_WAY 127
typedef enum
diff --git a/app/paint/gimpbrushcore.c b/app/paint/gimpbrushcore.c
index 1d424c1..4980ca0 100644
--- a/app/paint/gimpbrushcore.c
+++ b/app/paint/gimpbrushcore.c
@@ -849,11 +849,22 @@ gimp_brush_core_create_bound_segs (GimpBrushCore *core,
smooth_region (&PR);
+ /* Use BOUNDARY_ONE_QUARTER to get a nice mask for fuzzy brushes */
boundary = boundary_find (&PR, BOUNDARY_WITHIN_BOUNDS,
0, 0, PR.w, PR.h,
- 0,
+ BOUNDARY_ONE_QUARTER,
&core->n_brush_bound_segs);
+ /* If we didn't get any boundary try without a threshold */
+ if (core->n_brush_bound_segs <= 0)
+ {
+ g_free (boundary);
+ boundary = boundary_find (&PR, BOUNDARY_WITHIN_BOUNDS,
+ 0, 0, PR.w, PR.h,
+ 0,
+ &core->n_brush_bound_segs);
+ }
+
core->brush_bound_segs = boundary_sort (boundary,
core->n_brush_bound_segs,
&num_groups);
--
1.6.2.5
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
Martin Nordholts wrote:
> I think the current brush outline for fuzzy brushes is too big. The
> attached patch improves the brush outline for fuzzy brushes (see
> screenshot [1]). If using a higher threshold doesn't result in any
> outline at all, the patch fallbacks to the old brush outline so that a
> brush outline always is shown even if the brush only has low-intensity
> values.
In my opinion the idea of the brush outline is that it represents its
total area of effect, or in other words, the area where pixels will be
affected in a way or another while drawing. The brush outline for fuzzy
brushes (assuming dynamics aren't applied) *looks* too big, but it
actually isn't. This is most evident by drawing a few strokes with the
fuzzy brush on a transparent layer and then adjusting the alpha level
channel on Colors>Levels to coordinates (0;255) .
A more useful patch (in my opinion) for brush outlines would be making
them change together with brush dynamics (even if the user isn't
actually drawing, just moving the cursor on the drawing area) if they
are enabled. This could be useful in many ways, but I have the
impression it would lead to performance issues.
--
SHIRAKAWA Akira
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
Hi all, My opinion about that is the same as shirakawa if we want to do photography retouch and "superexact" works like these, but artisticaly i would prefer something like Martin says. It is more useful for the eye, if we want to make an stroke fast and not acuratly but in the aprox right place.the old method requieres user imagination to preview in his mind what will happen...
but i have to say that i don´t use this "brush outline feature" becouse it makes my gimp sloooooower with complex outlines.So if somebody has the solution for this... i am listening. best regards
2009/8/30 SHIRAKAWA Akira <shirakawa.akira@...>
Martin Nordholts wrote:
> I think the current brush outline for fuzzy brushes is too big. The
> attached patch improves the brush outline for fuzzy brushes (see
> screenshot [1]). If using a higher threshold doesn't result in any
> outline at all, the patch fallbacks to the old brush outline so that a
> brush outline always is shown even if the brush only has low-intensity
> values.
In my opinion the idea of the brush outline is that it represents its
total area of effect, or in other words, the area where pixels will be
affected in a way or another while drawing. The brush outline for fuzzy
brushes (assuming dynamics aren't applied) *looks* too big, but it
actually isn't. This is most evident by drawing a few strokes with the
fuzzy brush on a transparent layer and then adjusting the alpha level
channel on Colors>Levels to coordinates (0;255) .
A more useful patch (in my opinion) for brush outlines would be making
them change together with brush dynamics (even if the user isn't
actually drawing, just moving the cursor on the drawing area) if they
are enabled. This could be useful in many ways, but I have the
impression it would lead to performance issues.
--
SHIRAKAWA Akira
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
-- _______________________________________ Ramon Miranda http://ramonmirandavisualart.blogspot.comhttp://code.google.com/p/gps-gimp-paint-studio/
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
On Sunday 30 August 2009, Martin Nordholts wrote:
> [1] http://www.chromecode.com/temp/improve-fuzzy-brush-outline.pngOne more thing that has always irritated me (not related to your change
though): The lower-left -> upper right lines ("/") seem to use a different
corner case of the same algorithm (looks like a different algorithm even) as
compared to the other side ("\").
Other than that I think it makes sense to show not the total affected area but
only the area which is affected by more than a certain nonzero threshold (say
opacity >= 20%).
My weekend comment,
Daniel
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
yahvuu wrote:
> hi,
>
> what about using a dashed outline for fuzzy brushes?
> perhaps like a) in
> http://yahvuu.files.wordpress.com/2009/08/fuzzy-outline.pngThis is a very good idea, but I think it would be more logic and
consistent with the style of brush outlines in GIMP if it was the
opposite: solid external outline (representing the brush area limits),
and dashed internal outline.
One of the reasons for this is that hardness (which creates the
fuzzyness) is a brush attribute which can dynamically change with brush
dynamics (in static conditions hardness could be 100% hard, but become
completely fuzzy as drawing pressure increases for example), and would
better work with my proposal of varying in realtime brush outlines
according to them.
--
SHIRAKAWA Akira
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
Hello Martin,
once i suggested at GIMP brainstorm painting two lines for fuzzy brushes and feather borders.
One dotted where pacity = 100% and on with just any secound dot where opacity = 0%.
A center mark would be great too.
So artists know where is the center of the stroke (may for connecting border or painting along a line)
and where is 100% color and where is it faded out.
This border feature would be great for feather borders too (without center mark of course).
Take a look at this mockup:
http://www.neeneenee.de/bart/gimp-border.png
Best regards and happy development!
___/\_______________________________________________________________________
Ich werde nie einen Emmy gewinnen.
|\/\/\/|
| | Bart.
| (O)(O) bart@...
C _)
| ,_/ Linux for Designers - http://my.opera.com/area42/blog/
| / SweeTS delicious Typo3 development - http://typo3.area42.de/
/ \
|
Am Sonntag, den 30.08.2009, 11:42 +0200 schrieb Martin Nordholts:
Hi
I think the current brush outline for fuzzy brushes is too big. The
attached patch improves the brush outline for fuzzy brushes (see
screenshot [1]). If using a higher threshold doesn't result in any
outline at all, the patch fallbacks to the old brush outline so that a
brush outline always is shown even if the brush only has low-intensity
values.
Does this patch make sense to anyone else?
/ Martin
[1] http://www.chromecode.com/temp/improve-fuzzy-brush-outline.png
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
On Sunday 30 August 2009 22:30:54 Eckhard M. Jäger wrote:
> Hello Martin,
>
> once i suggested at GIMP brainstorm painting two lines for fuzzy brushes
> and feather borders.
> One dotted where pacity = 100% and on with just any secound dot where
> opacity = 0%.
> A center mark would be great too.
There is just one major problem with this suggestion. Outline drawing is
second most expensive operation in painting, first being the operation of
applying the stamp to the canvas. Drawing two outlines would double that.
Until there is on demand rendering with a gegl paint core, I do not see the
resources to do this.
--Gegl
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
On Mon, Aug 31, 2009 at 11:11:32AM +0400, Alexandre Prokoudine wrote:
> This is more or less what gogh has: two circles to represent
> fuzzyness. It was really really useful.
I think in gogh the two circles represent the brush radius at minimum and
maximum pressure, not the fuzziness.
bye,
Martin
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
|
|
 Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
what about printing a semi transparent copy of the actual brush on the
canvas? Is it possible?
The "ghosted" brush can have two opacities, one for the preview when the
tool isn't in use, and one more transparent when the tool is in use.
I wouldn't mind to have a simple circle of the size of the brush as the
default mode and an alternative option for overlaying a semi-transparent
brush image.
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
On 09/01/2009 07:29 PM, peter sikking wrote:
> Guillermo Espertino wrote:
>
>> what about printing a semi transparent copy of the actual brush on the
>> canvas?
>
> exactly what I thought.
Even though I think the patch made the brush outline better for fuzzy brushes, it is still not without flaws. Let's ignore the patch and aim for the above instead
/ Martin
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
(peter) yahvuu wrote:
>>>> what about printing a semi transparent copy of the actual brush
>>>> on the
>>>> canvas?
>>> exactly what I thought.
>>
>> Even though I think the patch made the brush outline better for
>> fuzzy brushes, it is still not without flaws. Let's ignore the
>> patch and aim for the above instead
>
> i guess what works best is to display the brush outline while
> drawing and to use the brush stamp when idling.
>
>
> If you want to test-drive the look and feel, here's a flash applet
> featuring various outline designs:
> http://sites.google.com/site/yahvuu/stuff/brushtester-web.lzx.swf8.swf?attredirects=0I tried that, and although I would not call that exactly a solution,
it did help to observe some things:
- it is fantastic to see a fuzzy/grunge brush as a real
"copy of the actual brush" when one is not painting, but it has to
_contrast_ with what is under it or else it just disappears. When it
contrasts (some X-OR variation, or so) I think it should not be semi
transparent anymore, just exactly reflect the brush alpha value for
each of its 'pixels'.
- that really opens up what (dynamic) paint parameters should be
reflected by the brush when not painting: looks like brush geometry
(brush, scale, aspect ratio, angle) yes, hardness: maybe, rest
(opacity, spacing, jitter, color(gradient)) no.
- when painting, first I feel that this outline is a lousy
representative
for a brush. next I notice that getting the 'brush' out of the way
and
showing the immediate paint result rules. so now I am thinking:
what about no outline at all and just a cross-hair for mouse position
when the mouse is down?
--ps
founder + principal interaction architect
man + machine interface works
http://mmiworks.net/blog : on interaction architecture
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
|
|
Re: [PATCH] Improve brush outline for fuzzy brushes, sample screenshot included
second try sending this...
(peter) yahvuu wrote:
>>>> what about printing a semi transparent copy of the actual brush
>>>> on the
>>>> canvas?
>>> exactly what I thought.
>>
>> Even though I think the patch made the brush outline better for
>> fuzzy brushes, it is still not without flaws. Let's ignore the
>> patch and aim for the above instead
>
> i guess what works best is to display the brush outline while
> drawing and to use the brush stamp when idling.
>
>
> If you want to test-drive the look and feel, here's a flash applet
> featuring various outline designs:
> http://sites.google.com/site/yahvuu/stuff/brushtester-web.lzx.swf8.swf?attredirects=0I tried that, and although I would not call that exactly a solution,
it did help to observe some things:
- it is fantastic to see a fuzzy/grunge brush as a real
"copy of the actual brush" when one is not painting, but it has to
_contrast_ with what is under it or else it just disappears. When it
contrasts (some X-OR variation, or so) I think it should not be semi
transparent anymore, just exactly reflect the brush alpha value for
each of its 'pixels'.
- that really opens up what (dynamic) paint parameters should be
reflected by the brush when not painting: looks like brush geometry
(brush, scale, aspect ratio, angle) yes, hardness: maybe, rest
(opacity, spacing, jitter, color(gradient)) no.
- when painting, first I feel that this outline is a lousy
representative
for a brush. next I notice that getting the 'brush' out of the way and
showing the immediate paint result rules. so now I am thinking:
what about no outline at all and just a cross-hair for mouse position
when the mouse is down?
--ps
founder + principal interaction architect
man + machine interface works
http://mmiworks.net/blog : on interaction architecture
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
|
signature.asc (205 bytes) 