[PATCH] Suspend quirk for ASUS M2V-MX SE

View: New views
3 Messages — Rating Filter:   Alert me  

[PATCH] Suspend quirk for ASUS M2V-MX SE

by Paul Menzel-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Dear HAL hackers,


please find the patch with further information attached.

One problem though. This board is very well supported by coreboot [1]. I
am pretty sure no quirks were needed running the demo board at LinuxTag
2009 (echo -n "mem" > /sys/power/state). Maybe the BIOS vender should be
checked too?


Bests,

Paul


[1] http://www.coreboot.org/ASUS_M2V-MX_SE

[0001-Suspend-quirk-for-ASUS-M2V-MX-SE.patch]

From b300e3fb49f8889d5bd56cf5d7a9890948663a4b Mon Sep 17 00:00:00 2001
From: Paul Menzel <paulepanter@...>
Date: Sun, 4 Oct 2009 16:39:50 +0200
Subject: [PATCH 1/1] Suspend quirk for ASUS M2V-MX SE.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Test results from [1][2].

• pm-suspend --quirk-s3-bios --quirk-s3-mode
• pm-suspend --quirk-s3-bios

• pm-suspend
• pm-suspend --auto-quirks
• pm-suspend --quirk-vbemode-restore
• pm-suspend --quirk-vbe-post
• pm-suspend --quirk-s3-mode

udi = '/org/freedesktop/Hal/devices/computer'

[…]

  info.product = 'Computer'  (string)
  info.subsystem = 'unknown'  (string)
  info.udi = '/org/freedesktop/Hal/devices/computer'  (string)
  org.freedesktop.Hal.Device.SystemPowerManagement.method_argnames = {'num_seconds_to_sleep', 'num_seconds_to_sleep', '', '', '', 'enable_power_save'} (string list)
  org.freedesktop.Hal.Device.SystemPowerManagement.method_execpaths = {'hal-system-power-suspend', 'hal-system-power-suspend-hybrid', 'hal-system-power-hibernate', 'hal-system-powe
r-shutdown', 'hal-system-power-reboot', 'hal-system-power-set-power-save'} (string list)
  org.freedesktop.Hal.Device.SystemPowerManagement.method_names = {'Suspend', 'SuspendHybrid', 'Hibernate', 'Shutdown', 'Reboot', 'SetPowerSave'} (string list)
  org.freedesktop.Hal.Device.SystemPowerManagement.method_signatures = {'i', 'i', '', '', '', 'b'} (string list)
  org.freedesktop.Hal.version = '0.5.13'  (string)
  org.freedesktop.Hal.version.major = 0  (0x0)  (int)
  org.freedesktop.Hal.version.micro = 13  (0xd)  (int)
  org.freedesktop.Hal.version.minor = 5  (0x5)  (int)
  power_management.acpi.linux.version = '20090320'  (string)
  power_management.can_hibernate = true  (bool)
  power_management.can_suspend = true  (bool)
  power_management.can_suspend_hybrid = true  (bool)
  power_management.is_powersave_set = false  (bool)
  power_management.quirk.dpms_on = true  (bool)
  power_management.quirk.dpms_suspend = true  (bool)
  power_management.quirk.vbe_post = true  (bool)
  power_management.quirk.vbemode_restore = true  (bool)
  power_management.quirk.vbestate_restore = true  (bool)
  power_management.quirk.vga_mode_3 = true  (bool)
  power_management.type = 'acpi'  (string)
  system.board.product = 'M2V-MX SE'  (string)
  system.board.serial = 'MS1C81B11A09131'  (string)
  system.board.vendor = 'ASUSTeK Computer INC.'  (string)
  system.board.version = 'Rev x.xx'  (string)
  system.chassis.manufacturer = 'Chassis Manufacture'  (string)
  system.chassis.type = 'Desktop'  (string)
  system.firmware.release_date = '10/30/2007'  (string)
  system.firmware.vendor = 'American Megatrends Inc.'  (string)
  system.firmware.version = '0304'  (string)
  system.formfactor = 'desktop'  (string)
  system.hardware.primary_video.product = 12848  (0x3230)  (int)
  system.hardware.primary_video.vendor = 4358  (0x1106)  (int)
  system.hardware.product = 'System Product Name'  (string)
  system.hardware.serial = 'System Serial Number'  (string)
  system.hardware.uuid = '8006D9F5-8DFE-D511-86C7-001E8CB94B2A'  (string)
  system.hardware.vendor = 'System manufacturer'  (string)
  system.hardware.version = 'System Version'  (string)
  system.kernel.machine = 'x86_64'  (string)
  system.kernel.name = 'Linux'  (string)
  system.kernel.version = '2.6.30-1-amd64'  (string)
  system.kernel.version.major = 2  (0x2)  (int)
  system.kernel.version.micro = 30  (0x1e)  (int)
  system.kernel.version.minor = 6  (0x6)  (int)

[1] http://people.freedesktop.org/~hughsient/quirk/quirk-suspend-index.html
[2] http://209.85.135.132/search?q=cache:z31jFwNjC-oJ:people.freedesktop.org/~hughsient/quirk/quirk-suspend-debug.html+I+want+to+check+common+problems+and+to+find+quirks+to+try&cd=2&hl=de&ct=clnk&gl=de&client=safari

Signed-off-by: Paul Menzel <pm.debian@...>
---
 .../10freedesktop/20-video-quirk-pm-asus.fdi       |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fdi/information/10freedesktop/20-video-quirk-pm-asus.fdi b/fdi/information/10freedesktop/20-video-quirk-pm-asus.fdi
index fe29d1b..7b0cfd5 100644
--- a/fdi/information/10freedesktop/20-video-quirk-pm-asus.fdi
+++ b/fdi/information/10freedesktop/20-video-quirk-pm-asus.fdi
@@ -79,7 +79,7 @@
     </match>
 
     <!-- Board with broken system.hardware.* fields. Use system.board.* instead -->
-    <match key="system.board.product" prefix="P5LD2">
+    <match key="system.board.product" prefix_outof="M2V-MX SE;P5LD2">
       <merge key="power_management.quirk.s3_bios" type="bool">true</merge>
     </match>
 
--
1.6.4.3




_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal

signature.asc (205 bytes) Download Attachment

Re: [PATCH] Suspend quirk for ASUS M2V-MX SE

by Paul Menzel-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Dear HAL hackers,


Am Sonntag, den 04.10.2009, 17:01 +0200 schrieb Paul Menzel:
> please find the patch with further information attached.

I updated the commit message.

> One problem though. This board is very well supported by coreboot [1]. I
> am pretty sure no quirks were needed running the demo board at LinuxTag
> 2009 (echo -n "mem" > /sys/power/state). Maybe the BIOS vender should be
> checked too?

I did not add that I know that HAL is deprecated, could you include this
information to udev(?) please.


Bests,

Paul


> [1] http://www.coreboot.org/ASUS_M2V-MX_SE


[0001-Suspend-quirk-for-ASUS-M2V-MX-SE.patch]

From 9fb3cdbecf13d4d376d18d8615c2aebd8814d8eb Mon Sep 17 00:00:00 2001
From: Paul Menzel <paulepanter@...>
Date: Sun, 4 Oct 2009 16:39:50 +0200
Subject: [PATCH 1/1] Suspend quirk for ASUS M2V-MX SE.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Test results from [1][2].

Works.
• pm-suspend --quirk-s3-bios --quirk-s3-mode
• pm-suspend --quirk-s3-bios

Does not work.
• pm-suspend
• pm-suspend --auto-quirks
• pm-suspend --quirk-vbemode-restore
• pm-suspend --quirk-vbe-post
• pm-suspend --quirk-s3-mode

udi = '/org/freedesktop/Hal/devices/computer'

[…]

  info.product = 'Computer'  (string)
  info.subsystem = 'unknown'  (string)
  info.udi = '/org/freedesktop/Hal/devices/computer'  (string)
  org.freedesktop.Hal.Device.SystemPowerManagement.method_argnames = {'num_seconds_to_sleep', 'num_seconds_to_sleep', '', '', '', 'enable_power_save'} (string list)
  org.freedesktop.Hal.Device.SystemPowerManagement.method_execpaths = {'hal-system-power-suspend', 'hal-system-power-suspend-hybrid', 'hal-system-power-hibernate', 'hal-system-powe
r-shutdown', 'hal-system-power-reboot', 'hal-system-power-set-power-save'} (string list)
  org.freedesktop.Hal.Device.SystemPowerManagement.method_names = {'Suspend', 'SuspendHybrid', 'Hibernate', 'Shutdown', 'Reboot', 'SetPowerSave'} (string list)
  org.freedesktop.Hal.Device.SystemPowerManagement.method_signatures = {'i', 'i', '', '', '', 'b'} (string list)
  org.freedesktop.Hal.version = '0.5.13'  (string)
  org.freedesktop.Hal.version.major = 0  (0x0)  (int)
  org.freedesktop.Hal.version.micro = 13  (0xd)  (int)
  org.freedesktop.Hal.version.minor = 5  (0x5)  (int)
  power_management.acpi.linux.version = '20090320'  (string)
  power_management.can_hibernate = true  (bool)
  power_management.can_suspend = true  (bool)
  power_management.can_suspend_hybrid = true  (bool)
  power_management.is_powersave_set = false  (bool)
  power_management.quirk.dpms_on = true  (bool)
  power_management.quirk.dpms_suspend = true  (bool)
  power_management.quirk.vbe_post = true  (bool)
  power_management.quirk.vbemode_restore = true  (bool)
  power_management.quirk.vbestate_restore = true  (bool)
  power_management.quirk.vga_mode_3 = true  (bool)
  power_management.type = 'acpi'  (string)
  system.board.product = 'M2V-MX SE'  (string)
  system.board.serial = 'MS1C81B11A09131'  (string)
  system.board.vendor = 'ASUSTeK Computer INC.'  (string)
  system.board.version = 'Rev x.xx'  (string)
  system.chassis.manufacturer = 'Chassis Manufacture'  (string)
  system.chassis.type = 'Desktop'  (string)
  system.firmware.release_date = '10/30/2007'  (string)
  system.firmware.vendor = 'American Megatrends Inc.'  (string)
  system.firmware.version = '0304'  (string)
  system.formfactor = 'desktop'  (string)
  system.hardware.primary_video.product = 12848  (0x3230)  (int)
  system.hardware.primary_video.vendor = 4358  (0x1106)  (int)
  system.hardware.product = 'System Product Name'  (string)
  system.hardware.serial = 'System Serial Number'  (string)
  system.hardware.uuid = '8006D9F5-8DFE-D511-86C7-001E8CB94B2A'  (string)
  system.hardware.vendor = 'System manufacturer'  (string)
  system.hardware.version = 'System Version'  (string)
  system.kernel.machine = 'x86_64'  (string)
  system.kernel.name = 'Linux'  (string)
  system.kernel.version = '2.6.30-1-amd64'  (string)
  system.kernel.version.major = 2  (0x2)  (int)
  system.kernel.version.micro = 30  (0x1e)  (int)
  system.kernel.version.minor = 6  (0x6)  (int)

[1] http://people.freedesktop.org/~hughsient/quirk/quirk-suspend-index.html
[2] http://209.85.135.132/search?q=cache:z31jFwNjC-oJ:people.freedesktop.org/~hughsient/quirk/quirk-suspend-debug.html+I+want+to+check+common+problems+and+to+find+quirks+to+try&cd=2&hl=de&ct=clnk&gl=de&client=safari

Signed-off-by: Paul Menzel <pm.debian@...>
---
 .../10freedesktop/20-video-quirk-pm-asus.fdi       |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fdi/information/10freedesktop/20-video-quirk-pm-asus.fdi b/fdi/information/10freedesktop/20-video-quirk-pm-asus.fdi
index fe29d1b..7b0cfd5 100644
--- a/fdi/information/10freedesktop/20-video-quirk-pm-asus.fdi
+++ b/fdi/information/10freedesktop/20-video-quirk-pm-asus.fdi
@@ -79,7 +79,7 @@
     </match>
 
     <!-- Board with broken system.hardware.* fields. Use system.board.* instead -->
-    <match key="system.board.product" prefix="P5LD2">
+    <match key="system.board.product" prefix_outof="M2V-MX SE;P5LD2">
       <merge key="power_management.quirk.s3_bios" type="bool">true</merge>
     </match>
 
--
1.6.5




_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal

signature.asc (205 bytes) Download Attachment

Re: [PATCH] Suspend quirk for ASUS M2V-MX SE

by Paul Menzel-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Dear HAL hackers,


Am Samstag, den 17.10.2009, 20:32 +0200 schrieb Paul Menzel:
> Am Sonntag, den 04.10.2009, 17:01 +0200 schrieb Paul Menzel:
> > please find the patch with further information attached.
>
> I updated the commit message.
>
> > One problem though. This board is very well supported by coreboot [1]. I
> > am pretty sure no quirks were needed running the demo board at LinuxTag
> > 2009 (echo -n "mem" > /sys/power/state). Maybe the BIOS vender should be
> > checked too?

I updated the patch to check for the BIOS vendor.

> I did not add that I know that HAL is deprecated, could you include this
> information to udev(?) please.


Bests,

Paul


> > [1] http://www.coreboot.org/ASUS_M2V-MX_SE


[0001-Suspend-quirk-for-ASUS-M2V-MX-SE.patch]

From e743df7fec27ee3b60d55df8ab4b446072b7429c Mon Sep 17 00:00:00 2001
From: Paul Menzel <pm.debian@...>
Date: Sat, 7 Nov 2009 10:13:38 +0100
Subject: [PATCH 1/1] Suspend quirk for ASUS M2V-MX SE.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Test results from [1][2].

Works.
• pm-suspend --quirk-s3-bios --quirk-s3-mode
• pm-suspend --quirk-s3-bios

Does not work.
• pm-suspend
• pm-suspend --auto-quirks
• pm-suspend --quirk-vbemode-restore
• pm-suspend --quirk-vbe-post
• pm-suspend --quirk-s3-mode

udi = '/org/freedesktop/Hal/devices/computer'

[…]

  info.product = 'Computer'  (string)
  info.subsystem = 'unknown'  (string)
  info.udi = '/org/freedesktop/Hal/devices/computer'  (string)
  org.freedesktop.Hal.Device.SystemPowerManagement.method_argnames = {'num_seconds_to_sleep', 'num_seconds_to_sleep', '', '', '', 'enable_power_save'} (string list)
  org.freedesktop.Hal.Device.SystemPowerManagement.method_execpaths = {'hal-system-power-suspend', 'hal-system-power-suspend-hybrid', 'hal-system-power-hibernate', 'hal-system-powe
r-shutdown', 'hal-system-power-reboot', 'hal-system-power-set-power-save'} (string list)
  org.freedesktop.Hal.Device.SystemPowerManagement.method_names = {'Suspend', 'SuspendHybrid', 'Hibernate', 'Shutdown', 'Reboot', 'SetPowerSave'} (string list)
  org.freedesktop.Hal.Device.SystemPowerManagement.method_signatures = {'i', 'i', '', '', '', 'b'} (string list)
  org.freedesktop.Hal.version = '0.5.13'  (string)
  org.freedesktop.Hal.version.major = 0  (0x0)  (int)
  org.freedesktop.Hal.version.micro = 13  (0xd)  (int)
  org.freedesktop.Hal.version.minor = 5  (0x5)  (int)
  power_management.acpi.linux.version = '20090320'  (string)
  power_management.can_hibernate = true  (bool)
  power_management.can_suspend = true  (bool)
  power_management.can_suspend_hybrid = true  (bool)
  power_management.is_powersave_set = false  (bool)
  power_management.quirk.dpms_on = true  (bool)
  power_management.quirk.dpms_suspend = true  (bool)
  power_management.quirk.vbe_post = true  (bool)
  power_management.quirk.vbemode_restore = true  (bool)
  power_management.quirk.vbestate_restore = true  (bool)
  power_management.quirk.vga_mode_3 = true  (bool)
  power_management.type = 'acpi'  (string)
  system.board.product = 'M2V-MX SE'  (string)
  system.board.serial = 'MS1C81B11A09131'  (string)
  system.board.vendor = 'ASUSTeK Computer INC.'  (string)
  system.board.version = 'Rev x.xx'  (string)
  system.chassis.manufacturer = 'Chassis Manufacture'  (string)
  system.chassis.type = 'Desktop'  (string)
  system.firmware.release_date = '10/30/2007'  (string)
  system.firmware.vendor = 'American Megatrends Inc.'  (string)
  system.firmware.version = '0304'  (string)
  system.formfactor = 'desktop'  (string)
  system.hardware.primary_video.product = 12848  (0x3230)  (int)
  system.hardware.primary_video.vendor = 4358  (0x1106)  (int)
  system.hardware.product = 'System Product Name'  (string)
  system.hardware.serial = 'System Serial Number'  (string)
  system.hardware.uuid = '8006D9F5-8DFE-D511-86C7-001E8CB94B2A'  (string)
  system.hardware.vendor = 'System manufacturer'  (string)
  system.hardware.version = 'System Version'  (string)
  system.kernel.machine = 'x86_64'  (string)
  system.kernel.name = 'Linux'  (string)
  system.kernel.version = '2.6.30-1-amd64'  (string)
  system.kernel.version.major = 2  (0x2)  (int)
  system.kernel.version.micro = 30  (0x1e)  (int)
  system.kernel.version.minor = 6  (0x6)  (int)

[1] http://people.freedesktop.org/~hughsient/quirk/quirk-suspend-index.html
[2] http://209.85.135.132/search?q=cache:z31jFwNjC-oJ:people.freedesktop.org/~hughsient/quirk/quirk-suspend-debug.html+I+want+to+check+common+problems+and+to+find+quirks+to+try&cd=2&hl=de&ct=clnk&gl=de&client=safari

Signed-off-by: Paul Menzel <pm.debian@...>
---
 .../10freedesktop/20-video-quirk-pm-asus.fdi       |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/fdi/information/10freedesktop/20-video-quirk-pm-asus.fdi b/fdi/information/10freedesktop/20-video-quirk-pm-asus.fdi
index fe29d1b..9e41d68 100644
--- a/fdi/information/10freedesktop/20-video-quirk-pm-asus.fdi
+++ b/fdi/information/10freedesktop/20-video-quirk-pm-asus.fdi
@@ -83,6 +83,12 @@
       <merge key="power_management.quirk.s3_bios" type="bool">true</merge>
     </match>
 
+    <match key="system.board.product" prefix="M2V-MX SE">
+      <match key="system.firmware.vendor" prefix="American Megatrends Inc.">
+        <merge key="power_management.quirk.s3_bios" type="bool">true</merge>
+      </match>
+    </match>
+
     <!-- ASUS a7v600 motherboard, has no usable sys_* entries besides bios_version -->
     <match key="system.firmware.version" prefix="ASUS A7V600">
       <merge key="power_management.quirk.s3_bios" type="bool">true</merge>
--
1.6.5.2




_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal

signature.asc (205 bytes) Download Attachment