[PATCH] Use proper library directory (e.g. for multilib)

View: New views
4 Messages — Rating Filter:   Alert me  

[PATCH] Use proper library directory (e.g. for multilib)

by Daniel Mierswa :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


In case someone has a multilib directory the library directory could be
/usr/lib32 or /usr/lib64.

Signed-off-by: Daniel Mierswa <impulze@...>
---
 src/ck-session.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)



[0001-Use-proper-library-directory-e.g.-for-multilib.patch]

diff --git a/src/ck-session.c b/src/ck-session.c
index d8db9dd..c2fc320 100644
--- a/src/ck-session.c
+++ b/src/ck-session.c
@@ -1287,7 +1287,7 @@ ck_session_run_programs (CkSession  *session,
         g_assert(n <= G_N_ELEMENTS(extra_env));
 
         ck_run_programs (SYSCONFDIR "/ConsoleKit/run-session.d", action, extra_env);
-        ck_run_programs (PREFIX "/lib/ConsoleKit/run-session.d", action, extra_env);
+        ck_run_programs (LIBDIR "/ConsoleKit/run-session.d", action, extra_env);
 
         for (n = 0; extra_env[n] != NULL; n++) {
                 g_free (extra_env[n]);



_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal

Re: [PATCH] Use proper library directory (e.g. for multilib)

by Patryk Zawadzki :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, Aug 19, 2009 at 8:48 AM, Daniel Mierswa<impulze@...> wrote:
>
> In case someone has a multilib directory the library directory could be
> /usr/lib32 or /usr/lib64.
>
> Signed-off-by: Daniel Mierswa <impulze@...>
> ---
>  src/ck-session.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

What good does that patch do? Applications already have their files in
$PREFIX/lib/ConsoleKit - do you expect those to be moved automagically
or do you expect one to run both 32-bit and 64-bit ConsoleKits in
parallel?

--
Patryk Zawadzki
_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal

Re: [PATCH] Use proper library directory (e.g. for multilib)

by Kay Sievers :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, Aug 19, 2009 at 08:48, Daniel Mierswa<impulze@...> wrote:
>
> In case someone has a multilib directory the library directory could be
> /usr/lib32 or /usr/lib64.

That's totally wrong. The directory is a well-defined "private
application directory" and has nothing to do with any kind of library
or multi-lib stuff.

Kay
_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal

Re: [PATCH] Use proper library directory (e.g. for multilib)

by Daniel Mierswa :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 19.08.2009 09:50, Kay Sievers wrote:
> That's totally wrong. The directory is a well-defined "private
> application directory" and has nothing to do with any kind of library
> or multi-lib stuff.
It seems I have this confused with /lib64 and /lib32 from FHS:
  > /lib64 and /lib32 : 64/32-bit libraries (architecture dependent)
  > The 64-bit architectures PPC64, s390x, sparc64 and AMD64 must place
64-bit libraries in /lib64, and 32-bit (or 31-bit on s390) libraries in
/lib.
  > The 64-bit architecture IA64 must place 64-bit libraries in /lib.
In which case I'm sorry, I think this patch can be removed then.

--
Mierswa, Daniel

If you still don't like it, that's ok: that's why I'm boss. I simply
know better than you do.
               --- Linus Torvalds, comp.os.linux.advocacy, 1996/07/22
_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal