|

»

»

[PATCH] XML callgraph fixes

View: New views

3 Messages — Rating Filter: Alert me

	[PATCH] XML callgraph fixes by Maynard Johnson :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Unfortunately, with the assistance of my colleage, Qi Liang (VPA deveoper), I found another regression in 0.9.5. My June 18 change to make sure that all callgraph symbols are reported, even when there are zero samples, resulted in breaking the reporting of count values. While looking at this, I used a tool that validates XML documents with their corresponding schema. I found a few issues that needed to be fixed with the schema, too (mostly unrelated to the regression bug). I decided to put those changes into this patch, too, and bump the schema version. Richard, can you please review and test out this patch. Thanks. -Maynard ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ oprofile-list mailing list oprofile-list@... https://lists.sourceforge.net/lists/listinfo/oprofile-list op-callgraph.patch (10K) Download Attachment
	Re: [PATCH] XML callgraph fixes by Richard Purdie :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message On Thu, 2009-10-22 at 18:17 -0500, Maynard Johnson wrote: > Unfortunately, with the assistance of my colleage, Qi Liang (VPA > deveoper), I found another regression in 0.9.5. My June 18 change to > make sure that all callgraph symbols are reported, even when there are > zero samples, resulted in breaking the reporting of count values. > While looking at this, I used a tool that validates XML documents with > their corresponding schema. I found a few issues that needed to be > fixed with the schema, too (mostly unrelated to the regression bug). > I decided to put those changes into this patch, too, and bump the > schema version. > > Richard, can you please review and test out this patch. Reading through the patch it looks fine to me in principle. I'm travelling at the moment and won't be able to test until next week though. Cheers, Richard ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ oprofile-list mailing list oprofile-list@... https://lists.sourceforge.net/lists/listinfo/oprofile-list
	Re: [PATCH] XML callgraph fixes by Maynard Johnson :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Richard Purdie wrote: > On Thu, 2009-10-22 at 18:17 -0500, Maynard Johnson wrote: >> Unfortunately, with the assistance of my colleage, Qi Liang (VPA >> deveoper), I found another regression in 0.9.5. My June 18 change to >> make sure that all callgraph symbols are reported, even when there are >> zero samples, resulted in breaking the reporting of count values. >> While looking at this, I used a tool that validates XML documents with >> their corresponding schema. I found a few issues that needed to be >> fixed with the schema, too (mostly unrelated to the regression bug). >> I decided to put those changes into this patch, too, and bump the >> schema version. >> >> Richard, can you please review and test out this patch. > > Reading through the patch it looks fine to me in principle. I'm > travelling at the moment and won't be able to test until next week > though. Thanks, Richard. Patch is committed. Please test it out as soon as you can and let me know your results. The patch works well with the VPA tool mentioned above, but want to make sure your OProfileUI works OK, too. -Maynard > > Cheers, > > Richard > > ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ oprofile-list mailing list oprofile-list@... https://lists.sourceforge.net/lists/listinfo/oprofile-list