[PATCH] conflicting types for getline

[Zoltan Devai]

Hi,

While trying to build a toolchain with ct-ng 1.5.0,
arm-unknown-linux-uclibcgnueabi target,
I get the following error:

[INFO ]  Installing C library headers
[EXTRA]    Copying sources to build dir
[EXTRA]    Applying configuration
[EXTRA]    Building headers
[EXTRA]    Installing headers
[ERROR]    extra/scripts/unifdef.c:209: error: conflicting types for 'getline'
[ERROR]    make[2]: *** [extra/scripts/unifdef] Error 1
[ERROR]    Build failed in step 'Installing C library headers'

The following patch solves the problem.
(It's a backport of this uClibc commit:
http://git.uclibc.org/uClibc/commit/?id=49e81cada73616864b9b31df0aeb6961c30f5a6e
)

Cheers,
Zoltan


--- /dev/null
+++ patches/uClibc/0.9.30.1/180-getline-conflict.patch
@@ -0,0 +1,30 @@
+--- a/extra/scripts/unifdef.c
++++ b/extra/scripts/unifdef.c
+@@ -206,7 +206,7 @@
+ static void             error(const char *);
+ static int              findsym(const char *);
+ static void             flushline(bool);
+-static Linetype         getline(void);
++static Linetype         get_line(void);
+ static Linetype         ifeval(const char **);
+ static void             ignoreoff(void);
+ static void             ignoreon(void);
+@@ -512,7 +512,7 @@
+
+ for (;;) {
+ linenum++;
+- lineval = getline();
++ lineval = get_line();
+ trans_table[ifstate[depth]][lineval]();
+ debug("process %s -> %s depth %d",
+    linetype_name[lineval],
+@@ -526,7 +526,7 @@
+  * help from skipcomment().
+  */
+ static Linetype
+-getline(void)
++get_line(void)
+ {
+ const char *cp;
+ int cursym;
+

--
For unsubscribe information see http://sourceware.org/lists.html#faq

[Yann E. MORIN]

Hello Zoltan!
Hello All!

On Wednesday 28 October 2009 12:03:38 Zoltan Devai wrote:

> While trying to build a toolchain with ct-ng 1.5.0,
> arm-unknown-linux-uclibcgnueabi target,
> I get the following error:
> [INFO ]  Installing C library headers
> [EXTRA]    Copying sources to build dir
> [EXTRA]    Applying configuration
> [EXTRA]    Building headers
> [EXTRA]    Installing headers
> [ERROR]    extra/scripts/unifdef.c:209: error: conflicting types for 'getline'
> [ERROR]    make[2]: *** [extra/scripts/unifdef] Error 1
> [ERROR]    Build failed in step 'Installing C library headers'

On what distribution are you trying to build? It works OK on my Debian Lenny.

> The following patch solves the problem.
> (It's a backport of this uClibc commit:
> http://git.uclibc.org/uClibc/commit/?id=49e81cada73616864b9b31df0aeb6961c30f5a6e
> )

OK, could you re-submit after reading the "Contributing" section in
docs/overview.txt, please?

Regards,
Yann E. MORIN.

--
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| [phone] | Software  Designer | \ / CAMPAIGN     |  ___               |
| [phone] `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
`------------------------------^-------^------------------^--------------------'



--
For unsubscribe information see http://sourceware.org/lists.html#faq

[Zoltan Devai]

Hi All,

2009/10/28 Yann E. MORIN <yann.morin.1998@...>:
> On Wednesday 28 October 2009 12:03:38 Zoltan Devai wrote:
>> While trying to build a toolchain with ct-ng 1.5.0,
>> arm-unknown-linux-uclibcgnueabi target,
>> [ERROR]    extra/scripts/unifdef.c:209: error: conflicting types for 'getline'
>> [ERROR]    make[2]: *** [extra/scripts/unifdef] Error 1
>> [ERROR]    Build failed in step 'Installing C library headers'
>
> On what distribution are you trying to build? It works OK on my Debian Lenny.

It's Ubuntu Karmic (9.10), with glibc 2.10.1, AFAIK this is a problem
since glibc 2.10.

>> The following patch solves the problem.
>> (It's a backport of this uClibc commit:
>> http://git.uclibc.org/uClibc/commit/?id=49e81cada73616864b9b31df0aeb6961c30f5a6e
>> )
> OK, could you re-submit after reading the "Contributing" section in
> docs/overview.txt, please?

I'd prefer not to deal with Mercurial just because of this, so I'd be
happy if you make the
actual patch.

Cheers,
Zoltan

--
For unsubscribe information see http://sourceware.org/lists.html#faq

[Yann E. MORIN]

Zoltan,
All,

On Wednesday 28 October 2009 12:03:38 Zoltan Devai wrote:

> While trying to build a toolchain with ct-ng 1.5.0,
> arm-unknown-linux-uclibcgnueabi target,
> I get the following error:
> [INFO ]  Installing C library headers
> [EXTRA]    Copying sources to build dir
> [EXTRA]    Applying configuration
> [EXTRA]    Building headers
> [EXTRA]    Installing headers
> [ERROR]    extra/scripts/unifdef.c:209: error: conflicting types for 'getline'
> [ERROR]    make[2]: *** [extra/scripts/unifdef] Error 1
> [ERROR]    Build failed in step 'Installing C library headers'
> The following patch solves the problem.

Applied,
Thanks.

Regards,
Yann E. MORIN.

--
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| [phone] | Software  Designer | \ / CAMPAIGN     |  ___               |
| [phone] `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
`------------------------------^-------^------------------^--------------------'



--
For unsubscribe information see http://sourceware.org/lists.html#faq