[PATCH] fix MIPS support

View: New views
5 Messages — Rating Filter:   Alert me  

[PATCH] fix MIPS support

by ZHANG Le :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Currently the endianness detection for MIPS in config.h is wrong.
Because __mips__ is defined by gcc for both endianness on MIPS arch.
__MIPSEB__ is the one which is defined for big endian MIPS.

I have attached the patch.

--
Zhang, Le
Gentoo/Loongson Developer
http://zhangle.is-a-geek.org
0260 C902 B8F8 6506 6586 2B90 BC51 C808 1E4E 2973

diff --git a/config.h b/config.h
index de6b0d7..99a8759 100644
--- a/config.h
+++ b/config.h
@@ -4,7 +4,7 @@
 // ***************** Important Settings ********************
 
 // define this if running on a big-endian CPU
-#if !defined(IS_LITTLE_ENDIAN) && (defined(__BIG_ENDIAN__) || defined(__sparc) || defined(__sparc__) || defined(__hppa__) || defined(__mips__) || (defined(__MWERKS__) && !defined(__INTEL__)))
+#if !defined(IS_LITTLE_ENDIAN) && (defined(__BIG_ENDIAN__) || defined(__sparc) || defined(__sparc__) || defined(__hppa__) || defined(__MIPSEB__) || (defined(__MWERKS__) && !defined(__INTEL__)))
 # define IS_BIG_ENDIAN
 #endif
 


attachment0 (205 bytes) Download Attachment

Re: [PATCH] fix MIPS support

by Wei Dai :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Thanks. I've also added a test for __ARMEB__ which I think means big
endianness on ARM. Does anyone know if there a place that give a definitive
list of such predefined macros?

--------------------------------------------------
From: "Zhang Le" <r0bertz@...>
Sent: Wednesday, September 02, 2009 4:06 AM
To: <cryptopp-users@...>
Subject: [PATCH] fix MIPS support

> Currently the endianness detection for MIPS in config.h is wrong.
> Because __mips__ is defined by gcc for both endianness on MIPS arch.
> __MIPSEB__ is the one which is defined for big endian MIPS.
>
> I have attached the patch.
>
> --
> Zhang, Le
> Gentoo/Loongson Developer
> http://zhangle.is-a-geek.org
> 0260 C902 B8F8 6506 6586 2B90 BC51 C808 1E4E 2973
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the "Crypto++ Users" Google Group.
To unsubscribe, send an email to cryptopp-users-unsubscribe@....
More information about Crypto++ and this group is available at http://www.cryptopp.com.
-~----------~----~----~----~------~----~------~--~---


Re: fix MIPS support

by Eugene Zolenko-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


> Thanks. I've also added a test for __ARMEB__ which I think means big
> endianness on ARM. Does anyone know if there a place that give a definitive
> list of such predefined macros?

There is this site: http://predef.sourceforge.net/

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the "Crypto++ Users" Google Group.
To unsubscribe, send an email to cryptopp-users-unsubscribe@....
More information about Crypto++ and this group is available at http://www.cryptopp.com.
-~----------~----~----~----~------~----~------~--~---


Re: fix MIPS support

by Wei Dai :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


I was aware of that site, but it doesn't list __MIPSEB__ and __ARMEB__ .

--------------------------------------------------
From: "Eugene Zolenko" <zolenkoe@...>
Sent: Friday, September 04, 2009 9:30 AM
To: "Crypto++ Users" <cryptopp-users@...>
Subject: Re: fix MIPS support

>
>> Thanks. I've also added a test for __ARMEB__ which I think means big
>> endianness on ARM. Does anyone know if there a place that give a
>> definitive
>> list of such predefined macros?
>
> There is this site: http://predef.sourceforge.net/
>
> >
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the "Crypto++ Users" Google Group.
To unsubscribe, send an email to cryptopp-users-unsubscribe@....
More information about Crypto++ and this group is available at http://www.cryptopp.com.
-~----------~----~----~----~------~----~------~--~---


Re: fix MIPS support

by ZHANG Le :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 10:31 Fri 04 Sep     , Wei Dai wrote:
>
> I was aware of that site, but it doesn't list __MIPSEB__ and __ARMEB__ .

Check arch/*/include/asm/byteorder.h in Linux kernel source.

--
Zhang, Le
Gentoo/Loongson Developer
http://zhangle.is-a-geek.org
0260 C902 B8F8 6506 6586 2B90 BC51 C808 1E4E 2973


attachment0 (205 bytes) Download Attachment