[PATCH] fix to use repository in root drive letter under win32

View: New views
2 Messages — Rating Filter:   Alert me  

[PATCH] fix to use repository in root drive letter under win32

by Hugo Bastos Weber :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Folks, I sent a patch to svn on windows that will help my team a lot. Since october 20th I've got no answer about this patch.
May please someone that takes care of windows patches take a look if the patch is good to be commited.

Thanks to you all
--Hugo

Hugo Bastos Weber wrote:

>
> [[[
>
> * subversion/libsvn_ra_local/split_url.c
>    (svn_ra_local__split_URL): Allow file:///X:/ in addition to
> file:///X:/path. This fix allows one to use repository in the root
> drive lettler.
>
> ]]]
>
> I've got no answer for this patch, so I'm sending it again...
>
> Brane, thanks for the tip to avoid use of strlen(). I changed the
> patch as you suggest.
I think the patch is fine, but I can't test on Windows these days -- I
don't have a development environment. Hopefully someone more
Windows-centric will pick this up and apply it.

-- Brane
Hugo Bastos Weber wrote:

>
> [[[
>
> * subversion/libsvn_ra_local/split_url.c
>    (svn_ra_local__split_URL): Allow file:///X:/ in addition to
> file:///X:/path. This fix allows one to use repository in the root
> drive lettler.
>
> ]]]
>
> I've got no answer for this patch, so I'm sending it again...
>
> Brane, thanks for the tip to avoid use of strlen(). I changed the
> patch as you suggest.
I think the patch is fine, but I can't test on Windows these days -- I
don't have a development environment. Hopefully someone more
Windows-centric will pick this up and apply it.

-- Brane


Re: [PATCH] fix to use repository in root drive letter under win32

by Gavin Baumanis-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Hugo,

Since it has been a little while,
Could we please bother you to check (again) if it still compiles against the current trunk and passes all tests, too.

This email will bring it back onto the radar for those with commit privileges.
At worst, (once you re-verify your patch - and if it gets no immediate attention from a developer) I will place it in the tracker so that it is not lost.

Gavin.


On 07/11/2009, at 08:06 , Hugo Bastos Weber wrote:

Folks, I sent a patch to svn on windows that will help my team a lot. Since october 20th I've got no answer about this patch.
May please someone that takes care of windows patches take a look if the patch is good to be commited.

Thanks to you all
--Hugo

Hugo Bastos Weber wrote:

[[[

* subversion/libsvn_ra_local/split_url.c
  (svn_ra_local__split_URL): Allow file:///X:/ in addition to
file:///X:/path. This fix allows one to use repository in the root
drive lettler.

]]]

I've got no answer for this patch, so I'm sending it again...

Brane, thanks for the tip to avoid use of strlen(). I changed the
patch as you suggest.

I think the patch is fine, but I can't test on Windows these days -- I
don't have a development environment. Hopefully someone more
Windows-centric will pick this up and apply it.

-- Brane
From: Branko Čibej <brane@...>
Date: 20 October 2009 14:20:43
To: Hugo Bastos Weber <hugoweber@...>
Subject: Re: [PATCH] fix to use repository in root drive letter under win32


Hugo Bastos Weber wrote:

[[[

* subversion/libsvn_ra_local/split_url.c
  (svn_ra_local__split_URL): Allow file:///X:/ in addition to
file:///X:/path. This fix allows one to use repository in the root
drive lettler.

]]]

I've got no answer for this patch, so I'm sending it again...

Brane, thanks for the tip to avoid use of strlen(). I changed the
patch as you suggest.

I think the patch is fine, but I can't test on Windows these days -- I
don't have a development environment. Hopefully someone more
Windows-centric will pick this up and apply it.

-- Brane