[PATCH] fs/ext4: test the i_flags field of the right structure

[Julia Lawall]

From: Julia Lawall <julia@...>

Elsewhere, EXT4_EXTENTS_FL is combined with EXT4_I(inode)->i_flags, rather
than inode->i_flags.

Signed-off-by: Julia Lawall <julia@...>

---
 fs/ext4/inode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 5c5bc5d..c0e34ab 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2787,7 +2787,7 @@ static int ext4_da_writepages_trans_blocks(struct inode *inode)
  * number of contiguous block. So we will limit
  * number of contiguous block to a sane value
  */
- if (!(inode->i_flags & EXT4_EXTENTS_FL) &&
+ if (!(EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) &&
     (max_blocks > EXT4_MAX_TRANS_DATA))
  max_blocks = EXT4_MAX_TRANS_DATA;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Eric Sandeen-5]

Julia Lawall wrote:
> From: Julia Lawall <julia@...>
>
> Elsewhere, EXT4_EXTENTS_FL is combined with EXT4_I(inode)->i_flags, rather
> than inode->i_flags.
>
> Signed-off-by: Julia Lawall <julia@...>
Reviewed-by: Eric Sandeen <sandeen@...>

>
> ---
>  fs/ext4/inode.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 5c5bc5d..c0e34ab 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -2787,7 +2787,7 @@ static int ext4_da_writepages_trans_blocks(struct inode *inode)
>   * number of contiguous block. So we will limit
>   * number of contiguous block to a sane value
>   */
> - if (!(inode->i_flags & EXT4_EXTENTS_FL) &&
> + if (!(EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) &&
>      (max_blocks > EXT4_MAX_TRANS_DATA))
>   max_blocks = EXT4_MAX_TRANS_DATA;
>  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Theodore Ts'o-2]

On Mon, Nov 02, 2009 at 09:58:47PM +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@...>
>
> Elsewhere, EXT4_EXTENTS_FL is combined with EXT4_I(inode)->i_flags, rather
> than inode->i_flags.
>
> Signed-off-by: Julia Lawall <julia@...>

Applied to the ext4 patch queue, thanks.

                                                        - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html