[PATCH] reboot: remove device_suspend(PMSG_FREEZE) from kernel_kexec

[Eric W. Biederman]

If device_suspend(PMSG_FREEZE) is not ready to be called in
kernel_restart it is definitely ready to be called in the more the
more fickle kernel_kexec.

Signed-off-by: Eric W. Biederman <ebiederm@...>
---

 kernel/sys.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

83cf6e3b0d37563138e4d0fd4d29e69e5c7e93df
diff --git a/kernel/sys.c b/kernel/sys.c
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -392,7 +392,6 @@ void kernel_kexec(void)
  }
  notifier_call_chain(&reboot_notifier_list, SYS_RESTART, NULL);
  system_state = SYSTEM_RESTART;
- device_suspend(PMSG_FREEZE);
  device_shutdown();
  printk(KERN_EMERG "Starting new kernel\n");
  machine_shutdown();
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Linus Torvalds]

On Fri, 29 Jul 2005, Eric W. Biederman wrote:
>
> If device_suspend(PMSG_FREEZE) is not ready to be called in
> kernel_restart it is definitely ready to be called in the more the
> more fickle kernel_kexec.

Ok, that was one of the more confused sentences I have ever seen, but I
fixed it up and applied it ;)

I assume it should be "definitely <not> ready", and the duplication the
duplication in "the more the more" is just because you're singing along
with some catchy tune and your fingers got away from you.

                Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Eric W. Biederman]

Linus Torvalds <torvalds@...> writes:

> On Fri, 29 Jul 2005, Eric W. Biederman wrote:
>>
>> If device_suspend(PMSG_FREEZE) is not ready to be called in
>> kernel_restart it is definitely ready to be called in the more the
>> more fickle kernel_kexec.
>
> Ok, that was one of the more confused sentences I have ever seen, but I
> fixed it up and applied it ;)
>
> I assume it should be "definitely <not> ready", and the duplication the
> duplication in "the more the more" is just because you're singing along
> with some catchy tune and your fingers got away from you.

Something like that.  I have more problems writing a good
description of my code than actually writing the code.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/