[PATCH 0/44] includecheck: fix multiple includes

View: New views
20 Messages — Rating Filter:   Alert me  
< Prev | 1 - 2 - 3 - 4 - 5 | Next >

[PATCH 41/44] includecheck fix: include/linux, rfkill.h

by Jaswinder Singh Rajput-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


fix the following 'make includecheck' warning:

  include/linux/rfkill.h: linux/types.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>
---
 include/linux/rfkill.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index e73e242..2ce2983 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -99,7 +99,6 @@ enum rfkill_user_states {
 #undef RFKILL_STATE_UNBLOCKED
 #undef RFKILL_STATE_HARD_BLOCKED
 
-#include <linux/types.h>
 #include <linux/kernel.h>
 #include <linux/list.h>
 #include <linux/mutex.h>
--
1.6.0.6



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 42/44] includecheck fix: kernel/trace, ring_buffer.c

by Jaswinder Singh Rajput-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


fix the following 'make includecheck' warning:

  kernel/trace/ring_buffer.c: trace.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>
---
 kernel/trace/ring_buffer.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index bf27bb7..636cee9 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -201,8 +201,6 @@ int tracing_is_on(void)
 }
 EXPORT_SYMBOL_GPL(tracing_is_on);
 
-#include "trace.h"
-
 #define RB_EVNT_HDR_SIZE (offsetof(struct ring_buffer_event, array))
 #define RB_ALIGNMENT 4U
 #define RB_MAX_SMALL_DATA (RB_ALIGNMENT * RINGBUF_TYPE_DATA_TYPE_LEN_MAX)
--
1.6.0.6



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 43/44] includecheck fix: mm, nommu.c

by Jaswinder Singh Rajput-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


fix the following 'make includecheck' warning:

  mm/nommu.c: internal.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>
---
 mm/nommu.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/mm/nommu.c b/mm/nommu.c
index 53cab10..e1ae0f9 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -56,8 +56,6 @@ void no_printk(const char *fmt, ...)
  no_printk(KERN_DEBUG FMT"\n", ##__VA_ARGS__)
 #endif
 
-#include "internal.h"
-
 void *high_memory;
 struct page *mem_map;
 unsigned long max_mapnr;
--
1.6.0.6



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 44/44] includecheck fix: mm, shmem.c

by Jaswinder Singh Rajput-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


fix the following 'make includecheck' warning:

 mm/shmem.c: linux/vfs.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>
---
 mm/shmem.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index d713239..34e56aa 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -49,7 +49,6 @@ static struct vfsmount *shm_mnt;
 #include <linux/backing-dev.h>
 #include <linux/shmem_fs.h>
 #include <linux/writeback.h>
-#include <linux/vfs.h>
 #include <linux/blkdev.h>
 #include <linux/security.h>
 #include <linux/swapops.h>
--
1.6.0.6



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 16/44] includecheck fix: s390, sys_s390.c

by Jaswinder Singh Rajput-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


fix the following 'make includecheck' warning:

  arch/s390/kernel/sys_s390.c: linux/syscalls.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>
---
 arch/s390/kernel/sys_s390.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/s390/kernel/sys_s390.c b/arch/s390/kernel/sys_s390.c
index c7ae4b1..e9d94f6 100644
--- a/arch/s390/kernel/sys_s390.c
+++ b/arch/s390/kernel/sys_s390.c
@@ -29,7 +29,6 @@
 #include <linux/personality.h>
 #include <linux/unistd.h>
 #include <linux/ipc.h>
-#include <linux/syscalls.h>
 #include <asm/uaccess.h>
 #include "entry.h"
 
--
1.6.0.6



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 21/44] includecheck fix: Documentation, cfag12864b-example.c

by Randy Dunlap-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, 08 Jul 2009 20:32:49 +0530 Jaswinder Singh Rajput wrote:

>
> fix the following 'make includecheck' warning:
>
>   Documentation/auxdisplay/cfag12864b-example.c: string.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>

Acked-by: Randy Dunlap <randy.dunlap@...>


> ---
>  Documentation/auxdisplay/cfag12864b-example.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/auxdisplay/cfag12864b-example.c b/Documentation/auxdisplay/cfag12864b-example.c
> index 2caeea5..156bcaa 100644
> --- a/Documentation/auxdisplay/cfag12864b-example.c
> +++ b/Documentation/auxdisplay/cfag12864b-example.c
> @@ -194,7 +194,6 @@ void cfag12864b_blit(void)
>   */
>  
>  #include <stdio.h>
> -#include <string.h>
>  
>  #define EXAMPLES 6
>  
> --


---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 33/44] includecheck fix: drivers/xen, evtchn.c

by Jeremy Fitzhardinge :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 07/08/09 08:42, Jaswinder Singh Rajput wrote:
> fix the following 'make includecheck' warning:
>
>   drivers/xen/evtchn.c: linux/errno.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>
>  
Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...>

Thanks,
    J

> ---
>  drivers/xen/evtchn.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c
> index af03195..79bedba 100644
> --- a/drivers/xen/evtchn.c
> +++ b/drivers/xen/evtchn.c
> @@ -38,7 +38,6 @@
>  #include <linux/string.h>
>  #include <linux/errno.h>
>  #include <linux/fs.h>
> -#include <linux/errno.h>
>  #include <linux/miscdevice.h>
>  #include <linux/major.h>
>  #include <linux/proc_fs.h>
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c

by Linus Walleij-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

2009/7/8 Jaswinder Singh Rajput <jaswinder@...>:

> fix the following 'make includecheck' warnings:
>
>  drivers/spi/amba-pl022.c: linux/delay.h is included more than once.
>  drivers/spi/amba-pl022.c: linux/errno.h is included more than once.

Acked-by: Linus Walleij <linus.walleij@...>

David are you merging this?

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c

by David Brownell :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wednesday 08 July 2009, Jaswinder Singh Rajput wrote:
>
> fix the following 'make includecheck' warnings:
>
>   drivers/spi/amba-pl022.c: linux/delay.h is included more than once.
>   drivers/spi/amba-pl022.c: linux/errno.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>

Acked-by: David Brownell <dbrownell@...>


> ---
>  drivers/spi/amba-pl022.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
> index da76797..c0f950a 100644
> --- a/drivers/spi/amba-pl022.c
> +++ b/drivers/spi/amba-pl022.c
> @@ -38,14 +38,12 @@
>  #include <linux/interrupt.h>
>  #include <linux/spi/spi.h>
>  #include <linux/workqueue.h>
> -#include <linux/errno.h>
>  #include <linux/delay.h>
>  #include <linux/clk.h>
>  #include <linux/err.h>
>  #include <linux/amba/bus.h>
>  #include <linux/amba/pl022.h>
>  #include <linux/io.h>
> -#include <linux/delay.h>
>  
>  /*
>   * This macro is used to define some register default values.
> --
> 1.6.0.6
>
>
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c

by Jaswinder Singh Rajput-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, 2009-07-08 at 19:28 +0200, Linus Walleij wrote:

> 2009/7/8 Jaswinder Singh Rajput <jaswinder@...>:
>
> > fix the following 'make includecheck' warnings:
> >
> >  drivers/spi/amba-pl022.c: linux/delay.h is included more than once.
> >  drivers/spi/amba-pl022.c: linux/errno.h is included more than once.
>
> Acked-by: Linus Walleij <linus.walleij@...>
>
> David are you merging this?
>

This is a big patchset, So better me or Sam will send this to Linus
after collecting some more ACKs.

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/44] includecheck: fix multiple includes

by Jaswinder Singh Rajput-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello all,

On Wed, 2009-07-08 at 19:58 +0530, Jaswinder Singh Rajput wrote:
> The following changes since commit faf80d62e44dc627efb741f48db50c1858d1667c:
>   Linus Torvalds (1):
>         Merge branch 'x86-fixes-for-linus' of git://git.kernel.org/.../tip/linux-2.6-tip
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/headers-check-2.6.git master
>
> Jaswinder Singh Rajput (44):

This is a big patchset, so it will be better that either me or Sam will
send it to Linus after collecting ACKs.

So far I received ACKs for:

       includecheck fix: Documentation, cfag12864b-example.c
        Acked-by: Randy Dunlap <randy.dunlap@...>

       includecheck fix: drivers/spi, amba-pl022.c
        Acked-by: Linus Walleij <linus.walleij@...>
        Acked-by: David Brownell <dbrownell@...>

       includecheck fix: drivers/xen, evtchn.c
        Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...>

       includecheck fix: include/acpi, acpi_bus.h
        Acked-by: Len Brown <len.brown@...>

I am still waiting ACK/NAK for :

      includecheck fix: arm, misc.c
      includecheck fix: arm, atomic.h
      includecheck fix: arm, board-dm355-evm.c
      includecheck fix: arm, board-dm355-leopard.c
      includecheck fix: arm, board-dm644x-evm.c
      includecheck fix: arm, board-dm646x-evm.c
      includecheck fix: arm, board-sffsdr.c
      includecheck fix: arm, mach-mx3/devices.c
      includecheck fix: arm, mach-omap1/mcbsp.c
      includecheck fix: arm, mach-omap2/mcbsp.c
      includecheck fix: arm, plat-s3c64xx/pm.c
      includecheck fix: arm, plat-stmp3xxx/pinmux.c

      includecheck fix: mn10300, sys_mn10300.c

      includecheck fix: powerpc, mpc7450-pmu.c
      includecheck fix: powerpc, ppc970-pmu.c

      includecheck fix: s390, sys_s390.c

      includecheck fix: um, helper.c

      includecheck fix: x86, dumpstack.c
      includecheck fix: x86, traps.c
      includecheck fix: x86, shadow.c

      includecheck fix: drivers/char, vt.c

      includecheck fix: drivers/net, sja1000.c
      includecheck fix: drivers/net, axnet_cs.c
      includecheck fix: drivers/net, smc911x.h

      includecheck fix: drivers/parisc, ccio-dma.c

      includecheck fix: drivers/scsi, libfcoe.c
      includecheck fix: drivers/scsi, ibmvscsi.c

      includecheck fix: drivers/staging, usbdrv.c
      includecheck fix: drivers/staging, rt_linux.h

      includecheck fix: drivers/video, vgacon.c

      includecheck fix: fs/xfs, xfs_iops.c

      includecheck fix: include/drm, drm_memory.h

      includecheck fix: include/linux, aio.h

      includecheck fix: include/linux, ftrace.h

      includecheck fix: include/linux, icmpv6.h
      includecheck fix: include/linux, net_dropmon.h

      includecheck fix: include/linux, rfkill.h

      includecheck fix: kernel/trace, ring_buffer.c

      includecheck fix: mm, nommu.c
      includecheck fix: mm, shmem.c

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

by Marcel Holtmann :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Jaswinder,

> fix the following 'make includecheck' warning:
>
>   include/linux/rfkill.h: linux/types.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>
> ---
>  include/linux/rfkill.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index e73e242..2ce2983 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -99,7 +99,6 @@ enum rfkill_user_states {
>  #undef RFKILL_STATE_UNBLOCKED
>  #undef RFKILL_STATE_HARD_BLOCKED
>  
> -#include <linux/types.h>
>  #include <linux/kernel.h>
>  #include <linux/list.h>
>  #include <linux/mutex.h>

with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems
correct.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/44] includecheck: fix multiple includes

by Russell King :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, Jul 08, 2009 at 11:30:59PM +0530, Jaswinder Singh Rajput wrote:

> I am still waiting ACK/NAK for :
>
>       includecheck fix: arm, misc.c
>       includecheck fix: arm, atomic.h
>       includecheck fix: arm, board-dm355-evm.c
>       includecheck fix: arm, board-dm355-leopard.c
>       includecheck fix: arm, board-dm644x-evm.c
>       includecheck fix: arm, board-dm646x-evm.c
>       includecheck fix: arm, board-sffsdr.c
>       includecheck fix: arm, mach-mx3/devices.c
>       includecheck fix: arm, mach-omap1/mcbsp.c
>       includecheck fix: arm, mach-omap2/mcbsp.c
>       includecheck fix: arm, plat-s3c64xx/pm.c
>       includecheck fix: arm, plat-stmp3xxx/pinmux.c

You're still waiting because apparantly you never sent this set anywhere
near any ARM people before.

For the first two, I'll ack them:

Acked-by: Russell King <rmk+kernel@...>

The remainder look sane to me, but you'll have to seek acks from the
individual platform maintainer(s).

--
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 36/44] includecheck fix: include/drm, drm_memory.h

by Dave Airlie-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


> fix the following 'make includecheck' warning:
>
>   include/drm/drm_memory.h: linux/vmalloc.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>

Acked-by: Dave Airlie <airlied@...>

Dave.

> ---
>  include/drm/drm_memory.h |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/include/drm/drm_memory.h b/include/drm/drm_memory.h
> index 63e425b..15af9b3 100644
> --- a/include/drm/drm_memory.h
> +++ b/include/drm/drm_memory.h
> @@ -44,8 +44,6 @@
>  
>  #if __OS_HAS_AGP
>  
> -#include <linux/vmalloc.h>
> -
>  #ifdef HAVE_PAGE_AGP
>  #include <asm/agp.h>
>  #else
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

by Jaswinder Singh Rajput-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello Marcel,

On Wed, 2009-07-08 at 12:32 -0700, Marcel Holtmann wrote:

> Hi Jaswinder,
>
> > fix the following 'make includecheck' warning:
> >
> >   include/linux/rfkill.h: linux/types.h is included more than once.
> >
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>
> > ---
> >  include/linux/rfkill.h |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> > index e73e242..2ce2983 100644
> > --- a/include/linux/rfkill.h
> > +++ b/include/linux/rfkill.h
> > @@ -99,7 +99,6 @@ enum rfkill_user_states {
> >  #undef RFKILL_STATE_UNBLOCKED
> >  #undef RFKILL_STATE_HARD_BLOCKED
> >  
> > -#include <linux/types.h>
> >  #include <linux/kernel.h>
> >  #include <linux/list.h>
> >  #include <linux/mutex.h>
>
> with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems
> correct.
>

ACK or Reviewed-by ?

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/44] includecheck: fix multiple includes

by Jaswinder Singh Rajput-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, 2009-07-08 at 22:13 +0100, Russell King wrote:

> On Wed, Jul 08, 2009 at 11:30:59PM +0530, Jaswinder Singh Rajput wrote:
> > I am still waiting ACK/NAK for :
> >
> >       includecheck fix: arm, misc.c
> >       includecheck fix: arm, atomic.h
> >       includecheck fix: arm, board-dm355-evm.c
> >       includecheck fix: arm, board-dm355-leopard.c
> >       includecheck fix: arm, board-dm644x-evm.c
> >       includecheck fix: arm, board-dm646x-evm.c
> >       includecheck fix: arm, board-sffsdr.c
> >       includecheck fix: arm, mach-mx3/devices.c
> >       includecheck fix: arm, mach-omap1/mcbsp.c
> >       includecheck fix: arm, mach-omap2/mcbsp.c
> >       includecheck fix: arm, plat-s3c64xx/pm.c
> >       includecheck fix: arm, plat-stmp3xxx/pinmux.c
>
> You're still waiting because apparantly you never sent this set anywhere
> near any ARM people before.
>
> For the first two, I'll ack them:
>
> Acked-by: Russell King <rmk+kernel@...>
>
> The remainder look sane to me, but you'll have to seek acks from the
> individual platform maintainer(s).
>

OK, adding some more ARM people and ARM lists to get remaining ACK/NAK.

Patches are already posted to LKML and also available at :

http://git.kernel.org/?p=linux/kernel/git/jaswinder/headers-check-2.6.git;a=summary

In case if you are not able to find these patches let me know.

Thanks,
--
JSR


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

by Marcel Holtmann :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Jaswinder,

> > > fix the following 'make includecheck' warning:
> > >
> > >   include/linux/rfkill.h: linux/types.h is included more than once.
> > >
> > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>
> > > ---
> > >  include/linux/rfkill.h |    1 -
> > >  1 files changed, 0 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> > > index e73e242..2ce2983 100644
> > > --- a/include/linux/rfkill.h
> > > +++ b/include/linux/rfkill.h
> > > @@ -99,7 +99,6 @@ enum rfkill_user_states {
> > >  #undef RFKILL_STATE_UNBLOCKED
> > >  #undef RFKILL_STATE_HARD_BLOCKED
> > >  
> > > -#include <linux/types.h>
> > >  #include <linux/kernel.h>
> > >  #include <linux/list.h>
> > >  #include <linux/mutex.h>
> >
> > with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems
> > correct.
> >
>
> ACK or Reviewed-by ?

both if you want to, but John already picked it up for wireless-testing
if I am not mistaken. So it is on its way into 2.6.32 somehow.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/44] includecheck: fix multiple includes

by dmitry pervushin-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Thu, 2009-07-09 at 09:58 +0530, Jaswinder Singh Rajput wrote:
> On Wed, 2009-07-08 at 22:13 +0100, Russell King wrote:
> > On Wed, Jul 08, 2009 at 11:30:59PM +0530, Jaswinder Singh Rajput wrote:
> > > I am still waiting ACK/NAK for :
for this:
> > >       includecheck fix: arm, plat-stmp3xxx/pinmux.c
Acked-by: dmitry pervushin <dpervushin@...>

> >
> > You're still waiting because apparantly you never sent this set anywhere
> > near any ARM people before.
> >
> > For the first two, I'll ack them:
> >
> > Acked-by: Russell King <rmk+kernel@...>
> >
> > The remainder look sane to me, but you'll have to seek acks from the
> > individual platform maintainer(s).
> >
>
> OK, adding some more ARM people and ARM lists to get remaining ACK/NAK.
>
> Patches are already posted to LKML and also available at :
>
> http://git.kernel.org/?p=linux/kernel/git/jaswinder/headers-check-2.6.git;a=summary
>
> In case if you are not able to find these patches let me know.
>
> Thanks,
> --
> JSR
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/44] includecheck fix: arm, board-dm355-evm.c

by Kevin Hilman-5 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Jaswinder Singh Rajput <jaswinder@...> writes:

> fix the following 'make includecheck' warning:
>
>   arch/arm/mach-davinci/board-dm355-evm.c: mach/common.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>

Acked-by: Kevin Hilman <khilman@...>

> ---
>  arch/arm/mach-davinci/board-dm355-evm.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-dm355-evm.c b/arch/arm/mach-davinci/board-dm355-evm.c
> index 5ac2f56..d6ab64c 100644
> --- a/arch/arm/mach-davinci/board-dm355-evm.c
> +++ b/arch/arm/mach-davinci/board-dm355-evm.c
> @@ -37,7 +37,6 @@
>  #include <mach/serial.h>
>  #include <mach/nand.h>
>  #include <mach/mmc.h>
> -#include <mach/common.h>
>  
>  #define DAVINCI_ASYNC_EMIF_CONTROL_BASE 0x01e10000
>  #define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE 0x02000000
> --
> 1.6.0.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 4/44] includecheck fix: arm, board-dm355-leopard.c

by Kevin Hilman-5 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Jaswinder Singh Rajput <jaswinder@...> writes:

> fix the following 'make includecheck' warning:
>
>   arch/arm/mach-davinci/board-dm355-leopard.c: mach/common.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>

Acked-by: Kevin Hilman <khilman@...>

> ---
>  arch/arm/mach-davinci/board-dm355-leopard.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-dm355-leopard.c b/arch/arm/mach-davinci/board-dm355-leopard.c
> index 28c9008..84ad5d1 100644
> --- a/arch/arm/mach-davinci/board-dm355-leopard.c
> +++ b/arch/arm/mach-davinci/board-dm355-leopard.c
> @@ -36,7 +36,6 @@
>  #include <mach/serial.h>
>  #include <mach/nand.h>
>  #include <mach/mmc.h>
> -#include <mach/common.h>
>  
>  #define DAVINCI_ASYNC_EMIF_CONTROL_BASE 0x01e10000
>  #define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE 0x02000000
> --
> 1.6.0.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
< Prev | 1 - 2 - 3 - 4 - 5 | Next >