[PATCH 0/44] includecheck: fix multiple includes

[Kevin Hilman-5]

Jaswinder Singh Rajput <jaswinder@...> writes:

> fix the following 'make includecheck' warning:
>
>   arch/arm/mach-davinci/board-dm644x-evm.c: mach/common.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>

Acked-by: Kevin Hilman <khilman@...>

> ---
>  arch/arm/mach-davinci/board-dm644x-evm.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c
> index d9d4045..56c8cd0 100644
> --- a/arch/arm/mach-davinci/board-dm644x-evm.c
> +++ b/arch/arm/mach-davinci/board-dm644x-evm.c
> @@ -45,7 +45,6 @@
>  #include <mach/nand.h>
>  #include <mach/mmc.h>
>  #include <mach/emac.h>
> -#include <mach/common.h>
>  
>  #define DM644X_EVM_PHY_MASK (0x2)
>  #define DM644X_EVM_MDIO_FREQUENCY (2200000) /* PHY bus frequency */
> --
> 1.6.0.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Kevin Hilman-5]

Jaswinder Singh Rajput <jaswinder@...> writes:

> fix the following 'make includecheck' warning:
>
>   arch/arm/mach-davinci/board-dm646x-evm.c: mach/common.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>

Acked-by: Kevin Hilman <khilman@...>

> ---
>  arch/arm/mach-davinci/board-dm646x-evm.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
> index e17de63..8657e72 100644
> --- a/arch/arm/mach-davinci/board-dm646x-evm.c
> +++ b/arch/arm/mach-davinci/board-dm646x-evm.c
> @@ -47,7 +47,6 @@
>  #include <mach/i2c.h>
>  #include <mach/mmc.h>
>  #include <mach/emac.h>
> -#include <mach/common.h>
>  
>  #define DM646X_EVM_PHY_MASK (0x2)
>  #define DM646X_EVM_MDIO_FREQUENCY (2200000) /* PHY bus frequency */
> --
> 1.6.0.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Kevin Hilman-5]

Jaswinder Singh Rajput <jaswinder@...> writes:

> fix the following 'make includecheck' warning:
>
>   arch/arm/mach-davinci/board-sffsdr.c: mach/common.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>

Acked-by: Kevin Hilman <khilman@...>

> ---
>  arch/arm/mach-davinci/board-sffsdr.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-sffsdr.c b/arch/arm/mach-davinci/board-sffsdr.c
> index 748a8e4..7acdfd8 100644
> --- a/arch/arm/mach-davinci/board-sffsdr.c
> +++ b/arch/arm/mach-davinci/board-sffsdr.c
> @@ -52,7 +52,6 @@
>  #include <mach/serial.h>
>  #include <mach/psc.h>
>  #include <mach/mux.h>
> -#include <mach/common.h>
>  
>  #define SFFSDR_PHY_MASK (0x2)
>  #define SFFSDR_MDIO_FREQUENCY (2200000) /* PHY bus frequency */
> --
> 1.6.0.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Kevin Hilman-5]

Jaswinder Singh Rajput <jaswinder@...> writes:

> fix the following 'make includecheck' warning:
>
>   arch/arm/mach-omap1/mcbsp.c: mach/irqs.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>

Tony's on vacation, so I'll ack these minor OMAP changes on his
behalf.

Acked-by: Kevin Hilman <khilman@...>

> ---
>  arch/arm/mach-omap1/mcbsp.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/mcbsp.c b/arch/arm/mach-omap1/mcbsp.c
> index a2d7814..505d98c 100644
> --- a/arch/arm/mach-omap1/mcbsp.c
> +++ b/arch/arm/mach-omap1/mcbsp.c
> @@ -19,7 +19,6 @@
>  
>  #include <mach/irqs.h>
>  #include <mach/dma.h>
> -#include <mach/irqs.h>
>  #include <mach/mux.h>
>  #include <mach/cpu.h>
>  #include <mach/mcbsp.h>
> --
> 1.6.0.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Kevin Hilman-5]

Jaswinder Singh Rajput <jaswinder@...> writes:

> fix the following 'make includecheck' warning:
>
>   arch/arm/mach-omap2/mcbsp.c: mach/irqs.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>

Acked-by: Kevin Hilman <khilman@...>

> ---
>  arch/arm/mach-omap2/mcbsp.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/mcbsp.c b/arch/arm/mach-omap2/mcbsp.c
> index a5c0f04..99b6e15 100644
> --- a/arch/arm/mach-omap2/mcbsp.c
> +++ b/arch/arm/mach-omap2/mcbsp.c
> @@ -19,7 +19,6 @@
>  
>  #include <mach/irqs.h>
>  #include <mach/dma.h>
> -#include <mach/irqs.h>
>  #include <mach/mux.h>
>  #include <mach/cpu.h>
>  #include <mach/mcbsp.h>
> --
> 1.6.0.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Olaf Weber-2]

Jaswinder Singh Rajput writes:

> fix the following 'make includecheck' warning:

>   fs/xfs/linux-2.6/xfs_iops.c: xfs_acl.h is included more than once.

> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>

Acked-By: Olaf Weber <olaf@...>



> ---
>  fs/xfs/linux-2.6/xfs_iops.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

> diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c
> index 58973bb..793a146 100644
> --- a/fs/xfs/linux-2.6/xfs_iops.c
> +++ b/fs/xfs/linux-2.6/xfs_iops.c
> @@ -43,7 +43,6 @@
>  #include "xfs_error.h"
>  #include "xfs_itable.h"
>  #include "xfs_rw.h"
> -#include "xfs_acl.h"
>  #include "xfs_attr.h"
>  #include "xfs_buf_item.h"
>  #include "xfs_utils.h"
> --
> 1.6.0.6

--
Olaf Weber                 SGI               Phone:  [phone]
                           Veldzigt 2b       Fax:    [phone]
Technical Lead             3454 PW de Meern  Vnet:   955-7151
Storage Software           The Netherlands   Email:  olaf@...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Cyrill Gorcunov]

[Jaswinder Singh Rajput - Wed, Jul 08, 2009 at 08:29:39PM +0530]
|
| fix the following 'make includecheck' warning:
|
|   arch/x86/mm/kmemcheck/shadow.c: linux/module.h is included more than once.
|
| Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>
| ---
|  arch/x86/mm/kmemcheck/shadow.c |    1 -
|  1 files changed, 0 insertions(+), 1 deletions(-)
|
| diff --git a/arch/x86/mm/kmemcheck/shadow.c b/arch/x86/mm/kmemcheck/shadow.c
| index e773b6b..3f66b82 100644
| --- a/arch/x86/mm/kmemcheck/shadow.c
| +++ b/arch/x86/mm/kmemcheck/shadow.c
| @@ -1,7 +1,6 @@
|  #include <linux/kmemcheck.h>
|  #include <linux/module.h>
|  #include <linux/mm.h>
| -#include <linux/module.h>
|  
|  #include <asm/page.h>
|  #include <asm/pgtable.h>
| --
| 1.6.0.6
|

Better to CC Vegard on this.
 
        -- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Cyrill Gorcunov]

[Jaswinder Singh Rajput - Wed, Jul 08, 2009 at 08:27:05PM +0530]
|
| fix the following 'make includecheck' warning:
|
|   arch/x86/kernel/dumpstack.c: linux/ftrace.h is included more than once.
|
| Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...>
| ---
|  arch/x86/kernel/dumpstack.c |    1 -
|  1 files changed, 0 insertions(+), 1 deletions(-)
|
| diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
| index c840571..2d8a371 100644
| --- a/arch/x86/kernel/dumpstack.c
| +++ b/arch/x86/kernel/dumpstack.c
| @@ -15,7 +15,6 @@
|  #include <linux/bug.h>
|  #include <linux/nmi.h>
|  #include <linux/sysfs.h>
| -#include <linux/ftrace.h>
|  
|  #include <asm/stacktrace.h>
|  
| --
| 1.6.0.6

Looks good to me.
Acked-by: Cyrill Gorcunov <gorcunov@...>
 
        -- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Thomas Gleixner]

On Thu, 9 Jul 2009, Cyrill Gorcunov wrote:

> |  #include <linux/kmemcheck.h>
> |  #include <linux/module.h>
> |  #include <linux/mm.h>
> | -#include <linux/module.h>
> |  
> |  #include <asm/page.h>
> |  #include <asm/pgtable.h>
> | --
> | 1.6.0.6
> |
>
> Better to CC Vegard on this.

Can we stop this kindergarden already? The patch is so obvious that it
just should be applied. I'll pick up all x86 ones and fold them in.

Thanks,

        tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Pekka Enberg-3]

Hi Thomas,

> On Thu, 9 Jul 2009, Cyrill Gorcunov wrote:
>> |  #include <linux/kmemcheck.h>
>> |  #include <linux/module.h>
>> |  #include <linux/mm.h>
>> | -#include <linux/module.h>
>> |
>> |  #include <asm/page.h>
>> |  #include <asm/pgtable.h>
>> | --
>> | 1.6.0.6
>> |
>>
>> Better to CC Vegard on this.

On Thu, Jul 9, 2009 at 9:18 PM, Thomas Gleixner<tglx@...> wrote:
> Can we stop this kindergarden already? The patch is so obvious that it
> just should be applied. I'll pick up all x86 ones and fold them in.

What kindergarten are you talking about? Technically Ingo "kicked"
kmemcheck out of the x86 tree so the patch should go through
kmemcheck.git which makes Cyrill's CC correction spot on.

                        Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Jaswinder Singh Rajput-3]

Linus,

Please pull includecheck fixes, these all are clean and safe patches
with relevant Acks.

The following changes since commit 34f25476ace556263784ea2f8173e22b25557a13:
  Linus Torvalds (1):
        Merge branch 'fixes' of git://git.kernel.org/.../davej/cpufreq

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/include-check-2.6.git master

Jaswinder Singh Rajput (42):
      includecheck fix: arm, misc.c
      includecheck fix: arm, atomic.h
      includecheck fix: arm, board-dm355-evm.c
      includecheck fix: arm, board-dm355-leopard.c
      includecheck fix: arm, board-dm644x-evm.c
      includecheck fix: arm, board-dm646x-evm.c
      includecheck fix: arm, board-sffsdr.c
      includecheck fix: arm, mach-mx3/devices.c
      includecheck fix: arm, mach-omap1/mcbsp.c
      includecheck fix: arm, mach-omap2/mcbsp.c
      includecheck fix: arm, plat-s3c64xx/pm.c
      includecheck fix: arm, plat-stmp3xxx/pinmux.c
      includecheck fix: mn10300, sys_mn10300.c
      includecheck fix: s390, sys_s390.c
      includecheck fix: um, helper.c
      includecheck fix: x86, dumpstack.c
      includecheck fix: x86, traps.c
      includecheck fix: x86, shadow.c
      includecheck fix: Documentation, cfag12864b-example.c
      includecheck fix: drivers/char, vt.c
      includecheck fix: drivers/net, sja1000.c
      includecheck fix: drivers/net, axnet_cs.c
      includecheck fix: drivers/net, smc911x.h
      includecheck fix: drivers/parisc, ccio-dma.c
      includecheck fix: drivers/scsi, libfcoe.c
      includecheck fix: drivers/scsi, ibmvscsi.c
      includecheck fix: drivers/spi, amba-pl022.c
      includecheck fix: drivers/staging, usbdrv.c
      includecheck fix: drivers/staging, rt_linux.h
      includecheck fix: drivers/video, vgacon.c
      includecheck fix: drivers/xen, evtchn.c
      includecheck fix: fs/xfs, xfs_iops.c
      includecheck fix: include/acpi, acpi_bus.h
      includecheck fix: include/drm, drm_memory.h
      includecheck fix: include/linux, aio.h
      includecheck fix: include/linux, ftrace.h
      includecheck fix: include/linux, icmpv6.h
      includecheck fix: include/linux, net_dropmon.h
      includecheck fix: include/linux, rfkill.h
      includecheck fix: kernel/trace, ring_buffer.c
      includecheck fix: mm, nommu.c
      includecheck fix: mm, shmem.c

 Documentation/auxdisplay/cfag12864b-example.c |    1 -
 arch/arm/boot/compressed/misc.c               |    1 -
 arch/arm/include/asm/atomic.h                 |    2 --
 arch/arm/mach-davinci/board-dm355-evm.c       |    1 -
 arch/arm/mach-davinci/board-dm355-leopard.c   |    1 -
 arch/arm/mach-davinci/board-dm644x-evm.c      |    1 -
 arch/arm/mach-davinci/board-dm646x-evm.c      |    1 -
 arch/arm/mach-davinci/board-sffsdr.c          |    1 -
 arch/arm/mach-mx3/devices.c                   |    1 -
 arch/arm/mach-omap1/mcbsp.c                   |    1 -
 arch/arm/mach-omap2/mcbsp.c                   |    1 -
 arch/arm/plat-s3c64xx/pm.c                    |    2 --
 arch/arm/plat-stmp3xxx/pinmux.c               |    1 -
 arch/mn10300/kernel/sys_mn10300.c             |    1 -
 arch/s390/kernel/sys_s390.c                   |    1 -
 arch/um/os-Linux/helper.c                     |    1 -
 arch/x86/kernel/dumpstack.c                   |    1 -
 arch/x86/kernel/traps.c                       |    1 -
 arch/x86/mm/kmemcheck/shadow.c                |    1 -
 drivers/char/vt.c                             |    1 -
 drivers/net/can/sja1000/sja1000.c             |    1 -
 drivers/net/pcmcia/axnet_cs.c                 |    2 --
 drivers/net/smc911x.h                         |    1 -
 drivers/parisc/ccio-dma.c                     |    1 -
 drivers/scsi/fcoe/libfcoe.c                   |    1 -
 drivers/scsi/ibmvscsi/ibmvscsi.c              |    1 -
 drivers/spi/amba-pl022.c                      |    2 --
 drivers/staging/otus/usbdrv.c                 |    3 ---
 drivers/staging/rt2860/rt_linux.h             |    4 ----
 drivers/video/console/vgacon.c                |    1 -
 drivers/xen/evtchn.c                          |    1 -
 fs/xfs/linux-2.6/xfs_iops.c                   |    1 -
 include/acpi/acpi_bus.h                       |    1 -
 include/drm/drm_memory.h                      |    2 --
 include/linux/aio.h                           |    2 --
 include/linux/ftrace.h                        |    1 -
 include/linux/icmpv6.h                        |    2 --
 include/linux/net_dropmon.h                   |    1 -
 include/linux/rfkill.h                        |    1 -
 kernel/trace/ring_buffer.c                    |    2 --
 mm/nommu.c                                    |    2 --
 mm/shmem.c                                    |    1 -
 42 files changed, 0 insertions(+), 56 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Ben Dooks-11]

Jaswinder Singh Rajput wrote:

> On Wed, 2009-07-08 at 22:13 +0100, Russell King wrote:
>> On Wed, Jul 08, 2009 at 11:30:59PM +0530, Jaswinder Singh Rajput wrote:
>>> I am still waiting ACK/NAK for :
>>>
>>>       includecheck fix: arm, misc.c
>>>       includecheck fix: arm, atomic.h
>>>       includecheck fix: arm, board-dm355-evm.c
>>>       includecheck fix: arm, board-dm355-leopard.c
>>>       includecheck fix: arm, board-dm644x-evm.c
>>>       includecheck fix: arm, board-dm646x-evm.c
>>>       includecheck fix: arm, board-sffsdr.c
>>>       includecheck fix: arm, mach-mx3/devices.c
>>>       includecheck fix: arm, mach-omap1/mcbsp.c
>>>       includecheck fix: arm, mach-omap2/mcbsp.c
>>>       includecheck fix: arm, plat-s3c64xx/pm.c
>>>       includecheck fix: arm, plat-stmp3xxx/pinmux.c
>> You're still waiting because apparantly you never sent this set anywhere
>> near any ARM people before.
>>
>> For the first two, I'll ack them:
>>
>> Acked-by: Russell King <rmk+kernel@...>
>>
>> The remainder look sane to me, but you'll have to seek acks from the
>> individual platform maintainer(s).
>>

Ack for plat-s3c64xx/pm.c:
Acked-by: Ben Dooks <ben-linux@...>

--
Ben Dooks, Software Engineer, Simtec Electronics

http://www.simtec.co.uk/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Thomas Gleixner]

On Thu, 9 Jul 2009, Pekka Enberg wrote:
> On Thu, Jul 9, 2009 at 9:18 PM, Thomas Gleixner<tglx@...> wrote:
> > Can we stop this kindergarden already? The patch is so obvious that it
> > just should be applied. I'll pick up all x86 ones and fold them in.
>
> What kindergarten are you talking about? Technically Ingo "kicked"
> kmemcheck out of the x86 tree so the patch should go through
> kmemcheck.git which makes Cyrill's CC correction spot on.

I'm referring to the fact that these changes are so obvious that we do
neither need dozens separate commits nor the ack of everyone plus some
more. My inbox is full enough already.

Thanks,

        tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Philip Balister-3]

Jaswinder Singh Rajput wrote:

> On Wed, 2009-07-08 at 22:13 +0100, Russell King wrote:
>> On Wed, Jul 08, 2009 at 11:30:59PM +0530, Jaswinder Singh Rajput wrote:
>>> I am still waiting ACK/NAK for :
>>>
>>>       includecheck fix: arm, misc.c
>>>       includecheck fix: arm, atomic.h
>>>       includecheck fix: arm, board-dm355-evm.c
>>>       includecheck fix: arm, board-dm355-leopard.c
>>>       includecheck fix: arm, board-dm644x-evm.c
>>>       includecheck fix: arm, board-dm646x-evm.c
>>>       includecheck fix: arm, board-sffsdr.c
>>>       includecheck fix: arm, mach-mx3/devices.c
>>>       includecheck fix: arm, mach-omap1/mcbsp.c
>>>       includecheck fix: arm, mach-omap2/mcbsp.c
>>>       includecheck fix: arm, plat-s3c64xx/pm.c
>>>       includecheck fix: arm, plat-stmp3xxx/pinmux.c
>> You're still waiting because apparantly you never sent this set anywhere
>> near any ARM people before.
>>
>> For the first two, I'll ack them:
>>
>> Acked-by: Russell King <rmk+kernel@...>
>>
>> The remainder look sane to me, but you'll have to seek acks from the
>> individual platform maintainer(s).
>>

Ack for board-sffsdr.c:
Acked-by: Philip Balister <philip@...>

>
> OK, adding some more ARM people and ARM lists to get remaining ACK/NAK.
>
> Patches are already posted to LKML and also available at :
>
> http://git.kernel.org/?p=linux/kernel/git/jaswinder/headers-check-2.6.git;a=summary
>
> In case if you are not able to find these patches let me know.
>
> Thanks,
> --
> JSR
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Linus Walleij-2]

2009/7/8 Jaswinder Singh Rajput <jaswinder@...>:

> On Wed, 2009-07-08 at 19:28 +0200, Linus Walleij wrote:
>> 2009/7/8 Jaswinder Singh Rajput <jaswinder@...>:
>>
>> > fix the following 'make includecheck' warnings:
>> >
>> >  drivers/spi/amba-pl022.c: linux/delay.h is included more than once.
>> >  drivers/spi/amba-pl022.c: linux/errno.h is included more than once.
>>
>> Acked-by: Linus Walleij <linus.walleij@...>
>>
>> David are you merging this?
>
> This is a big patchset, So better me or Sam will send this to Linus
> after collecting some more ACKs.

Not me I hope (damned I knew this would happen sooner or later).
return -ELINWAL

Having this name is very convenient, people review my drivers like
crazy.

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Linus Torvalds-3]

On Thu, 9 Jul 2009, Linus Walleij wrote:
>
> Having this name is very convenient, people review my drivers like
> crazy.

ROTFL.

                the-other-Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Greg KH]

On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> Linus,
>
> Please pull includecheck fixes, these all are clean and safe patches
> with relevant Acks.

Shouldn't stuff like this go through the trivial tree?  And stuff like
that is relevant for the main pre-rc1 merge, not this late in the merge
cycle, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Jaswinder Singh Rajput-3]

Hello Greg,

On Thu, 2009-07-09 at 15:26 -0700, Greg KH wrote:

> On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> > Linus,
> >
> > Please pull includecheck fixes, these all are clean and safe patches
> > with relevant Acks.
>
> Shouldn't stuff like this go through the trivial tree?  And stuff like
> that is relevant for the main pre-rc1 merge, not this late in the merge
> cycle, right?
>

You did not specified what is your problem ? and where was you when we
discussed it earlier ?

Normally brain is above then the eyes, do you know why ?

To use your brain instead of follow things blindly.

The point of watching patches for some time means test and wait so that
they can show their real faces.

BTW, it is not late, it is not going to hit stable in next week or so.

Keeping these sane patches waiting for complete cycle will be insaner.

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[James Bottomley-2]

On Fri, 2009-07-10 at 08:29 +0530, Jaswinder Singh Rajput wrote:

> Hello Greg,
>
> On Thu, 2009-07-09 at 15:26 -0700, Greg KH wrote:
> > On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> > > Linus,
> > >
> > > Please pull includecheck fixes, these all are clean and safe patches
> > > with relevant Acks.
> >
> > Shouldn't stuff like this go through the trivial tree?  And stuff like
> > that is relevant for the main pre-rc1 merge, not this late in the merge
> > cycle, right?
> >
>
> You did not specified what is your problem ? and where was you when we
> discussed it earlier ?

The problem, as you have been told several times, is that maintainers
are very busy people and don't necessarily have time to deal with
mechanical replacement trivia like this.

The point is that Jiri Kosina takes that burden on himself to verify and
submit the changes like this, so something like this should go through
him.

> Normally brain is above then the eyes, do you know why ?
>
> To use your brain instead of follow things blindly.
>
> The point of watching patches for some time means test and wait so that
> they can show their real faces.

Abusing people who do real work, particularly when you manifestly do
not, is a gross breach of etiquette ... welcome to my killfile.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Greg KH]

On Fri, Jul 10, 2009 at 08:29:15AM +0530, Jaswinder Singh Rajput wrote:

> Hello Greg,
>
> On Thu, 2009-07-09 at 15:26 -0700, Greg KH wrote:
> > On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> > > Linus,
> > >
> > > Please pull includecheck fixes, these all are clean and safe patches
> > > with relevant Acks.
> >
> > Shouldn't stuff like this go through the trivial tree?  And stuff like
> > that is relevant for the main pre-rc1 merge, not this late in the merge
> > cycle, right?
> >
>
> You did not specified what is your problem ? and where was you when we
> discussed it earlier ?

Earlier when?  I responded to your query about the individual patches
you copied me on, saying they were in my "to-apply" queue and I didn't
want them to go to Linus at this point in time.  You seem quite rushed
about these patches, which is odd to me.

> Normally brain is above then the eyes, do you know why ?
>
> To use your brain instead of follow things blindly.
>
> The point of watching patches for some time means test and wait so that
> they can show their real faces.

Which is what I am asking you to do here.  So why are you arguing with
this concept?

> BTW, it is not late, it is not going to hit stable in next week or so.
>
> Keeping these sane patches waiting for complete cycle will be insaner.

Accepting trivial patches like these, for which a full build cycle of
all arches has yet to be accomplished due to a lack of inclusion in the
-next tree, at a point in the development series in which bug fixes and
regressions are the only thing to be accepted, seems to be a risk, don't
you think?

But hey, I'm not Linus, it's up to him to decide to take untested stuff
like this or not, not me :)

best of luck,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/