|

»

Gnu - PSPP - Dev

[PATCH 1/1] Fix DSO linking issue

View: New views

5 Messages — Rating Filter: Alert me

	[PATCH 1/1] Fix DSO linking issue by Peter Lemenkov-2 :: Rate this Message: \| View Threaded \| Show Only this Message We must explicitly list every required library in case then linker is built with default behaviour which prevents implicit DSO linking. See this for the details on DSO Linking issues: http://fedoraproject.org/wiki/UnderstandingDSOLinkChange Signed-off-by: Peter Lemenkov <lemenkov@...> --- src/ui/gui/automake.mk \| 1 + src/ui/terminal/automake.mk \| 1 + 2 files changed, 2 insertions(+) diff --git a/src/ui/gui/automake.mk b/src/ui/gui/automake.mk index 75ca28a..e6aaf57 100644 --- a/src/ui/gui/automake.mk +++ b/src/ui/gui/automake.mk @@ -73,6 +73,7 @@ src_ui_gui_psppire_LDADD = \ src/ui/libuicommon.la \ src/libpspp.la \ src/libpspp-core.la \ + $(GSL_LIBS) \ $(GTK_LIBS) \ $(GTKSOURCEVIEW_LIBS) \ $(CAIRO_LIBS) \ diff --git a/src/ui/terminal/automake.mk b/src/ui/terminal/automake.mk index 7bf2e6f..82f9ef8 100644 --- a/src/ui/terminal/automake.mk +++ b/src/ui/terminal/automake.mk @@ -23,6 +23,7 @@ src_ui_terminal_pspp_LDADD = \ src/libpspp.la \ src/libpspp-core.la \ $(CAIRO_LIBS) \ + $(GSL_LIBS) \ $(NCURSES_LIBS) \ $(LIBREADLINE) \ $(GSL_LIBS) -- 1.7.9.3 _______________________________________________ pspp-dev mailing list pspp-dev@... https://lists.gnu.org/mailman/listinfo/pspp-dev
	Re: [PATCH 1/1] Fix DSO linking issue by Ben Pfaff :: Rate this Message: \| View Threaded \| Show Only this Message Peter Lemenkov <lemenkov@...> writes: > We must explicitly list every required library in case then linker is built > with default behaviour which prevents implicit DSO linking. > > See this for the details on DSO Linking issues: > > http://fedoraproject.org/wiki/UnderstandingDSOLinkChange > > Signed-off-by: Peter Lemenkov <lemenkov@...> I applied this to the PSPP "master" branch. Thank you! _______________________________________________ pspp-dev mailing list pspp-dev@... https://lists.gnu.org/mailman/listinfo/pspp-dev
	Re: [PATCH 1/1] Fix DSO linking issue by John Darrington-4 :: Rate this Message: \| View Threaded \| Show Only this Message We now have the line $(GSL_LIBS) appearing twice in src/ui/terminal/automake.mk Was this what was intended? On Sun, Apr 15, 2012 at 04:24:04PM -0700, Ben Pfaff wrote: Peter Lemenkov <lemenkov@...> writes: > We must explicitly list every required library in case then linker is built > with default behaviour which prevents implicit DSO linking. > > See this for the details on DSO Linking issues: > > http://fedoraproject.org/wiki/UnderstandingDSOLinkChange > > Signed-off-by: Peter Lemenkov <lemenkov@...> I applied this to the PSPP "master" branch. Thank you! _______________________________________________ pspp-dev mailing list pspp-dev@... https://lists.gnu.org/mailman/listinfo/pspp-dev -- PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://keys.gnupg.net or any PGP keyserver for public key. _______________________________________________ pspp-dev mailing list pspp-dev@... https://lists.gnu.org/mailman/listinfo/pspp-dev signature.asc (196 bytes) Download Attachment
	Re: [PATCH 1/1] Fix DSO linking issue by Peter Lemenkov-2 :: Rate this Message: \| View Threaded \| Show Only this Message Hello. 2012/4/16 John Darrington <john@...>: > We now have the line $(GSL_LIBS) appearing twice in src/ui/terminal/automake.mk > > Was this what was intended? Mea culpa. I didn't check whether this issue is still valid since 0.7.8 - just rebased my old patch. I believe it should be reverted completely. Again, sorry for the noise. -- With best regards, Peter Lemenkov. _______________________________________________ pspp-dev mailing list pspp-dev@... https://lists.gnu.org/mailman/listinfo/pspp-dev
	Re: [PATCH 1/1] Fix DSO linking issue by Ben Pfaff :: Rate this Message: \| View Threaded \| Show Only this Message Peter Lemenkov <lemenkov@...> writes: > 2012/4/16 John Darrington <john@...>: >> We now have the line $(GSL_LIBS) appearing twice in src/ui/terminal/automake.mk >> >> Was this what was intended? > > Mea culpa. I didn't check whether this issue is still valid since > 0.7.8 - just rebased my old patch. I believe it should be reverted > completely. I pushed a revert. _______________________________________________ pspp-dev mailing list pspp-dev@... https://lists.gnu.org/mailman/listinfo/pspp-dev