« Return to Thread: [PATCH 00/37] xfs: current 3.4 patch queue

[PATCH 18/37] xfs: use kmem_zone_zalloc for buffers

by Dave Chinner :: Rate this Message:

| View in Thread

From: Dave Chinner <dchinner@...>

To replace the alloc/memset pair.

Signed-off-by: Dave Chinner <dchinner@...>
Reviewed-by: Christoph Hellwig <hch@...>
Reviewed-by: Mark Tinguely <tinguely@...>
---
 fs/xfs/xfs_buf.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index ddfc58f..f463dce 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -178,7 +178,7 @@ xfs_buf_alloc(
 {
  struct xfs_buf *bp;
 
- bp = kmem_zone_alloc(xfs_buf_zone, xb_to_km(flags));
+ bp = kmem_zone_zalloc(xfs_buf_zone, xb_to_km(flags));
  if (unlikely(!bp))
  return NULL;
 
@@ -187,7 +187,6 @@ xfs_buf_alloc(
  */
  flags &= ~(XBF_LOCK|XBF_MAPPED|XBF_DONT_BLOCK|XBF_READ_AHEAD);
 
- memset(bp, 0, sizeof(xfs_buf_t));
  atomic_set(&bp->b_hold, 1);
  atomic_set(&bp->b_lru_ref, 1);
  init_completion(&bp->b_iowait);
--
1.7.9.5

_______________________________________________
xfs mailing list
xfs@...
http://oss.sgi.com/mailman/listinfo/xfs

 « Return to Thread: [PATCH 00/37] xfs: current 3.4 patch queue