[PATCH]kernel/irq/chip.c:Modify the code note

View: New views
3 Messages — Rating Filter:   Alert me  

[PATCH]kernel/irq/chip.c:Modify the code note

by liu weni :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

In the origin, the code notes are not fit for set_irq_msi.
The function name is set_irq_data.

And, I change function note "handle_percpu_IRQ" to "handle_percpu_irq".


Signed-off-by: Liuwenyi <qingshenlwy@...>

------------------------------------------
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index c166019..ba566c2 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
 EXPORT_SYMBOL(set_irq_data);
 
 /**
- * set_irq_data - set irq type data for an irq
+ * set_irq_msi - set MSI descriptor data for an irq
  * @irq: Interrupt number
  * @entry: Pointer to MSI descriptor data
  *
- * Set the hardware irq controller data for an irq
+ * Set the MSI descriptor entry for an irq
  */
 int set_irq_msi(unsigned int irq, struct msi_desc *entry)
 {
@@ -590,7 +590,7 @@ out_unlock:
 }
 
 /**
- * handle_percpu_IRQ - Per CPU local irq handler
+ * handle_percpu_irq - Per CPU local irq handler
  * @irq: the interrupt number
  * @desc: the interrupt description structure for this irq
  *

 
--------------
Liuweni
2009-11-04

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH]kernel/irq/chip.c:Modify the code note

by Jiri Kosina-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, 4 Nov 2009, Liuweni wrote:

> In the origin, the code notes are not fit for set_irq_msi.
> The function name is set_irq_data.
>
> And, I change function note "handle_percpu_IRQ" to "handle_percpu_irq".
>
>
> Signed-off-by: Liuwenyi <qingshenlwy@...>
>
> ------------------------------------------
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index c166019..ba566c2 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
>  EXPORT_SYMBOL(set_irq_data);
>  
>  /**
> - * set_irq_data - set irq type data for an irq
> + * set_irq_msi - set MSI descriptor data for an irq
>   * @irq: Interrupt number
>   * @entry: Pointer to MSI descriptor data
>   *
> - * Set the hardware irq controller data for an irq
> + * Set the MSI descriptor entry for an irq
>   */

You have submitted this hunk separately before, and I already have it in
my queue (and I have sent you a mail informing you about this being
merged), so you'd better not include it as part of any further patch
submissions.

--
Jiri Kosina
SUSE Labs, Novell Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Re: [PATCH]kernel/irq/chip.c:Modify the code note

by liu weni :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Thank you very much.

Someone tell me that my pre-mail's format is incorrect. The correct format is
......
Changlog
......
Signed-off-by: yourname <your@mail>
----------------------
patch context

And I have not received your mail. Maybe The gmail play a trick.

Then, I re-submitt this hunk after a week.

But now, I have found your mail in the mail-list.



 


2009-11-04



Liuweni



发件人: Jiri Kosina
发送时间: 2009-11-04  21:06:24
收件人: Liuweni
抄送: linux-kernel; qingshenlwy; xgr178
主题: Re: [PATCH]kernel/irq/chip.c:Modify the code note
 
On Wed, 4 Nov 2009, Liuweni wrote:

> In the origin, the code notes are not fit for set_irq_msi.
> The function name is set_irq_data.
>
> And, I change function note "handle_percpu_IRQ" to "handle_percpu_irq".
>
>
> Signed-off-by: Liuwenyi <qingshenlwy@...>
>
> ------------------------------------------
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index c166019..ba566c2 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
>  EXPORT_SYMBOL(set_irq_data);
>  
>  /**
> - * set_irq_data - set irq type data for an irq
> + * set_irq_msi - set MSI descriptor data for an irq
>   * @irq: Interrupt number
>   * @entry: Pointer to MSI descriptor data
>   *
> - * Set the hardware irq controller data for an irq
> + * Set the MSI descriptor entry for an irq
>   */
You have submitted this hunk separately before, and I already have it in
my queue (and I have sent you a mail informing you about this being
merged), so you'd better not include it as part of any further patch
submissions.
--
Jiri Kosina
SUSE Labs, Novell Inc.
N�Р骒r��y����b�X�肚�v�^�)藓{.n�+�伐�{��赙zXФ�≤�}��财�z�&j:+v�����赙zZ+��+zf"�h���~����i���z��wア�?�ㄨ��&�)撷f��^j谦y�m��@A�a囤� 0鹅h���i