[PATCH v3 5/7] vsprintf: reduce code size by avoiding extra check

[Andre Goddard Rosa]

From: André Goddard Rosa <andre.goddard@...>
Date: Tue, 3 Nov 2009 10:53:13 -0200
Subject: [PATCH v3 5/7] vsprintf: reduce code size by avoiding extra check
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

No functional change, just refactor the code so that it avoid checking
"if (hi)" two times in a sequence, taking advantage of previous check made.

It also reduces code size:
   text    data     bss     dec     hex filename
  15735       0       8   15743    3d7f lib/vsprintf.o-before
  15719       0       8   15727    3d6f lib/vsprintf.o-minus-double-check

Signed-off-by: André Goddard Rosa <andre.goddard@...>
Acked-by: Frederic Weisbecker <fweisbec@...>
---
 lib/vsprintf.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 14e4197..af79152 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -747,8 +747,9 @@ static char *ip6_compressed_string(char *p, const
char *addr)
  p = pack_hex_byte(p, hi);
  else
  *p++ = hex_asc_lo(hi);
+ p = pack_hex_byte(p, lo);
  }
- if (hi || lo > 0x0f)
+ else if (lo > 0x0f)
  p = pack_hex_byte(p, lo);
  else
  *p++ = hex_asc_lo(lo);
--
1.6.5.2.143.g8cc62.dirty
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/