[Patch] -as-needed compatibility

Attached is the cdrtools-2.01.01_alpha34-asneeded patch as submitted to
https://bugs.gentoo.org/show_bug.cgi?id=190180 by Samuli Suominen.

Maybe you can include it in a future cdrtools version.

Thanks!

Regards
Sebastian

diff -ur cdrtools-2.01.01.orig/libfind/libfind.mk cdrtools-2.01.01/libfind/libfind.mk
--- cdrtools-2.01.01.orig/libfind/libfind.mk 2007-02-04 01:00:05.000000000 +0200
+++ cdrtools-2.01.01/libfind/libfind.mk 2007-08-28 22:33:25.000000000 +0300
@@ -20,7 +20,7 @@
 CPPOPTS += -DSCHILY_PRINT
 
 include Targets
-LIBS=
+LIBS= $(LIB_ACL)
 
 ###########################################################################
 include $(SRCROOT)/$(RULESDIR)/rules.lib
diff -ur cdrtools-2.01.01.orig/libfind/libfind_p.mk cdrtools-2.01.01/libfind/libfind_p.mk
--- cdrtools-2.01.01.orig/libfind/libfind_p.mk 2007-06-30 14:13:34.000000000 +0300
+++ cdrtools-2.01.01/libfind/libfind_p.mk 2007-08-28 22:34:04.000000000 +0300
@@ -22,7 +22,7 @@
 CPPOPTS += -DSCHILY_PRINT
 
 include Targets
-LIBS=
+LIBS= $(LIB_ACL)
 
 ###########################################################################
 include $(SRCROOT)/$(RULESDIR)/rules.lib
diff -ur cdrtools-2.01.01.orig/libfind/shlfind.mk cdrtools-2.01.01/libfind/shlfind.mk
--- cdrtools-2.01.01.orig/libfind/shlfind.mk 2007-02-04 01:00:05.000000000 +0200
+++ cdrtools-2.01.01/libfind/shlfind.mk 2007-08-28 22:45:14.000000000 +0300
@@ -21,7 +21,7 @@
 CPPOPTS += -DSCHILY_PRINT
 
 include Targets
-LIBS= -lschily -lc
+LIBS= -lschily -lc $(LIB_ACL)
 
 ###########################################################################
 include $(SRCROOT)/$(RULESDIR)/rules.shl

_______________________________________________
Cdrecord-developers mailing list
Cdrecord-developers@...
https://lists.berlios.de/mailman/listinfo/cdrecord-developers

[Joerg Schilling-3]

Sebastian Kemper <sebastian_ml@...> wrote:

> Attached is the cdrtools-2.01.01_alpha34-asneeded patch as submitted to
> https://bugs.gentoo.org/show_bug.cgi?id=190180 by Samuli Suominen.
>
> Maybe you can include it in a future cdrtools version.

Adding something like LIBS in a makefile for static libraries will not help,

It looks like we need to change the makefiles for all libfind users.

Jörg

--
 EMail:joerg@... (home) Jörg Schilling D-13353 Berlin
       js@...                (uni)  
       schilling@...     (work) Blog: http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/old/private/ ftp://ftp.berlios.de/pub/schily
_______________________________________________
Cdrecord-developers mailing list
Cdrecord-developers@...
https://lists.berlios.de/mailman/listinfo/cdrecord-developers

[Joerg Schilling-3]

Sebastian Kemper <sebastian_ml@...> wrote:

> Attached is the cdrtools-2.01.01_alpha34-asneeded patch as submitted to
> https://bugs.gentoo.org/show_bug.cgi?id=190180 by Samuli Suominen.
>
> Maybe you can include it in a future cdrtools version.
>

I just checked my sources and cannot find any problem!

1) The Makefile for mkisofs includes $(LIB_ACL) _after_ -lfind

2) Adding LIBS= $(LIB_ACL) to a makefile that creates a static
        library is a noop.

3) https://bugs.gentoo.org/show_bug.cgi?id=190180 does not include
        a problem desciption that includes a log from the compilation
        that would verify a problem.

The only possible change I see is that mkisofs/Makefile would work
with $(LIB_ACL_TEST) and doesn't need $(LIB_AC).

If you belive that there is a problem, please describe it.

Jörg

--
 EMail:joerg@... (home) Jörg Schilling D-13353 Berlin
       js@...                (uni)  
       schilling@...     (work) Blog: http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/old/private/ ftp://ftp.berlios.de/pub/schily
_______________________________________________
Cdrecord-developers mailing list
Cdrecord-developers@...
https://lists.berlios.de/mailman/listinfo/cdrecord-developers

On Tue, Sep 11, 2007 at 02:57:07PM +0200, Joerg Schilling wrote:
> The only possible change I see is that mkisofs/Makefile would work
> with $(LIB_ACL_TEST) and doesn't need $(LIB_AC).
>
> If you belive that there is a problem, please describe it.

Hello Jörg,

I added another comment including your last reply to bugzilla. Once I
get and answer I'll promptly get back to you.

https://bugs.gentoo.org/show_bug.cgi?id=190180

Regards
Sebastian
_______________________________________________
Cdrecord-developers mailing list
Cdrecord-developers@...
https://lists.berlios.de/mailman/listinfo/cdrecord-developers

[Joerg Schilling-3]

Sebastian Kemper <sebastian_ml@...> wrote:

> On Tue, Sep 11, 2007 at 02:57:07PM +0200, Joerg Schilling wrote:
> > The only possible change I see is that mkisofs/Makefile would work
> > with $(LIB_ACL_TEST) and doesn't need $(LIB_AC).
> >
> > If you belive that there is a problem, please describe it.
>
> Hello Jörg,
>
> I added another comment including your last reply to bugzilla. Once I
> get and answer I'll promptly get back to you.
>
> https://bugs.gentoo.org/show_bug.cgi?id=190180

OK, thank you!

Jörg

--
 EMail:joerg@... (home) Jörg Schilling D-13353 Berlin
       js@...                (uni)  
       schilling@...     (work) Blog: http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/old/private/ ftp://ftp.berlios.de/pub/schily
_______________________________________________
Cdrecord-developers mailing list
Cdrecord-developers@...
https://lists.berlios.de/mailman/listinfo/cdrecord-developers

Hello Jörg,

I didn't get an answer to the question I posted to Gentoo's bugzilla
regarding the patch.

Please disregard it.

Regards
Sebastian
_______________________________________________
Cdrecord-developers mailing list
Cdrecord-developers@...
https://lists.berlios.de/mailman/listinfo/cdrecord-developers