[Patch] Fix for LP 264709

View: New views
2 Messages — Rating Filter:   Alert me  

[Patch] Fix for LP 264709

by Maximilian Albert-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

attached is a fix for bug 264709. It would be great if one of the
release wardens could take a look and commit if appropriate.

Thanks,
Max

[fix_for_bug_264709.patch]

diff --git a/src/widgets/desktop-widget.cpp b/src/widgets/desktop-widget.cpp
index 0bf0941..5fd3248 100644
--- a/src/widgets/desktop-widget.cpp
+++ b/src/widgets/desktop-widget.cpp
@@ -1283,11 +1283,19 @@ SPDesktopWidget::setToolboxFocusTo (const gchar* label)
 void
 SPDesktopWidget::setToolboxAdjustmentValue (gchar const *id, double value)
 {
+    GtkAdjustment *a = NULL;
     gpointer hb = sp_search_by_data_recursive (aux_toolbox, (gpointer) id);
-    if (hb && GTK_IS_WIDGET(hb) && GTK_IS_SPIN_BUTTON(hb)) {
-        GtkAdjustment *a = gtk_spin_button_get_adjustment (GTK_SPIN_BUTTON(hb));
-        gtk_adjustment_set_value (a, value);
+    if (hb && GTK_IS_WIDGET(hb)) {
+        if (GTK_IS_SPIN_BUTTON(hb))
+            a = gtk_spin_button_get_adjustment (GTK_SPIN_BUTTON(hb));
+        else if (GTK_IS_RANGE(hb))
+            a = gtk_range_get_adjustment (GTK_RANGE(hb));
     }
+
+    if (a)
+        gtk_adjustment_set_value (a, value);
+    else
+        g_warning ("Could not find GtkAdjustment for %s\n", id);
 }
 
 void


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Inkscape-devel mailing list
Inkscape-devel@...
https://lists.sourceforge.net/lists/listinfo/inkscape-devel

Re: [Patch] Fix for LP 264709

by Joshua A. Andler-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Sat, 2009-10-03 at 12:32 +0100, Maximilian Albert wrote:
> Hi,
>
> attached is a fix for bug 264709. It would be great if one of the
> release wardens could take a look and commit if appropriate.


Hey Max,

Thanks for the patch. However, in the future, please attach patches to
their corresponding bug reports in the tracker. Fix committed.

Cheers,
Josh


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Inkscape-devel mailing list
Inkscape-devel@...
https://lists.sourceforge.net/lists/listinfo/inkscape-devel