[PostGIS] #253: Gist causes wrong result from ~=

View: New views
20 Messages — Rating Filter:   Alert me  
< Prev | 1 - 2 | Next >

[PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
---------------------+------------------------------------------------------
 Reporter:  nicklas  |       Owner:  pramsey      
     Type:  defect   |      Status:  new          
 Priority:  medium   |   Milestone:  postgis 1.5.0
Component:  postgis  |     Version:  1.4.X        
 Keywords:           |  
---------------------+------------------------------------------------------
 Something seems to have happen between postgis 1.3 and 1.4 or postgresql
 8.3 to 8.4.
 I couldn't reproduce on 8.3 1.3, but on 8.4 both with trunk and realeased
 1.4.0

 When running this on the attached dataset:


 select a.the_geom ~= b.the_geom  from test a,test b where a.gid != b.gid
 and a.the_geom ~= b.the_geom;

 I get the little bit absurd answer:[[BR]]
 1537;1553;f[[BR]]
 1553;1537;f[[BR]]


 so the answer from ~= is different when appearing in the select-part then
 in the where-part

 Without the index this doesn't happen. Then they are sorted away by the
 where-part.
 Also if I take away any of the other polygons of the set this fenomena
 dissapears. My conclusion is this indicates that the gist-index is
 involved when built on this particular dataset. The dataset was bigger
 from the beginning but I tried to take away as much as possible still
 preserving the error.

 Something seems to have happen between postgis 1.3 and 1.4 or postgresql
 8.3 to 8.4.
 I couldn't reproduce on 8.3 1.3, but on 8.4 both with trunk and realeased
 1.4.0

 /Nicklas

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by nicklas):

 I have changed the test-table. Now it is more obvious that it by some
 reason only compares the boundingboxes for two particular polygons in the
 where-part but comparing as expected vertex to vertes in the select-part.
 The new testset only contains the result of st_envelope expect for the
 problematic polygons where I have edited the envelope-boxes without
 affecting their bboxes.

 If it, as I think, is a gist-bug, can it still be PostGIS or is it
 PostgreSQL then?

 /Nicklas

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:1>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by robe):

 Well it does appear to be something amiss in our PostGIS 1.4.  I tried
 your example on a PostgreSQL 8.2 windows install. The 1.3 returns no
 results as expected but the 1.4 returns the same absurd results you have
 just described.

 One database running 1.3 and another running 1.4.  I think its our removal
 of RECHECK that is doing it.  So maybe its not a bug in postgis, but our
 removal of RECHECK may be exposing a bug in GIST.

 I haven't tried yet on PostgreSQL 8.4, but on my PostgresSQL 8.2, if I
 create a new spatial database with 1.4, but instead switch the operator
 classes definition to this


 {{{
 CREATE OPERATOR CLASS gist_geometry_ops DEFAULT
    FOR TYPE geometry USING gist AS
    OPERATOR 1  <<,
    OPERATOR 2  &<,
    OPERATOR 3  &&,
    OPERATOR 4  &>,
    OPERATOR 5  >>,
    OPERATOR 6  ~= RECHECK,
    OPERATOR 7  ~,
    OPERATOR 8  @,
    OPERATOR 9  &<|,
    OPERATOR 10  <<|,
    OPERATOR 11  |>>,
    OPERATOR 12  |&>,
    FUNCTION 1  lwgeom_gist_consistent(internal, geometry, integer),
    FUNCTION 2  lwgeom_gist_union(bytea, internal),
    FUNCTION 3  lwgeom_gist_compress(internal),
    FUNCTION 4  lwgeom_gist_decompress(internal),
    FUNCTION 5  lwgeom_gist_penalty(internal, internal, internal),
    FUNCTION 6  lwgeom_gist_picksplit(internal, internal),
    FUNCTION 7  lwgeom_gist_same(box2d, box2d, internal)
 }}}

 Then the problem goes away.

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:2>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by robe):

 Okay looking at our 1.3.7SVN exhibits the same problem.  I see in the
 1.3.7 we took out RECHECK.  I ran 1.3.7 on my 8.3 windows install and it
 exhibits the same problem.
 The comment says

 --
 -- Create opclass index bindings for PG>83
 -- (No RECHECK since this is now handled as part of the GiST Access
 methods)
 --

 So maybe its not really handled or not handled right.  Though my 8.3 dev
 install is old 8.3.1 (which one are you running Nicklas?).  I was going to
 upgrade to the latest to see if it fixes the issue.

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:3>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by nicklas):

 I have tried:
 8.3.7 with postgis 1.3.5 wich gives the expected result, returning nothing

 Then I have tried
 8.4.1 with postgis 1.4.0 and my spike, both giving the strange result with
 returning two rows.
 It is difficult to investigate what is happening since the fenomen
 dissapears at once you take away any of the other polygons. It must be
 something with the way the index is built with this specific dataset. I
 guess it makes this a quite mean bug since it can hide wrong answers among
 many correct answers.
 how to see how the index is built in this case?

 /Nicklas

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:4>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by robe):

 It sounds similar to the bug we had a while ago where the bboxes were not
 being regenerated, though that was a GIST bug fixed in 8.3.5.  I suspect
 this one is tooa gist bug too.

 I also tried with 8.3.7 (and if I remove the RECHECK (basically running
 with a 1.3.7)), it behaves badly like the 1.4.0.  So its nothing different
 in our codebase -- just that RECHECK that is camouflaging what I think to
 be a gist bug.  I'm not even quite clear what RECHECK does.  Mark or Paul
 -- can you explain that.  I'm concerned this is serious that may bite us
 in other unpredictable ways with the more common &&.

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:5>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by mcayland):

 Yeah sorry. I've been half-following this but haven't really had any spare
 time to pick this up. Things should be back to normal now, so I'm happy to
 dig into this over the next week to find out what's actually happening.


 ATB,

 Mark.

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:6>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by robe):

 Wait a minute.  ~= is supposed to be an exact geometry matcher (it is the
 true geometry equality operator), how can you possibly not have that set
 to not RECHECK.  Of course it is wrong.

 I think we need to put RECHECK back into the 1.3.7 and 1.4.* though that
 annoyingly requires a dump restore for people to fix.

 Nick -- sorry I didn't look at the other issues you mentioned -- there
 might be something else going on -- but definitely not having RECHECK on
 ~= seems wrong to me.

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:7>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by mcayland):

 No, this is wrong as all indexable operators (which is all of the ones in
 the gist_geometry_ops class) only work on the bounding boxes of the
 geometries - remember that && is only a bounding box overlap. So ~= should
 return true if the bounding boxes are equal, regardless of whether or not
 the geometries are the same.


 ATB,

 Mark.

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:8>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by nicklas):

 Not according to the manual Mark[[BR]]

 http://www.postgis.org/documentation/manual-
 svn/ST_Geometry_Same.html[[BR]]

 And the thing here is that ~= operator gives different answer in the
 where-part and the select-part.

 /Nicklas

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:9>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by robe):

 Mark,

 I disagree with you on this.  It has always been that ~= is an exact
 geometry operator.  I have always used it as such.  the = operator is the
 equality operator.  Our documentation has always said that ~= is true
 geometry equality operator -- its the only one of the operators that does
 not work on just bounding box there it is probably the only one that
 requires a recheck.

 I refer you to the docs -- see how in the index -- the ~= explicitly says
 geometry while the others say bounding box.

 http://www.postgis.org/documentation/manual-svn/ch07.html#Operators
 http://www.postgis.org/documentation/manual-svn/ST_Geometry_Same.html

 It is the ONLY operator that works against the geometry -- which makes it
 a bit different from the others.

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:10>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by robe):

 I meant to say = is the bounding box equality operator which makes that
 terribly confusing and makes for that wonderful weird but fast behavior of
 our group bys, DISTINCT, order bys etc.

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:11>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by mcayland):

 Intuitively this just seems plain wrong - all of the operators apart from
 this one just slice the index, so why is this one the exception? I would
 say this is a bug in the original behaviour. If anyone wants to compare
 geometry equality then they can use ST_Equals() or even create _ST prefix
 wrapper SQL functions which is what we have done for everything else.


 ATB,

 Mark.

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:12>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by robe):

 I agree with you, but not sure its worthwhile to remove the RECHECK for
 this. There are a couple of problems with using ST_Equals and
 ST_OrderEquals which I am sure Kevin and I have brought up before -- and
 may be in bug list somewhere.

 The ST_Equals doesn't use a spatial index.  Yes we should consider this a
 bug

 CREATE OR REPLACE FUNCTION st_equals(geometry, geometry)
   RETURNS boolean AS
 '$libdir/postgis-1.5', 'geomequals'
   LANGUAGE 'c' IMMUTABLE STRICT
   COST 1;

 I personally never use ST_Equals when speed is a concern because of that
 reason or without an &&.  I think we might actually have this in somewhere
 as bug that Kevin posted.


 And that ain't really the same thing anyway.  ST_Equals doesn't care about
 directionality and uses intersection matrix (so really a spatial equality
 so to speak) so is not a true geometry equality operator where as
 st_geometry_same is closer to true geometric equality.

 It is more equivalent to ST_OrderingEquals which hmm although it appears
 to use a spatial index (the ordering is sometimes wrong I think so its
 slower than using ~=).  It should just be using the explicit
 ST_Geometry_Same function (which shouldn't have an ST in front of it BTW)
 :).

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:13>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by robe):

 Here is the ST_OrderingEquals definition -- note that it too might be
 broken (without the recheck) if its inlined


 CREATE OR REPLACE FUNCTION st_orderingequals(geometry, geometry)
   RETURNS boolean AS
 $BODY$
         SELECT $1 && $2 AND $1 ~= $2
         $BODY$
   LANGUAGE 'sql' IMMUTABLE STRICT

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:14>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by robe):

 I just thought of something. Note that I feel all these changes are so
 breaking in what people (granted possibly a minority of people are used
 to), that it should wait till 2.0.

 The = operator uses a btree index not a GIST index (and I think it has to
 because of some sort of requirement that is baked into the PostgreSQL
 behavior for dealing with DISTINCT, GROUPING, ORDER etc.,

 so the only equality operator we have that uses a gist index is ~=.  Now I
 suppose you could leave the recheck out and change the ST_OrderingEquals
 to be

 $1 ~= $2 AND _ST_OrderingEquals($1,$2)

 ST_Equals -- then ST_Equals could use

 $1 ~= $2 AND _ST_Equals($1,$2)

 (Right now note ST_Equals would have to use && which is much less
 efficient than a bounding box = because we have no bounding box = that
 uses GIST index) and we can't use ~= because well ST_Equals does not imply
 true geometry equality though would have a requirement that the bounding
 boxes are equal.

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:15>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by kneufeld):

 Mark, I agree that intuitively this does seem wrong.  We currently don't
 have an operator that tests just for bbox equality in gist_geometry_ops.
 ~= does seem to fit bill.  I too think this is a bug in the original
 behaviour.

 I like the idea to change ~= to be just bbox equality and change ST_Equals
 and ST_OrderingEquals appropriately as Regina suggested. (Yea, bbox
 equality that uses gist indexes!)

 Also, I agree that this a behavioural change and will have to wait till
 2.0.  I for one use ~= (currently meaning exact geometry equality) a lot.

 Regina, on the topic of equality, doesn't the definition of
 [http://trac.osgeo.org/postgis/browser/trunk/postgis/sqlmm.sql.in.c#L151
 ST_OrderingEquals] have a redundent index lookup in there?  the && could
 probably be removed (at least until 2.0 when the def of ~= may change).
 And it looks like
 [http://trac.osgeo.org/postgis/browser/trunk/postgis/postgis.sql.in.c#L4529
 ST_Equals] doesn't use any indexes.  I was expecting to see "SELECT $1 &&
 $2 AND _ST_Equals($1, $2)".

 So, does this mean we need to put the RECHECK back in for
 -- Kevin

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:16>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.5.0
 Component:  postgis  |     Version:  1.4.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by kneufeld):

 oops, posted too soon.

 So, does this mean we need to put the RECHECK back in for ~= in 1.4.1 to
 fix the bug?

 -- Kevin

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:17>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.3.7
 Component:  postgis  |     Version:  1.3.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Changes (by robe):

  * version:  1.4.X => 1.3.X
  * milestone:  postgis 1.5.0 => postgis 1.3.7

Comment:

 I would say so and definitely put it back for 1.3.7SVN before 1.3 people
 are screwed.
 I don't think there is a way to do this without forcing everyone to dump
 reload or reindex.  I experimented with sneaking it in by dropping cascade
 and rebuilding my indexes (but I guess there is some other stuff besides
 index that a drop cascade does since when I tried to build my index, it
 crashed :().

 Anyway people who upgraded there db from 1.3 to 1.4 without a dump restore
 are probably not affected.  Just new installs I suspect.

 Luckily I have a feeling Kevin, that you and I are in a minority of the
 people who use this operator or really know what it does.  So we can patch
 the ST_OrderingEquals so its not affected and that will alleviate further
 damage for those where the drop operator class is not an option.

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:18>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel

Re: [PostGIS] #253: Gist causes wrong result from ~=

by PostGIS-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#253: Gist causes wrong result from ~=
----------------------+-----------------------------------------------------
  Reporter:  nicklas  |       Owner:  pramsey      
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.3.7
 Component:  postgis  |     Version:  1.3.X        
Resolution:           |    Keywords:              
----------------------+-----------------------------------------------------
Comment (by mcayland):

 Yeah, I think between the 3 of us we've roughly agreed on what needs to be
 done. Regina, we never actually took RECHECK out of 1.3 branch (and I
 don't think we should) so I would suggest putting the milestone back to
 1.4.1.

 Note we still haven't come to a concensus yet on how we should handle SQL-
 level upgrades. This is going to become more important as it seems we need
 this for 1.4.1 so we need to make a decision on this reasonably soon.


 ATB,

 Mark.

--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/253#comment:19>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS
_______________________________________________
postgis-devel mailing list
postgis-devel@...
http://postgis.refractions.net/mailman/listinfo/postgis-devel
< Prev | 1 - 2 | Next >