[RFC]: m4 update

View: New views
3 Messages — Rating Filter:   Alert me  

[RFC]: m4 update

by Roman Divacky :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

hi

I made a patch that updates our in-tree m4 to the version from OpenBSD.
Their version contains some gnu extensions and generally is modernized
and rewritten.

The patch (you have to in src/usr.bin/m4 for it to apply):


        http://vlakno.cz/~rdivacky/m4.patch


I added their ohash* implementation to the m4 subdir as it uses it. I
am not sure this is the correct way but it works for now.

So the question is - do we want this at all? If so, is this the way we
want it?

I am open to all comments, thank you!

roman


attachment0 (203 bytes) Download Attachment

Re: [RFC]: m4 update

by Bjoern A. Zeeb :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Thu, 29 Oct 2009, Roman Divacky wrote:

> hi
>
> I made a patch that updates our in-tree m4 to the version from OpenBSD.
> Their version contains some gnu extensions and generally is modernized
> and rewritten.
>
> The patch (you have to in src/usr.bin/m4 for it to apply):
>
>
> http://vlakno.cz/~rdivacky/m4.patch
>
>
> I added their ohash* implementation to the m4 subdir as it uses it. I
> am not sure this is the correct way but it works for now.
>
> So the question is - do we want this at all? If so, is this the way we
> want it?
>
> I am open to all comments, thank you!

The only comment I have at this point is that this is a huge update to
a somewhat fragile tool.  It'll need a lot of testing before it should
be comitted this way;  not sure how many ports use this rather than gm4
or if they could be switched over after that.  I'd at least ask portmgr
for an exp run.

/bz

--
Bjoern A. Zeeb         It will not break if you know what you are doing.
_______________________________________________
freebsd-current@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@..."

Re: [RFC]: m4 update

by Roman Divacky :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, Oct 30, 2009 at 10:25:34AM +0000, Bjoern A. Zeeb wrote:

> On Thu, 29 Oct 2009, Roman Divacky wrote:
>
> >hi
> >
> >I made a patch that updates our in-tree m4 to the version from OpenBSD.
> >Their version contains some gnu extensions and generally is modernized
> >and rewritten.
> >
> >The patch (you have to in src/usr.bin/m4 for it to apply):
> >
> >
> > http://vlakno.cz/~rdivacky/m4.patch
> >
> >
> >I added their ohash* implementation to the m4 subdir as it uses it. I
> >am not sure this is the correct way but it works for now.
> >
> >So the question is - do we want this at all? If so, is this the way we
> >want it?
> >
> >I am open to all comments, thank you!
>
> The only comment I have at this point is that this is a huge update to
> a somewhat fragile tool.  It'll need a lot of testing before it should
> be comitted this way;  not sure how many ports use this rather than gm4
> or if they could be switched over after that.  I'd at least ask portmgr
> for an exp run.

yes.. I already have one exp ports build queued for unzip enabling. I also
kind of hoped that people would test this patch if I announce it ;)

fwiw - netbsd and openbsd use this version of m4
_______________________________________________
freebsd-current@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@..."