|
View:
New views
11 Messages
—
Rating Filter:
Alert me
|
|
|
[RFC] localechooser: template changesThe existing templates for the four main questions in localechooser all
have problems: they cause Lintian warnings and don't really help the user with what he's doing. Below a proposed patch to improve them. The patch also includes the changes needed because of #552560 ("locale selection incomplete"). Test images (i386) this time that use the new templates and include the change for #552560 (use expert mode!) are available at: http://people.debian.org/~fjp/tmp/d-i/madduck/ Cheers, FJP commit 330cff17ef17481bc98d8b80656f12984017e10a Author: Frans Pop <fjp@...> Date: Sun Nov 1 17:19:40 2009 +0100 Update templates diff --git a/packages/localechooser/debian/localechooser.templates-in b/packages/localechooser/debian/localechooser.templates-in index c8203fb..75a8353 100644 --- a/packages/localechooser/debian/localechooser.templates-in +++ b/packages/localechooser/debian/localechooser.templates-in @@ -11,9 +11,8 @@ Template: debian-installer/locale Type: select Choices: ${LOCALELIST} # :sl2: -_Description: Choose a locale: - Based on your language and country choices, the following locale - parameters are supported. +_Description: System locale: + Select the default locale for the installed system. Template: debian-installer/fallbacklocale Type: select @@ -49,9 +48,9 @@ Choices-C: ${CODES} Choices: ${NAMES_EN} Choices-en.UTF-8: ${NAMES_BOTH} Default: en -Description: Choose a language: - Please choose the language used for the installation process. This - language will be the default language for the final system. +Description: Language: + Choose the language to be used for the installation process. The selected + language will also be the default language for the installed system. Template: localechooser/translation/none-yet Type: note @@ -141,16 +140,25 @@ Type: select # :sl1: __Choices: ${SHORTLIST}, other # :sl1: -_Description: Choose a country, territory or area: - Based on your language, you are probably located in one of these countries - or regions. +_Description: Country, territory or area: + Select the country where you live. The selection will be used for example to + select a default locale and time zone. + . + Choose "other" if your country is not listed. Template: localechooser/supported-locales Type: multiselect Choices: ${LOCALELIST} # :sl2: -_Description: Choose other locales to be supported: - You may choose additional locales to be installed from this list. +_Description: Additional locales: + A locale determines character encoding and contains information on e.g. + currency, date format and alphabetical sort order. Based on the selected + language and country, the default locale selected for the installed system + is '${LOCALE}'. + . + If you wish to use a different default or to also have other locales available, + you may choose additional locales to be installed. If you are unsure it is + best to simply stick with the default. # This template does not really belong in localechooser, but it is probably # the best place for it. It is used to display the language currently being diff --git a/packages/localechooser/mktemplates.continents b/packages/localechooser/mktemplates.continents index 4023f58..992b019 100755 --- a/packages/localechooser/mktemplates.continents +++ b/packages/localechooser/mktemplates.continents @@ -100,6 +100,9 @@ foreach my $region (@known_regions) { print TOUT "#flag:partial\n"; print TOUT "__Choices: ", join(", ", @countries), "\n"; print TOUT "_Description: ", gettext("Choose a country, territory or area:"), "\n"; + print TOUT " ", gettext("Select the country where you live. The selection will be used for example to select a default locale and time zone."), "\n"; + print TOUT " .\n"; + print TOUT " ", gettext("Choose \"other\" if your country is not listed."), "\n"; print TOUT "\n"; } else { print STDERR "I: skipping region $region: no associated countries in $regionmap\n"; @@ -111,8 +114,8 @@ print TOUT "Template: localechooser/continentlist\n"; print TOUT "Type: select\n"; print TOUT "#flag:partial\n"; print TOUT "__Choices: ", join(", ", @regions), "\n"; -print TOUT "_Description: ", gettext("Choose a continent or region:"), "\n"; -print TOUT " ", gettext("The continent or region in which the desired country is located."), "\n"; +print TOUT "_Description: ", gettext("Continent or region:"), "\n"; +print TOUT " ", gettext("Select the continent or region in which the country where you live is located."), "\n"; close(TOUT) || warn; -- To UNSUBSCRIBE, email to debian-boot-REQUEST@... with a subject of "unsubscribe". Trouble? Contact listmaster@... |
|
|
Re: [RFC] localechooser: template changesQuoting Frans Pop (elendil@...):
> The existing templates for the four main questions in localechooser all > have problems: they cause Lintian warnings and don't really help the > user with what he's doing. Thanks for working on this. It was on my TODO list for a while as I found quite strange to enfore some style improvements in many packages through Smith reviews...and omit to "correct" thos I use in D-I..:) > --- a/packages/localechooser/debian/localechooser.templates-in > +++ b/packages/localechooser/debian/localechooser.templates-in > @@ -11,9 +11,8 @@ Template: debian-installer/locale > Type: select > Choices: ${LOCALELIST} > # :sl2: > -_Description: Choose a locale: > - Based on your language and country choices, the following locale > - parameters are supported. > +_Description: System locale: > + Select the default locale for the installed system. push in dle reviews (avoid imperative form). Apart from that, fine by me. > > Template: debian-installer/fallbacklocale > Type: select > @@ -49,9 +48,9 @@ Choices-C: ${CODES} > Choices: ${NAMES_EN} > Choices-en.UTF-8: ${NAMES_BOTH} > Default: en > -Description: Choose a language: > - Please choose the language used for the installation process. This > - language will be the default language for the final system. > +Description: Language: > + Choose the language to be used for the installation process. The selected > + language will also be the default language for the installed system. > > Template: localechooser/translation/none-yet > Type: note > @@ -141,16 +140,25 @@ Type: select > # :sl1: > __Choices: ${SHORTLIST}, other > # :sl1: > -_Description: Choose a country, territory or area: > - Based on your language, you are probably located in one of these countries > - or regions. > +_Description: Country, territory or area: > + Select the country where you live. The selection will be used for example to > + select a default locale and time zone. > + . > + Choose "other" if your country is not listed. that the user installing the system is the one "owning" the machine, which is not well suited in all cases. Also, the user might be living somewhere but installing the machine elsewhere. Of course, what matters here is probably more the place where the machine is living..:-) The former template had the same "problem" of course. Please select the country where the installed system is used. The selection will set the default locale and time zone. Choose "other" to get the full list of countries. > Template: localechooser/supported-locales > Type: multiselect > Choices: ${LOCALELIST} > # :sl2: > -_Description: Choose other locales to be supported: > - You may choose additional locales to be installed from this list. > +_Description: Additional locales: > + A locale determines character encoding and contains information on e.g. > + currency, date format and alphabetical sort order. Based on the selected > + language and country, the default locale selected for the installed system > + is '${LOCALE}'. > + . > + If you wish to use a different default or to also have other locales available, > + you may choose additional locales to be installed. If you are unsure it is > + best to simply stick with the default. of course polluted by Latin) that "latin" abbreviations such as "e.g." are not highly wished in English. "such as" would then be recommended. Apart from that, everything is fine, except maybe the length of the two paragrpahs, that takes a lot of spaces and leaves few romm for the list on 80x25 systems. > --- a/packages/localechooser/mktemplates.continents > +++ b/packages/localechooser/mktemplates.continents > @@ -100,6 +100,9 @@ foreach my $region (@known_regions) { > print TOUT "#flag:partial\n"; > print TOUT "__Choices: ", join(", ", @countries), "\n"; > print TOUT "_Description: ", gettext("Choose a country, territory or area:"), "\n"; > + print TOUT " ", gettext("Select the country where you live. The selection will be used for example to select a default locale and time zone."), "\n"; > + print TOUT " .\n"; > + print TOUT " ", gettext("Choose \"other\" if your country is not listed."), "\n"; > print TOUT "\n"; > } else { > print STDERR "I: skipping region $region: no associated countries in $regionmap\n"; > @@ -111,8 +114,8 @@ print TOUT "Template: localechooser/continentlist\n"; > print TOUT "Type: select\n"; > print TOUT "#flag:partial\n"; > print TOUT "__Choices: ", join(", ", @regions), "\n"; > -print TOUT "_Description: ", gettext("Choose a continent or region:"), "\n"; > -print TOUT " ", gettext("The continent or region in which the desired country is located."), "\n"; > +print TOUT "_Description: ", gettext("Continent or region:"), "\n"; > +print TOUT " ", gettext("Select the continent or region in which the country where you live is located."), "\n"; "Please select the continent or region in which the country this system is used is located." |
|
|
Re: [RFC] localechooser: template changesOn Monday 02 November 2009, Christian Perrier wrote:
> > --- a/packages/localechooser/debian/localechooser.templates-in > > +++ b/packages/localechooser/debian/localechooser.templates-in > > @@ -11,9 +11,8 @@ Template: debian-installer/locale > > Type: select > > Choices: ${LOCALELIST} > > # :sl2: > > -_Description: Choose a locale: > > - Based on your language and country choices, the following locale > > - parameters are supported. > > +_Description: System locale: > > + Select the default locale for the installed system. > > I'd just recommend "Please select" which is the style we generally > push in dle reviews (avoid imperative form). Using the imperative form is wrong in the *short* description (which was the problem in the old version), but IMO in a lot of cases it's fine for the *extended* description. I did not add the "please"s on purpose, basically because they've started to annoy me. For the extended description we should distinguish between text that is a *request* and text that provides *instruction*. In the first case adding "please" is fine (even needed), in the second case it's IMO redundant. Example of a a request is "Please check that your CD is inserted correctly." Without "please" there is a clear difference in the tone (it becomes a command instead of a request). Making it a request instead of a command is partly needed because it's far from certain that the problem is in how the CD is inserted. This template is an example of providing instruction, so we can do without. > > Template: localechooser/translation/none-yet > > Type: note > > @@ -141,16 +140,25 @@ Type: select > > # :sl1: > > __Choices: ${SHORTLIST}, other > > # :sl1: > > -_Description: Choose a country, territory or area: > > - Based on your language, you are probably located in one of these > > countries - or regions. > > +_Description: Country, territory or area: > > + Select the country where you live. The selection will be used for > > example to + select a default locale and time zone. > > + . > > + Choose "other" if your country is not listed. > > That one is more tricky. Using "where you live" implicitely assumes > that the user installing the system is the one "owning" the machine, > which is not well suited in all cases. Also, the user might be living > somewhere but installing the machine elsewhere. Of course, what > matters here is probably more the place where the machine is > living..:-) > > The former template had the same "problem" of course. > > Please select the country where the installed system is used. This is a lot less clear. My proposed text is fine for the general case where users install their own systems. People installing systems for others will know how to "translate" the request for their situation (and even then the selection will be "the country where they live" in >95% of cases). Saying "the country where you live" is IMO the simplest way to avoid the reports from users that they did not get the correct time zone. It is also more logical for the situation where a user installs a portable system while on holiday. And remember that portable systems can and will be "used" all over the world. > The selection will set the default locale and time zone. The selected country does more than that, so the "for example" is IMO necessary. > Choose "other" to get the full list of countries. Problem is that you don't get a "full list of countries", you get a list of continents... > > Template: localechooser/supported-locales > > Type: multiselect > > Choices: ${LOCALELIST} > > # :sl2: > > -_Description: Choose other locales to be supported: > > - You may choose additional locales to be installed from this list. > > +_Description: Additional locales: > > + A locale determines character encoding and contains information on > > e.g. + currency, date format and alphabetical sort order. Based on the > > selected + language and country, the default locale selected for the > > installed system + is '${LOCALE}'. > > + . > > + If you wish to use a different default or to also have other locales > > available, + you may choose additional locales to be installed. If you > > are unsure it is + best to simply stick with the default. > > After discussions in dle, we concluded (mostly others than me as I'm > of course polluted by Latin) that "latin" abbreviations such as "e.g." > are not highly wished in English. "such as" would then be recommended. Fixed. > Apart from that, everything is fine, except maybe the length of the > two paragrpahs, that takes a lot of spaces and leaves few romm for the > list on 80x25 systems. It still leaves 10 lines for selection with vga=normal, so it's not that bad. But I've now moved the first sentence to a separate "help" template; this saves 2 lines, so now 12 lines are displayed. > > @@ -111,8 +114,8 @@ print TOUT "Template: > > localechooser/continentlist\n"; print TOUT "Type: select\n"; > > print TOUT "#flag:partial\n"; > > print TOUT "__Choices: ", join(", ", @regions), "\n"; > > -print TOUT "_Description: ", gettext("Choose a continent or > > region:"), "\n"; -print TOUT " ", gettext("The continent or region in > > which the desired country is located."), "\n"; +print TOUT > > "_Description: ", gettext("Continent or region:"), "\n"; +print TOUT " > > ", gettext("Select the continent or region in which the country where > > you live is located."), "\n"; > > "Please select the continent or region in which the country this > system is used is located." See above. -- To UNSUBSCRIBE, email to debian-boot-REQUEST@... with a subject of "unsubscribe". Trouble? Contact listmaster@... |
|
|
Re: [RFC] localechooser: template changesQuoting Frans Pop (elendil@...):
> > I'd just recommend "Please select" which is the style we generally > > push in dle reviews (avoid imperative form). > > Using the imperative form is wrong in the *short* description (which was > the problem in the old version), but IMO in a lot of cases it's fine for > the *extended* description. I did not add the "please"s on purpose, > basically because they've started to annoy me. > > For the extended description we should distinguish between text that is a > *request* and text that provides *instruction*. In the first case > adding "please" is fine (even needed), in the second case it's IMO > redundant. the French translation... > > > Template: localechooser/translation/none-yet > > > Type: note > > > @@ -141,16 +140,25 @@ Type: select > > > # :sl1: > > > __Choices: ${SHORTLIST}, other > > > # :sl1: > > > -_Description: Choose a country, territory or area: > > > - Based on your language, you are probably located in one of these > > > countries - or regions. > > > +_Description: Country, territory or area: > > > + Select the country where you live. The selection will be used for > > > example to + select a default locale and time zone. > > > + . > > > + Choose "other" if your country is not listed. > > > > That one is more tricky. Using "where you live" implicitely assumes > > that the user installing the system is the one "owning" the machine, > > which is not well suited in all cases. Also, the user might be living > > somewhere but installing the machine elsewhere. Of course, what > > matters here is probably more the place where the machine is > > living..:-) > > > > The former template had the same "problem" of course. > > > > Please select the country where the installed system is used. > > This is a lot less clear. > > My proposed text is fine for the general case where users install their own > systems. People installing systems for others will know how to "translate" > the request for their situation (and even then the selection will be "the > country where they live" in >95% of cases). > > Saying "the country where you live" is IMO the simplest way to avoid the > reports from users that they did not get the correct time zone. > > It is also more logical for the situation where a user installs a portable > system while on holiday. And remember that portable systems can and will > be "used" all over the world. (please) Select the country that will be used, for example, to select a default locale and time zone. That would avoid the ambiguous "where you live". > > Choose "other" to get the full list of countries. > > Problem is that you don't get a "full list of countries", you get a list of > continents... We could turn this to "Choose "other" to choos a country that is not listed here." > > Apart from that, everything is fine, except maybe the length of the > > two paragrpahs, that takes a lot of spaces and leaves few romm for the > > list on 80x25 systems. > > It still leaves 10 lines for selection with vga=normal, so it's not that > bad. But I've now moved the first sentence to a separate "help" template; > this saves 2 lines, so now 12 lines are displayed. Yes. We should by the way make better use of these help templates, indeed. Could be useful for our country selection detailed instructions. |
|
|
Re: [RFC] localechooser: template changesOn Tuesday 03 November 2009, Christian Perrier wrote:
> Quoting Frans Pop (elendil@...): > > > I'd just recommend "Please select" which is the style we generally > > > push in dle reviews (avoid imperative form). > > > > Using the imperative form is wrong in the *short* description (which > > was the problem in the old version), but IMO in a lot of cases it's > > fine for the *extended* description. I did not add the "please"s on > > purpose, basically because they've started to annoy me. > > > > For the extended description we should distinguish between text that > > is a *request* and text that provides *instruction*. In the first case > > adding "please" is fine (even needed), in the second case it's IMO > > redundant. > > Matter of taste (and overall consistency). IMO it's not just a matter of taste and I'll have one more attempt to explain my reasoning to you. Especially because I do fully agree about consistency and because this also affects po-debconf templates. I've been uncomfortable with "please" for quite some time, but could never really say why, so I did not make a point of it. For the Dutch translation we mostly just drop them. Any attempt to preserve it makes the translation sound artificial. The problem is that when you read individual templates adding "please" seems completely logical. And that is how you have been working with them intensively over the past few years. But templates do not stand on their own, especially not in the installer. IMO the installer can be seen as a set of instructions to reach a certain goal, much like a cookery-book or an assembly instruction for an Ikea table. Cookery-books don't go "Please melt the butter over a moderate flame. When the butter is melted, please add the flour and a table spoon of sugar. Please stir until you get smooth paste.". And that's exactly the effect you get if you add "please" in every D-I dialog. You have to consider the whole, not just the individual templates. As I've mentioned in my previous post, "please" is fine for requests (which we also have in D-I and po-debconf templates), but it's not needed in what's essentially a series of instructions. > I'll use the polite form in the French translation... Of course you should do what's correct in French for your translation; different languages have different requirements. But it may be worth checking a few French cookery-books ;-) Also, it's *not* about "using the polite form" (at least not for English), but at using the most appropriate form for the nature of the product. Feel free to take this discussion to d-english. > What about: > > (please) Select the country that will be used, for example, to select > a default locale and time zone. IMO that's a lot less clear for users. An instruction does not have to be literally correct in 100% of cases. It has to convey the correct intention. > We could turn this to "Choose "other" to choos a country that is not > listed here." Something like that would be possible but depends on what we do with the country questions. > > > Apart from that, everything is fine, except maybe the length of the > > > two paragrpahs, that takes a lot of spaces and leaves few romm for > > > the list on 80x25 systems. > > > > It still leaves 10 lines for selection with vga=normal, so it's not > > that bad. But I've now moved the first sentence to a separate "help" > > template; this saves 2 lines, so now 12 lines are displayed. > > Yes. We should by the way make better use of these help templates, > indeed. Agreed. > Could be useful for our country selection detailed instructions. Maybe, but we should guard against: - moving essential or basic instructions into help dialogs; - being too verbose in help dialogs for udebs included in initrds (because of size considerations); localechooser already is relatively big because of all the error dialogs. In the case of country selection it is IMO essential to make users installing their own system (people not doing multiple installations, but using the installer only once) pick the correct choice on the first attempt in order to avoid incorrect locales (especially at default priority) or time zones (especially as that is not even displayed at default priority for countries that only have one). "The country where you live" is IMO by far the simplest, clearest and most intuitive description to achieve that. Cheers, FJP -- To UNSUBSCRIBE, email to debian-boot-REQUEST@... with a subject of "unsubscribe". Trouble? Contact listmaster@... |
|
|
Re: [RFC] localechooser: template changesQuoting Frans Pop (elendil@...):
> I've been uncomfortable with "please" for quite some time, but could never > really say why, so I did not make a point of it. For the Dutch translation > we mostly just drop them. Any attempt to preserve it makes the translation > sound artificial. You have some point here (particularly the cookbook example: nice catch) Actually, this began as an effort to drop the abuse of imperative form (I always learned that imperative is...what it's name says, a way to point something as "to be done" and "madatory"...up to "this is an order"). I agree that this turned out into an abuse of "please". I'll try to avoid exxagerating at this in English reviews (you should show up sometimes on dle, I'm sure you would help improving things even more). > > I'll use the polite form in the French translation... > > Of course you should do what's correct in French for your translation; > different languages have different requirements. But it may be worth > checking a few French cookery-books ;-) Most actually use the infinitive form (which is possible in French but not in English). But, yeah, I agree that very few (if any) use what I call the "polite" form as "Veuillez faire fondre le beurre". > > (please) Select the country that will be used, for example, to select > > a default locale and time zone. > > IMO that's a lot less clear for users. An instruction does not have to be > literally correct in 100% of cases. It has to convey the correct > intention. I'll apparently have hard times convincing you on that matter... > In the case of country selection it is IMO essential to make users > installing their own system (people not doing multiple installations, but > using the installer only once) pick the correct choice on the first > attempt in order to avoid incorrect locales (especially at default > priority) or time zones (especially as that is not even displayed at > default priority for countries that only have one). > > "The country where you live" is IMO by far the simplest, clearest and most > intuitive description to achieve that. Well, OK, I'm not entirely convinced but I apparently can't propose a sufficiently correct alternative to makje you change your mind..:-) Could we summarize on what we have now? |
|
|
Re: [RFC] localechooser: template changesOn Wednesday 04 November 2009, Christian Perrier wrote:
> Well, OK, I'm not entirely convinced but I apparently can't propose a > sufficiently correct alternative to makje you change your mind..:-) Here's an alternative I could live with: The country selected here will be used for example to select a default locale and time zone. Normally this should be the country where you live. Country, territory or area: This still covers my arguments for using "country where you live", but leaves more open that there can be reasons to choose a different country. -- To UNSUBSCRIBE, email to debian-boot-REQUEST@... with a subject of "unsubscribe". Trouble? Contact listmaster@... |
|
|
Re: [RFC] localechooser: template changesQuoting Frans Pop (elendil@...):
> On Wednesday 04 November 2009, Christian Perrier wrote: > > Well, OK, I'm not entirely convinced but I apparently can't propose a > > sufficiently correct alternative to makje you change your mind..:-) > > Here's an alternative I could live with: That's fine by me. Thanks! |
|
|
Re: [RFC] localechooser: template changesOn Monday 02 November 2009, Frans Pop wrote:
> The existing templates for the four main questions in localechooser all > have problems: they cause Lintian warnings and don't really help the > user with what he's doing. > > Below a proposed patch to improve them. The patch also includes the > changes needed because of #552560 ("locale selection incomplete"). Here's a new overview of the proposed changes. One problem with the discussion so far has been that it's very hard to reach consensus if only two people participate, so please have a look and comment! These are some of our most essential dialogs. Cheers, FJP Language selection ================== OLD Please choose the language used for the installation process. This language will be the default language for the final system. Choose a language: -------------- NEW Choose the language to be used for the installation process. The selected language will also be the default language for the installed system. Language: Country selection ================= OLD (shortlists) Based on your language, you are probably located in one of these countries or regions. Choose a country, territory or area: OLD (continent dialog) The continent or region in which the desired country is located. Choose a continent or region: OLD (per-continent lists) Choose a country, territory or area: -------------- NEW (same for shortlists and per-continent lists) The country selected here will be used for example to select a default locale and time zone. Normally this should be the country where you live. Choose "other" if your country is not listed. *) Country, territory or area: NEW (continent dialog) Select the continent or region in which your country is located. Continent or region: *) Should we for shortlists maybe change this line to: This is a shortlist based on the language you selected. Choose "other" if your country is not listed. Locale selection ================ Note: the order of the questions has changed because of #552560. OLD (default locale) Based on your language and country choices, the following locale parameters are supported. Choose a locale: OLD (extra locales) You may choose additional locales to be installed from this list. Choose other locales to be supported: -------------- NEW (extra locales; has help) Based on the selected language and country, the default locale selected for the installed system is '${LOCALE}'. If you wish to use a different default or to also have other locales available, you may choose additional locales to be installed. If you are unsure it is best to just use the selected default. Additional locales: NEW (default locale; has help) *) Select the default locale for the installed system. System locale: NEW (locale help dialog) locale A locale determines character encoding and contains information on for example currency, date format and alphabetical sort order. *) Only displayed if additional locales were selected. -- To UNSUBSCRIBE, email to debian-boot-REQUEST@... with a subject of "unsubscribe". Trouble? Contact listmaster@... |
|
|
Re: [RFC] localechooser: template changesQuoting Frans Pop (elendil@...):
> Here's a new overview of the proposed changes. Everything is fine by me, including: > NEW (same for shortlists and per-continent lists) > The country selected here will be used for example to select a default > locale and time zone. Normally this should be the country where you live. > > Choose "other" if your country is not listed. *) > > Country, territory or area: .../... > *) Should we for shortlists maybe change this line to: > This is a shortlist based on the language you selected. Choose "other" > if your country is not listed. I like that last option. That makes one additional string but it's certainly worth it. |
|
|
Re: [RFC] localechooser: template changesOn Friday 06 November 2009, Christian Perrier wrote:
> Quoting Frans Pop (elendil@...): > > *) Should we for shortlists maybe change this line to: > > This is a shortlist based on the language you selected. Choose > > "other" if your country is not listed. > > I like that last option. That makes one additional string but it's > certainly worth it. Committed, including that change. Let's see if we still have translators. -- To UNSUBSCRIBE, email to debian-boot-REQUEST@... with a subject of "unsubscribe". Trouble? Contact listmaster@... |
| Free embeddable forum powered by Nabble | Forum Help |