[RFC/PATCH v2 1/2] Add java.io.IOError class

[Pekka Enberg-4]

This patch adds a missing IOError class to GNU Classpath that was introduced in
Java 1.6.

2012-01-05  Pekka Enberg  <penberg@...>

        * java/io/IOError:
        Add new class.

Signed-off-by: Pekka Enberg <penberg@...>
---
 java/io/IOError.java |   54 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 54 insertions(+), 0 deletions(-)
 create mode 100644 java/io/IOError.java

diff --git a/java/io/IOError.java b/java/io/IOError.java
new file mode 100644
index 0000000..176b4bd
--- /dev/null
+++ b/java/io/IOError.java
@@ -0,0 +1,54 @@
+/* IOError.java -- Throw when unrecoverable I/O error happens.
+   Copyright (C) 2012  Free Software Foundation, Inc.
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+02110-1301 USA.
+
+Linking this library statically or dynamically with other modules is
+making a combined work based on this library.  Thus, the terms and
+conditions of the GNU General Public License cover the whole
+combination.
+
+As a special exception, the copyright holders of this library give you
+permission to link this library with independent modules to produce an
+executable, regardless of the license terms of these independent
+modules, and to copy and distribute the resulting executable under
+terms of your choice, provided that you also meet, for each linked
+independent module, the terms and conditions of the license of that
+module.  An independent module is a module which is not derived from
+or based on this library.  If you modify this library, you may extend
+this exception to your version of the library, but you are not
+obligated to do so.  If you do not wish to do so, delete this
+exception statement from your version. */
+
+
+package java.io;
+
+/**
+ * Throw when unrecoverable I/O error happens.
+ *
+ * @since 1.6
+ */
+public class IOError extends Error
+{
+  private static final long serialVersionUID = 67100927991680413L;
+
+  public IOError(Throwable cause)
+  {
+    super(cause);
+  }
+}
--
1.7.4.1

[Pekka Enberg-4]

This patch implements java/io/Console and adds a console() method to
java/lang/System. The implementation is lame but it works reasonably well.

2012-01-05  Pekka Enberg  <penberg@...>

        * java/io/Console:
        Add new class.

        * java/lang/System.java:
        (console): Add new Java 1.6 API method.

        * vm/reference/java/io/VMConsole:
        Add new class.

Signed-off-by: Pekka Enberg <penberg@...>
---
 java/io/Console.java                |  126 +++++++++++++++++++++++++++++++++++
 java/lang/System.java               |   11 +++-
 vm/reference/java/io/VMConsole.java |   44 ++++++++++++
 3 files changed, 180 insertions(+), 1 deletions(-)
 create mode 100644 java/io/Console.java
 create mode 100644 vm/reference/java/io/VMConsole.java

diff --git a/java/io/Console.java b/java/io/Console.java
new file mode 100644
index 0000000..53dca64
--- /dev/null
+++ b/java/io/Console.java
@@ -0,0 +1,126 @@
+/* Console.java -- A character-based console device
+   Copyright (C) 2012  Free Software Foundation, Inc.
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+02110-1301 USA.
+
+Linking this library statically or dynamically with other modules is
+making a combined work based on this library.  Thus, the terms and
+conditions of the GNU General Public License cover the whole
+combination.
+
+As a special exception, the copyright holders of this library give you
+permission to link this library with independent modules to produce an
+executable, regardless of the license terms of these independent
+modules, and to copy and distribute the resulting executable under
+terms of your choice, provided that you also meet, for each linked
+independent module, the terms and conditions of the license of that
+module.  An independent module is a module which is not derived from
+or based on this library.  If you modify this library, you may extend
+this exception to your version of the library, but you are not
+obligated to do so.  If you do not wish to do so, delete this
+exception statement from your version. */
+
+
+package java.io;
+
+/**
+ * @since 1.6
+ */
+public final class Console implements Flushable
+{
+  private static Console console = new Console();
+
+  public static Console console()
+  {
+    return console;
+  }
+
+  private Console()
+  {
+  }
+
+  public PrintWriter writer()
+  {
+    return new PrintWriter(new OutputStreamWriter(System.out));
+  }
+
+  public Reader reader()
+  {
+    return new InputStreamReader(System.in);
+  }
+
+  public Console format(String fmt, Object... args)
+  {
+    System.out.printf(fmt, args);
+
+    return this;
+  }
+
+  public Console printf(String fmt, Object... args)
+  {
+    return format(fmt, args);
+  }
+
+  public String readLine(String fmt, Object... args)
+  {
+    format(fmt, args);
+    return readLine();
+  }
+
+  public String readLine()
+  {
+    String result = null;
+    try
+      {
+        result = new BufferedReader(reader()).readLine();
+      }
+    catch (IOException e)
+      {
+        throw new IOError(e);
+      }
+    return result;
+  }
+
+  public char[] readPassword(String fmt, Object... args)
+  {
+    format(fmt, args);
+    return readPassword();
+  }
+
+  public char[] readPassword()
+  {
+    String s;
+
+    VMConsole.echo(false);
+
+    s = readLine();
+
+    VMConsole.echo(true);
+
+    if (s == null)
+      {
+        return null;
+      }
+    return s.toCharArray();
+  }
+
+  public void flush() throws IOException
+  {
+    System.out.flush();
+  }
+}
diff --git a/java/lang/System.java b/java/lang/System.java
index 39d6da2..51b3259 100644
--- a/java/lang/System.java
+++ b/java/lang/System.java
@@ -1,5 +1,5 @@
 /* System.java -- useful methods to interface with the system
-   Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2007
+   Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2007, 2012
    Free Software Foundation, Inc.
 
 This file is part of GNU Classpath.
@@ -45,6 +45,7 @@ import gnu.classpath.VMStackWalker;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.PrintStream;
+import java.io.Console;
 import java.nio.channels.Channel;
 import java.nio.channels.spi.SelectorProvider;
 import java.util.AbstractCollection;
@@ -703,6 +704,14 @@ public final class System
     return SelectorProvider.provider().inheritedChannel();
   }
 
+  /*
+   * @since 1.6
+   */
+  public static Console console()
+  {
+    return Console.console();
+  }
+
   /**
    * This is a specialised <code>Collection</code>, providing
    * the necessary provisions for the collections used by the
diff --git a/vm/reference/java/io/VMConsole.java b/vm/reference/java/io/VMConsole.java
new file mode 100644
index 0000000..5b8919b
--- /dev/null
+++ b/vm/reference/java/io/VMConsole.java
@@ -0,0 +1,44 @@
+/* VMConsole.java -- helper for java.io.Console
+   Copyright (C) 2012  Free Software Foundation, Inc.
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+02110-1301 USA.
+
+Linking this library statically or dynamically with other modules is
+making a combined work based on this library.  Thus, the terms and
+conditions of the GNU General Public License cover the whole
+combination.
+
+As a special exception, the copyright holders of this library give you
+permission to link this library with independent modules to produce an
+executable, regardless of the license terms of these independent
+modules, and to copy and distribute the resulting executable under
+terms of your choice, provided that you also meet, for each linked
+independent module, the terms and conditions of the license of that
+module.  An independent module is a module which is not derived from
+or based on this library.  If you modify this library, you may extend
+this exception to your version of the library, but you are not
+obligated to do so.  If you do not wish to do so, delete this
+exception statement from your version. */
+
+
+package java.io;
+
+public final class VMConsole
+{
+  static native boolean echo(boolean on);
+}
--
1.7.4.1

[Andrew Hughes-7]

On 21:14 Thu 05 Jan     , Pekka Enberg wrote:

> This patch implements java/io/Console and adds a console() method to
> java/lang/System. The implementation is lame but it works reasonably well.
>
> 2012-01-05  Pekka Enberg  <penberg@...>
>
> * java/io/Console:
> Add new class.
>
> * java/lang/System.java:
> (console): Add new Java 1.6 API method.
>
> * vm/reference/java/io/VMConsole:
> Add new class.
>

It would be good if the methods had documentation, but that could be added in a separate
patch.

The main thing is you say it works 'reasonably well' but I don't see how when there
is no implementation of the native method 'echo'.  I doubt this is too VM-dependent.
More OS dependent.  Look at the stuff under native/jni/java-io.

--
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07