|

»

[Tickets #8413] malformed img tag causes images to be shown regardless of html_image_replacement setting

View: New views

6 Messages — Rating Filter: Alert me

	[Tickets #8413] malformed img tag causes images to be shown regardless of html_image_replacement setting by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8413 ------------------------------------------------------------------------------ Ticket \| 8413 Created By \| Michael Rubinsky <mrubinsk@...> Summary \| malformed img tag causes images to be shown regardless \| of html_image_replacement setting Queue \| IMP Version \| 4.3.4 Type \| Bug State \| Unconfirmed Priority \| 1. Low Milestone \| Patch \| Owners \| ------------------------------------------------------------------------------ Michael Rubinsky <mrubinsk@...> (2009-07-06 11:15) wrote: Choosing to block images in HTML mail, and receiving an email with the following will still render the image: <img src=http://www.google.pt/intl/en_com/images/logo_plain.png onload=`" src=`> -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8413] Re: malformed img tag causes images to be shown regardless of html_image_replacement setting by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8413 ------------------------------------------------------------------------------ Ticket \| 8413 Updated By \| Michael Slusarz <slusarz@...> Summary \| malformed img tag causes images to be shown regardless \| of html_image_replacement setting Queue \| IMP Version \| 4.3.4 Type \| Bug State \| Unconfirmed Priority \| 1. Low Milestone \| Patch \| Owners \| ------------------------------------------------------------------------------ Michael Slusarz <slusarz@...> (2009-07-06 13:43) wrote: I can't reproduce this, with either IMP 5 or IMP 4.3.5. In IMP 5, nothing is displayed. In IMP 4.3.5, I get the option to unblock images, but nothing is displayed by default. -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8413] Re: malformed img tag causes images to be shown regardless of html_image_replacement setting by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8413 ------------------------------------------------------------------------------ Ticket \| 8413 Updated By \| Chuck Hagenbuch <chuck@...> Summary \| malformed img tag causes images to be shown regardless \| of html_image_replacement setting Queue \| IMP Version \| 4.3.4 Type \| Bug State \| Unconfirmed Priority \| 1. Low Milestone \| Patch \| Owners \| ------------------------------------------------------------------------------ Chuck Hagenbuch <chuck@...> (2009-07-06 14:27) wrote: The image shows up for me. Using Safari - not sure if this might be browser-specific. -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8413] Re: malformed img tag causes images to be shown regardless of html_image_replacement setting by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8413 ------------------------------------------------------------------------------ Ticket \| 8413 Updated By \| Chuck Hagenbuch <chuck@...> Summary \| malformed img tag causes images to be shown regardless \| of html_image_replacement setting Queue \| IMP Version \| 4.3.4 Type \| Bug State \| Unconfirmed Priority \| 1. Low Milestone \| Patch \| Owners \| +New Attachment \| Teste (Imagem Google).eml ------------------------------------------------------------------------------ Chuck Hagenbuch <chuck@...> (2009-07-06 15:04) wrote: adding an example message -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8413] Re: malformed img tag causes images to be shown regardless of html_image_replacement setting by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8413 ------------------------------------------------------------------------------ Ticket \| 8413 Updated By \| acmpires@... Summary \| malformed img tag causes images to be shown regardless \| of html_image_replacement setting Queue \| IMP Version \| 4.3.4 Type \| Bug State \| Unconfirmed Priority \| 1. Low Milestone \| Patch \| Owners \| ------------------------------------------------------------------------------ Chuck Hagenbuch <chuck@...> (2009-07-06 15:04) wrote: adding an example message -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8413] Re: malformed img tag causes images to be shown regardless of html_image_replacement setting by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8413 ------------------------------------------------------------------------------ Ticket \| 8413 Updated By \| Michael Slusarz <slusarz@...> Summary \| malformed img tag causes images to be shown regardless \| of html_image_replacement setting Queue \| IMP Version \| 4.3.4 Type \| Bug -State \| Unconfirmed +State \| Resolved Priority \| 1. Low Milestone \| Patch \| -Owners \| +Owners \| Michael Slusarz ------------------------------------------------------------------------------ Michael Slusarz <slusarz@...> (2009-07-07 18:17) wrote: That img tag had 2 src attributes, and had the info in the first attribute. The regex was too greedy and was ignoring all text in the tag between '<img' and the final 'src=' text. Solution was to make that part of the regex ungreedy. An img tag with multiple src attributes that doesn't contain a correct source link in the first src attribute will not display the image at all, even after clicking on Display these images. But absent a super-complex preg regex, this is acceptable (after all, the message is broken). Running tidy fixed this issue without the need for the regexp change. -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...