|

»

[Tickets #8482] Session not cleaned up in alarms.php

View: New views

17 Messages — Rating Filter: Alert me

	[Tickets #8482] Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Created By \| js-horde@... Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Bug State \| Unconfirmed Priority \| 1. Low Milestone \| Patch \| 1 Owners \| +New Attachment \| horde_alarms.php.patch ------------------------------------------------------------------------------ js-horde@... (2009-08-05 13:12) wrote: Perhaps I have my sessions mis-configured, but with current alarms.php, I get sessions left around every time my alarms.php cron job runs. The attached patch nukes the session when finished. -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| js-horde@... Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Bug State \| Unconfirmed Priority \| 1. Low Milestone \| Patch \| 1 Owners \| ------------------------------------------------------------------------------ js-horde@... (2009-08-05 13:12) wrote: Perhaps I have my sessions mis-configured, but with current alarms.php, I get sessions left around every time my alarms.php cron job runs. The attached patch nukes the session when finished. -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| Jan Schneider <jan@...> Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Bug -State \| Unconfirmed +State \| Feedback Priority \| 1. Low Milestone \| Patch \| 1 Owners \| ------------------------------------------------------------------------------ Jan Schneider <jan@...> (2009-08-06 06:18) wrote: That looks like a nice addition. Why do you call clearAuth(), if the session is destroyed anyway? -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| js-horde@... Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Bug State \| Feedback Priority \| 1. Low Milestone \| Patch \| 1 Owners \| ------------------------------------------------------------------------------ js-horde@... (2009-08-12 10:27) wrote: > That looks like a nice addition. Why do you call clearAuth(), if the > session is destroyed anyway? Only because that's what login.php does for a logout. I just copied what was done there. -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| Jan Schneider <jan@...> Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD -Type \| Bug +Type \| Enhancement -State \| Feedback +State \| Assigned -Priority \| 1. Low +Priority \| 1. Low Milestone \| Patch \| Owners \| ------------------------------------------------------------------------------ -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| Jan Schneider <jan@...> Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Enhancement -State \| Assigned +State \| Resolved Priority \| 1. Low Milestone \| Patch \| -Owners \| +Owners \| Jan Schneider ------------------------------------------------------------------------------ Jan Schneider <jan@...> (2009-08-14 18:02) wrote: Instead I went ahead and added this as a shutdown method in the CLI constructor, so that the session is destroyed at the end of any CLI script. -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| js-horde@... Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Enhancement State \| Resolved Priority \| 1. Low Milestone \| Patch \| Owners \| Jan Schneider ------------------------------------------------------------------------------ js-horde@... (2009-08-17 14:11) wrote: > Instead I went ahead and added this as a shutdown method in the CLI > constructor, so that the session is destroyed at the end of any > CLI script. I tested that, and it seems to work for me. I'm glad you came up with a more comprehensive approach. Thanks for fixing it. -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| Chuck Hagenbuch <chuck@...> Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Enhancement -State \| Resolved +State \| Feedback Priority \| 1. Low Milestone \| Patch \| Owners \| Jan Schneider ------------------------------------------------------------------------------ Chuck Hagenbuch <chuck@...> (2009-11-11 23:02) wrote: Hmm... as pointed out somewhat by #8701, maybe a better solution would be to avoid opening a session from the CLI in the first place? -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| Jan Schneider <jan@...> Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Enhancement State \| Feedback Priority \| 1. Low Milestone \| Patch \| Owners \| Jan Schneider ------------------------------------------------------------------------------ Jan Schneider <jan@...> (2009-11-12 02:50) wrote: The session is not started in CLI, and there's no guarantee that it will be loaded before base.php. Beside that, it wouldn't help with bug 8482, because backend.php wouldn't even work without a session. -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| Michael Rubinsky <mrubinsk@...> Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Enhancement State \| Feedback Priority \| 1. Low Milestone \| Patch \| Owners \| Jan Schneider ------------------------------------------------------------------------------ Michael Rubinsky <mrubinsk@...> (2009-11-12 09:55) wrote: > The session is not started in CLI, Maybe for the CLI scripts that do require a session, then the script itself should be responsible for destroying it. At a minimum, we should allow passing an option to CLI to indicate we don't want to kill any active sessions. -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| Chuck Hagenbuch <chuck@...> Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Enhancement State \| Feedback Priority \| 1. Low Milestone \| Patch \| -Owners \| Jan Schneider +Owners \| Horde Developers, Jan Schneider ------------------------------------------------------------------------------ Chuck Hagenbuch <chuck@...> (2009-11-12 10:02) wrote: What actually requires a functional session when running from the CLI? I was thinking that we should just not call session_start() if php_sapi_name() == 'cli'. -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| Michael Rubinsky <mrubinsk@...> Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Enhancement State \| Feedback Priority \| 1. Low Milestone \| Patch \| Owners \| Horde Developers, Jan Schneider ------------------------------------------------------------------------------ Michael Rubinsky <mrubinsk@...> (2009-11-12 10:21) wrote: > What actually requires a functional session when running from the CLI? Doesn't Auth use $_SESSION? So any script that needs an actual user name to be set in auth would require a session, right? -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| Jan Schneider <jan@...> Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Enhancement State \| Feedback Priority \| 1. Low Milestone \| Patch \| Owners \| Horde Developers, Jan Schneider ------------------------------------------------------------------------------ Jan Schneider <jan@...> (2009-11-12 10:31) wrote: >> What actually requires a functional session when running from the >> CLI? > > Doesn't Auth use $_SESSION? So any script that needs an actual user > name to be set in auth would require a session, right? Yes, and the superglobal is only created when a session is started. -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| Michael Rubinsky <mrubinsk@...> Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Enhancement State \| Feedback Priority \| 1. Low Milestone \| Patch \| Owners \| Horde Developers, Jan Schneider ------------------------------------------------------------------------------ Michael Rubinsky <mrubinsk@...> (2009-11-12 20:51) wrote: What about only registering the shutdown function if we are running from the cli? i.e.: - register_shutdown_function(array($this, '_shutdown')); + if ($this->_console) { + register_shutdown_function(array($this, '_shutdown')); + } } -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| Chuck Hagenbuch <chuck@...> Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Enhancement State \| Feedback Priority \| 1. Low Milestone \| Patch \| Owners \| Horde Developers, Jan Schneider ------------------------------------------------------------------------------ Chuck Hagenbuch <chuck@...> (2009-11-13 00:00) wrote: That looks reasonable to me... -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| Jan Schneider <jan@...> Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Enhancement -State \| Feedback +State \| Assigned Priority \| 1. Low Milestone \| Patch \| -Owners \| Horde Developers, Jan Schneider +Owners \| Michael Rubinsky ------------------------------------------------------------------------------ Jan Schneider <jan@...> (2009-11-13 03:42) wrote: Good idea. -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...
	[Tickets #8482] Re: Session not cleaned up in alarms.php by bugs-14 :: Rate this Message: Reply (Restricted by the Administrator) \| Reply to Author \| View Threaded \| Show Only this Message DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED. Ticket URL: http://bugs.horde.org/ticket/8482 ------------------------------------------------------------------------------ Ticket \| 8482 Updated By \| Michael Rubinsky <mrubinsk@...> Summary \| Session not cleaned up in alarms.php Queue \| Horde Base Version \| HEAD Type \| Enhancement -State \| Assigned +State \| Resolved Priority \| 1. Low Milestone \| Patch \| Owners \| Michael Rubinsky ------------------------------------------------------------------------------ -- You are subscribed to this list as: lists@... To unsubscribe, mail: bugs-unsubscribe@...