[Uim-bugs] [Bug 15853] New: uim-toolbar-qt's "Preference" doesn't work

http://bugs.freedesktop.org/show_bug.cgi?id=15853

           Summary: uim-toolbar-qt's "Preference" doesn't work
           Product: UIM
           Version: unspecified
          Platform: x86 (IA32)
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: helper: toolbar
        AssignedTo: uim-bugs@...
        ReportedBy: utuhiro78@...


$ rm -rf ~/.uim.d/
$ uim-toolbar-qt

Press the "Preference" button on toolbar.
It causes some errors.
//
Error: in scm_symbol_value: unbound variable: custom-group-label
libuim: [fatal] an unhandled error raised from Scheme interpreter
libuim: All functionality has been disabled to save user application data.
libuim: [fatal] an unhandled error raised from Scheme interpreter
libuim: [fatal] All functionality has been disabled to save user application
data.
//

Does it work for you?
(uim-toolbar-gtk works fine.)

uim version: 1.5.0
uim build options:
   --with-m17nlib \
   --without-canna \
   --without-prime \
   --without-scim \
   --without-eb \
   --with-qt4-immodule \
   --with-qt-immodule \
   --with-qt \
   --enable-dict \
   --disable-warnings-into-error


--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
uim-bugs mailing list
uim-bugs@...
http://lists.freedesktop.org/mailman/listinfo/uim-bugs

http://bugs.freedesktop.org/show_bug.cgi?id=15853


Etsushi Kato <ek.kato@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|helper: toolbar             |helper: pref
         OS/Version|Linux (All)                 |All
           Platform|x86 (IA32)                  |All
            Summary|uim-toolbar-qt's            |uim-pref-qt doesn't work
                   |"Preference" doesn't work   |when
                   |                            |libquiminputcontextplugin.so
                   |                            |is installed




--- Comment #1 from Etsushi Kato <ek.kato@...>  2008-05-07 22:46:36 PST ---
For some reason, Qt3 plugin instance for input methods is created (and
destroyed) twice, and this seems to cause a problem for uim-pref-qt when
libquiminputcontextplugin.so is installed.

One way to avoid such conditions is to count initialization of libuim (see
attached patch).  Or just remove uim_quit() in UimInputContextPlugin::uimQuit()
as a workaround.


--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
uim-bugs mailing list
uim-bugs@...
http://lists.freedesktop.org/mailman/listinfo/uim-bugs

http://bugs.freedesktop.org/show_bug.cgi?id=15853





--- Comment #2 from Etsushi Kato <ek.kato@...>  2008-05-07 22:48:37 PST ---
Created an attachment (id=16424)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=16424)
Patch to count libuim's initialization


--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
uim-bugs mailing list
uim-bugs@...
http://lists.freedesktop.org/mailman/listinfo/uim-bugs

http://bugs.freedesktop.org/show_bug.cgi?id=15853





--- Comment #3 from UTUMI Hirosi <utuhiro78@...>  2008-05-08 04:04:45 PST ---
uim-pref-qt works fine now.
Thank you so much.

I think this bug is critical.
Someone might want uim-1.5.1.


--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
uim-bugs mailing list
uim-bugs@...
http://lists.freedesktop.org/mailman/listinfo/uim-bugs

http://bugs.freedesktop.org/show_bug.cgi?id=15853





--- Comment #4 from YamaKen <yamaken@...>  2008-05-08 05:44:32 PST ---
Thank you for the report and the patch.

But IMHO, uim_init() and uim_quit() is not the place to be added the
workaround, at least in 1.5 branch since it alters the API specification of the
functions. Please resolve the problem in bridge layer.

See [Anthy-dev 1563] and following messages for further consideration. We had
discussed such behavior once, and reverted to the current specification.


--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
uim-bugs mailing list
uim-bugs@...
http://lists.freedesktop.org/mailman/listinfo/uim-bugs

http://bugs.freedesktop.org/show_bug.cgi?id=15853





--- Comment #5 from Etsushi Kato <ek.kato@...>  2008-05-08 06:30:03 PST ---
(In reply to comment #4)
> But IMHO, uim_init() and uim_quit() is not the place to be added the
> workaround, at least in 1.5 branch since it alters the API specification of the
> functions. Please resolve the problem in bridge layer.
>
> See [Anthy-dev 1563] and following messages for further consideration. We had
> discussed such behavior once, and reverted to the current specification.

Hehe, you already considered and tried this init count three years ago, which I
don't remember well ;)

Do you think just removing uim_quit() in UimInputContextPlugin::uimQuit() is OK
for now?  (Personally, I don't prefer this workaround because it must be a bug
in immodule patch for Qt3).


--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
uim-bugs mailing list
uim-bugs@...
http://lists.freedesktop.org/mailman/listinfo/uim-bugs

http://bugs.freedesktop.org/show_bug.cgi?id=15853





--- Comment #6 from YamaKen <yamaken@...>  2008-05-09 21:46:39 PST ---
> Do you think just removing uim_quit() in UimInputContextPlugin::uimQuit() is OK
> for now?  (Personally, I don't prefer this workaround because it must be a bug
> in immodule patch for Qt3).
Though I don't know sufficient information about the Qt plugin management on
immodule arena, the init count workaround is better than just removing
uim_quit() since it is more proper and can behave as expected by Qt on any
situations we don't know. I don't prefer introducing future possibility of
another problem by removing uim_quit().

What about writing a wrapper functions for uim_init() and uim_quit() contaning
the your init count workaround in the bridges and replace the uim_init/quit
call with them?


--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
uim-bugs mailing list
uim-bugs@...
http://lists.freedesktop.org/mailman/listinfo/uim-bugs

http://bugs.freedesktop.org/show_bug.cgi?id=15853


Etsushi Kato <ek.kato@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16424|0                           |1
        is obsolete|                            |




--- Comment #7 from Etsushi Kato <ek.kato@...>  2008-05-11 19:30:54 PST ---
Created an attachment (id=16476)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=16476)
init wrapper patch


--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
uim-bugs mailing list
uim-bugs@...
http://lists.freedesktop.org/mailman/listinfo/uim-bugs

http://bugs.freedesktop.org/show_bug.cgi?id=15853





--- Comment #8 from Etsushi Kato <ek.kato@...>  2008-05-11 19:33:12 PST ---
(In reply to comment #6)

> What about writing a wrapper functions for uim_init() and uim_quit() contaning
> the your init count workaround in the bridges and replace the uim_init/quit
> call with them?

That should be fine.  I'll commit the above new patch if there is no further
discussion.


--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
uim-bugs mailing list
uim-bugs@...
http://lists.freedesktop.org/mailman/listinfo/uim-bugs

http://bugs.freedesktop.org/show_bug.cgi?id=15853





--- Comment #9 from Etsushi Kato <ek.kato@...>  2008-05-12 02:49:07 PST ---
(In reply to comment #8)
> That should be fine.  I'll commit the above new patch if there is no further
> discussion.


I noticed that the using convenience library cannot share a variable among
plugins (uim_panelapplet.so and libquiminputcontextplugin.so in this case).  So
I'll commit the patch except for kde applet part.  In addition, I'm going to
remove unused reloadUim() in immodule.


--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
uim-bugs mailing list
uim-bugs@...
http://lists.freedesktop.org/mailman/listinfo/uim-bugs

http://bugs.freedesktop.org/show_bug.cgi?id=15853


Etsushi Kato <ek.kato@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16476|0                           |1
        is obsolete|                            |




--- Comment #10 from Etsushi Kato <ek.kato@...>  2008-05-12 02:50:01 PST ---
Created an attachment (id=16479)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=16479)
Revised patch


--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
uim-bugs mailing list
uim-bugs@...
http://lists.freedesktop.org/mailman/listinfo/uim-bugs

http://bugs.freedesktop.org/show_bug.cgi?id=15853





--- Comment #11 from YamaKen <yamaken@...>  2008-05-12 05:09:47 PST ---
What about these names?

uim_counted_init()
uim_counted_quit()
uim_force_quit_regardless_of_count()

The 3rd name is bit too long, but I think it'll be used rare and so such
descriptive name is preferable/acceptable.


--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
uim-bugs mailing list
uim-bugs@...
http://lists.freedesktop.org/mailman/listinfo/uim-bugs

http://bugs.freedesktop.org/show_bug.cgi?id=15853


Etsushi Kato <ek.kato@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #12 from Etsushi Kato <ek.kato@...>  2008-05-12 08:27:29 PST ---
(In reply to comment #11)
> What about these names?
>
> uim_counted_init()
> uim_counted_quit()
> uim_force_quit_regardless_of_count()

OK.  I've committed this with putting the convenience library into uim/.


--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
uim-bugs mailing list
uim-bugs@...
http://lists.freedesktop.org/mailman/listinfo/uim-bugs