|

Free Desktop - uim-bugs

[Uim-bugs] [Bug 24123] New: Add a Qt4 toolbar for uim

View: New views

8 Messages — Rating Filter: Alert me

	[Uim-bugs] [Bug 24123] New: Add a Qt4 toolbar for uim by Bugzilla from bugzilla-daemon@freedesktop.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message http://bugs.freedesktop.org/show_bug.cgi?id=24123 Summary: Add a Qt4 toolbar for uim Product: UIM Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: medium Component: helper: toolbar AssignedTo: uim-bugs@... ReportedBy: nogu.dev@... Created an attachment (id=29816) --> (http://bugs.freedesktop.org/attachment.cgi?id=29816) patch to add uim-toolbar-qt4, uim-chardict-qt4, uim-im-switcher-qt4 and uim-pref-qt4 Currently, a Qt4 toolbar for uim doesn't exist. I ported uim-*-qt from Qt3 to Qt4. Uim developers, would you review my patch? autogen.sh \| 29 configure.ac \| 47 + qt4/Makefile.am \| 2 qt4/chardict/Makefile.am \| 36 qt4/chardict/bushu.t \| 172 ++++ qt4/chardict/bushuviewwidget.cpp \| 180 ++++ qt4/chardict/bushuviewwidget.h \| 72 + qt4/chardict/chargridview.cpp \| 197 ++++ qt4/chardict/chargridview.h \| 68 + qt4/chardict/kseparator.cpp \| 112 ++ qt4/chardict/kseparator.h \| 85 ++ qt4/chardict/po/LINGUAS \| 1 qt4/chardict/po/Makevars \| 48 + qt4/chardict/po/POTFILES.in \| 3 qt4/chardict/po/ja.po \| 545 +++++++++++++ qt4/chardict/po/remove-potcdate.sin \| 19 qt4/chardict/po/uim-chardict-qt.pot \| 545 +++++++++++++ qt4/chardict/qt4.cpp \| 221 +++++ qt4/chardict/qt4.h \| 101 ++ qt4/chardict/qtgettext.h \| 60 + qt4/chardict/uim-chardict-qt4.pro.in \| 31 qt4/chardict/unicodeviewwidget.cpp \| 293 +++++++ qt4/chardict/unicodeviewwidget.h \| 75 + qt4/pref/Makefile.am \| 25 qt4/pref/customwidgets.cpp \| 1267 +++++++++++++++++++++++++++++++ qt4/pref/customwidgets.h \| 299 +++++++ qt4/pref/keyeditformbase.ui \| 119 ++ qt4/pref/kseparator.cpp \| 112 ++ qt4/pref/kseparator.h \| 85 ++ qt4/pref/olisteditformbase.ui \| 115 ++ qt4/pref/qt4.cpp \| 704 +++++++++++++++++ qt4/pref/qt4.h \| 141 +++ qt4/pref/uim-pref-qt4.pro.in \| 23 qt4/qtgettext.h \| 65 + qt4/switcher/Makefile.am \| 22 qt4/switcher/qt4.cpp \| 297 +++++++ qt4/switcher/qt4.h \| 81 + qt4/switcher/uim-im-switcher-qt4.pro.in \| 22 qt4/toolbar/Makefile.am \| 25 qt4/toolbar/common-quimhelpertoolbar.cpp \| 300 +++++++ qt4/toolbar/common-quimhelpertoolbar.h \| 100 ++ qt4/toolbar/common-uimstateindicator.cpp \| 312 +++++++ qt4/toolbar/common-uimstateindicator.h \| 125 +++ qt4/toolbar/standalone-qt4.cpp \| 201 ++++ qt4/toolbar/standalone-qt4.h \| 91 ++ qt4/toolbar/uim-toolbar-qt4.pro.in \| 26 46 files changed, 7483 insertions(+), 16 deletions(-) -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ uim-bugs mailing list uim-bugs@... http://lists.freedesktop.org/mailman/listinfo/uim-bugs
	[Uim-bugs] [Bug 24123] Add a Qt4 toolbar for uim by Bugzilla from bugzilla-daemon@freedesktop.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message http://bugs.freedesktop.org/show_bug.cgi?id=24123 Muneyuki Noguchi <nogu.dev@...> changed: What \|Removed \|Added ---------------------------------------------------------------------------- Attachment #29816\|0 \|1 is obsolete\| \| --- Comment #1 from Muneyuki Noguchi <nogu.dev@...> 2009-09-24 14:28:08 PST --- Created an attachment (id=29832) --> (http://bugs.freedesktop.org/attachment.cgi?id=29832) patch v2 -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ uim-bugs mailing list uim-bugs@... http://lists.freedesktop.org/mailman/listinfo/uim-bugs
	[Uim-bugs] [Bug 24123] Add a Qt4 toolbar for uim by Bugzilla from bugzilla-daemon@freedesktop.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message http://bugs.freedesktop.org/show_bug.cgi?id=24123 Etsushi Kato <ek.kato@...> changed: What \|Removed \|Added ---------------------------------------------------------------------------- Status\|NEW \|ASSIGNED --- Comment #2 from Etsushi Kato <ek.kato@...> 2009-09-24 17:47:21 PST --- Thanks for the splendid work. I'll check this and integrate in the weekend. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ uim-bugs mailing list uim-bugs@... http://lists.freedesktop.org/mailman/listinfo/uim-bugs
	[Uim-bugs] [Bug 24123] Add a Qt4 toolbar for uim by Bugzilla from bugzilla-daemon@freedesktop.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message http://bugs.freedesktop.org/show_bug.cgi?id=24123 --- Comment #3 from Muneyuki Noguchi <nogu.dev@...> 2009-09-25 06:19:47 PST --- configure.ac should be changed after the attached patch is applied because the patch doesn't take into consideration $default_toolbar in configure.ac. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ uim-bugs mailing list uim-bugs@... http://lists.freedesktop.org/mailman/listinfo/uim-bugs
	[Uim-bugs] [Bug 24123] Add a Qt4 toolbar for uim by Bugzilla from bugzilla-daemon@freedesktop.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message http://bugs.freedesktop.org/show_bug.cgi?id=24123 --- Comment #4 from Muneyuki Noguchi <nogu.dev@...> 2009-09-25 06:21:07 PST --- Oops, $default_toolkit, not $default_toolbar. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ uim-bugs mailing list uim-bugs@... http://lists.freedesktop.org/mailman/listinfo/uim-bugs
	[Uim-bugs] [Bug 24123] Add a Qt4 toolbar for uim by Bugzilla from bugzilla-daemon@freedesktop.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message http://bugs.freedesktop.org/show_bug.cgi?id=24123 --- Comment #5 from Etsushi Kato <ek.kato@...> 2009-09-27 20:30:18 PST --- Committed the patch v2 for qt4 tools. And I've also added qt4 candwin for uim-xim and default_toolkit handling. Could you confirm this work for you? BTW, toolbar applet of uim for KDE3 is still not ported for qt4/KDE. Do you have any plan or motivation to implement this? Thanks! -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ uim-bugs mailing list uim-bugs@... http://lists.freedesktop.org/mailman/listinfo/uim-bugs
	[Uim-bugs] [Bug 24123] Add a Qt4 toolbar for uim by Bugzilla from bugzilla-daemon@freedesktop.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message http://bugs.freedesktop.org/show_bug.cgi?id=24123 --- Comment #6 from Muneyuki Noguchi <nogu.dev@...> 2009-09-30 14:15:50 PST --- > And I've also added qt4 candwin for > uim-xim and default_toolkit handling. Could you confirm this work for you? It works for me as far as I've tested. > Do you have any plan or motivation to implement this? I'd like to do it, but it may take a few weeks. A couple of comments on qt4/candwin/qt4.cpp: > int len = list.length(); QList::length() was introduced in Qt 4.5. Some distributions ship w/o Qt >= 4.5. OpenSUSE 11.1, for example, uses Qt 4.4. I suggest using QList::count() or QList::size(). Both are same as QList::length() and exist from Qt 4.0. > qDebug( "uim-helper-candwin-qt: activateCand()" ); > qDebug( "uim-helper-candwin-qt: selectCand()" ); > qDebug( "uim-helper-candwin-qt: moveCand()" ); > ... You forgot to change `uim-helper-candwin-qt' in these lines. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ uim-bugs mailing list uim-bugs@... http://lists.freedesktop.org/mailman/listinfo/uim-bugs
	[Uim-bugs] [Bug 24123] Add a Qt4 toolbar for uim by Bugzilla from bugzilla-daemon@freedesktop.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message http://bugs.freedesktop.org/show_bug.cgi?id=24123 Etsushi Kato <ek.kato@...> changed: What \|Removed \|Added ---------------------------------------------------------------------------- Status\|ASSIGNED \|RESOLVED Resolution\| \|FIXED --- Comment #7 from Etsushi Kato <ek.kato@...> 2009-09-30 21:02:50 PST --- (In reply to comment #6) > > Do you have any plan or motivation to implement this? > I'd like to do it, but it may take a few weeks. Great. I'm too unfamiliar with KDE, so it is indeed very helpful. > A couple of comments on qt4/candwin/qt4.cpp: > > > int len = list.length(); > QList::length() was introduced in Qt 4.5. Some distributions ship w/o Qt >= > 4.5. OpenSUSE 11.1, for example, uses Qt 4.4. I suggest using QList::count() or > QList::size(). Both are same as QList::length() and exist from Qt 4.0. > > > qDebug( "uim-helper-candwin-qt: activateCand()" ); > > qDebug( "uim-helper-candwin-qt: selectCand()" ); > > qDebug( "uim-helper-candwin-qt: moveCand()" ); > > ... > You forgot to change `uim-helper-candwin-qt' in these lines. OK, now fixed. I'm going to close this bug. Please file a new bug about the KDE applet when you're ready. Thanks. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ uim-bugs mailing list uim-bugs@... http://lists.freedesktop.org/mailman/listinfo/uim-bugs