[VOTE] Struts 2.0.4 Quality

[Ted Husted]

It is labeled as such now, in the 2.0.5 notes, but I didn't think to
do that before assembing the 2.0.4 distribution. If there are no
objections, I could patch the 2.0.4 release notes to include the same
remark as 2.0.5, and upload new signed copies 2.0.4-all.zip and
2.0.4-docs.zip, before announcing the beta.

-Ted.

On 1/31/07, Don Brown <mrdon@...> wrote:
> I believe we currently have portlet support as "experimental", so it
> shouldn't affect the quality vote.
>
> Don

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Don Brown-2]

+1

Ted Husted wrote:

> It is labeled as such now, in the 2.0.5 notes, but I didn't think to
> do that before assembing the 2.0.4 distribution. If there are no
> objections, I could patch the 2.0.4 release notes to include the same
> remark as 2.0.5, and upload new signed copies 2.0.4-all.zip and
> 2.0.4-docs.zip, before announcing the beta.
>
> -Ted.
>
> On 1/31/07, Don Brown <mrdon@...> wrote:
>> I believe we currently have portlet support as "experimental", so it
>> shouldn't affect the quality vote.
>>
>> Don
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Rene Gielen]

Follow-up for the described issues:
Annotation driven action configuration issue - WW-1695
PrincipalAware issue - WW-1696

Don Brown schrieb:
> I believe we currently have portlet support as "experimental", so it
> shouldn't affect the quality vote.
>

Regarding this along with Ted's remark to fix release notes for 2.0.4 to
declare portlet support as experimental, I change my vote to
[ ] Leave at test build
[ ] Alpha
[x] Beta
[ ] General Availability (GA)

- Rene

> Don
>
> Rene Gielen wrote:
>> Hey guys,
>>
>> a few minutes ago I came to the opinion that we have some major issues
>> with portlet integration, which imo should be fixed before rolling out
>> current build:
>>
>> - Annotation based configuration for actions seems to fail at least in
>> my portlet environment (Liferay 4.2.1), resulting in infinite loop
>> while scanning for action classes in configured packages. Had no time
>> to dig deeper yet, but the issue is reproducible. I'll file an issue.
>>
>> - ServletConfigInterceptor, along with PrincipalAware / PrincipalProxy
>> are not portlet aware. The implementation relies on access to
>> HttpServletRequest, but the Jsr168Dispatcher fails to put the
>> HttpServletRequest into action context (in fact there is a TODO in the
>> code!?!). The other (better: additional) option would be to make
>> PrincipalProxy HttpServletRequest independent, to deliver Principal
>> related information from PorletRequest, if applicable. We should
>> really consider this a major issue, preventing us from considering
>> portlet intergration (and therefore core) "ready for public". I'll
>> file an issue on that, too.
>>
>> For that reason, currently my vote is:
>> >    [x] Leave at test build
>> >    [ ] Alpha
>> >    [ ] Beta
>> >    [ ] General Availability (GA)
>>
>> - Rene
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>

--
Rene Gielen  | http://it-neering.net/
Aachen       | PGP-ID: BECB785A
Germany      | gielen at it-neering.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Ted Husted]

Actually, I was confusing portlet support with the J4 backport
support. We've had portlet labeled experimental all along. Though,
based on the remarks in this thread, I do intend to patch the 2.0.4
notes to label the J4 backup experimental too.

If nothing else comes up tomorrow, I'll do that and post the result of
the vote, and then announce the beta.

-Ted.

On 1/31/07, Ted Husted <husted@...> wrote:

> It is labeled as such now, in the 2.0.5 notes, but I didn't think to
> do that before assembing the 2.0.4 distribution. If there are no
> objections, I could patch the 2.0.4 release notes to include the same
> remark as 2.0.5, and upload new signed copies 2.0.4-all.zip and
> 2.0.4-docs.zip, before announcing the beta.
>
> -Ted.
>
> On 1/31/07, Don Brown <mrdon@...> wrote:
> > I believe we currently have portlet support as "experimental", so it
> > shouldn't affect the quality vote.
> >
> > Don

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...