[WebSVN] Is my SvnWeb effort worth to be merged?

[piotr_tarnowski]

He,

Here is a copy of my correspondence with Dirk regarding some changes
I've made to websvn which I use and now would like to merge with
mainstream. The list of changes is below ('> > > *' bullets).
Should I also attach my version (it's quite big 1.2MB due to included
test repository)?

All the best,
Piotr


Dnia 28-09-2009 o godz. 11:46 Piotr Tarnowski <piotr_tarnowski@...>
napisał(a):

> Dirk,
>
> Dnia 28-09-2009 o godz. 10:34 Dirk Thomas / 4wd media napisał(a):
> > Hi Piotr,
> >
> > > finally I found time to collect my changes for WebSvn. I was really busy
> > > at work this summer.
> >
> > thank you very much for your efforts.
> :)
>
> >
> > > I've attached my version of WebSvn + test repository (I thing test
> > > repository could be included in installation - just for test purposes).
> >
> > Against which version of WebSVN have you done your modifications - trunk?
> > Could you please provide a diff/patch file for your modification
> > (against trunk - not against 2.2.1)?
> This is stated at the end of this mail (quote from my original mail to
> you):
> I've started a year ago patching WebSvn version 1.6 from Debian ...
>
>
> >
> > Since your modifications are quite substantial i am not yet sure how to
> > apply these changes.
> > Commiting all at once seems to be not the best way to go.
> >
> > I will try to take a closer look to the changes and also forward them to
> > Quinn, who did much of the work in the last months.
> > Would it be possible that you provide multiple smaller patches for
> > specific enhancements/fixes since this would make the integration much
> > easier?
> Probably yes but I would need a lot of help and cooperation (as I stated
> previously). Some changes are quite big and require decision for
> direction of websvn development. This is not a simple process of
> providing several patches. this is more like merging when you have to
> decide what to throw away and what to keep. So I imagine this rather as
> cooperative work than provided by me list of patches.
>
> >
> > Could you please send your answer to the dev-mailinglist since then
> > other people would also know about your improvements?
> You mean dev@...? Yes I will made a post.
>
> >
> > Again - thank you for your contribution - some items on the changelog
> > look very useful to me.
> The best way to explore my patches to browse side by side test
> repository which I provided using patched version and trunk. If exact
> nature of my patch (as described with bullets below) is not clear please
> feel free to ask - I will try to explain more detaily.
>
> BTW when preparing test repository I found and error in websvn (at least
> patched by me and 2.2.1) directory of file named "0" (zero) is not
> handled properly, this is edge case in reality but a problem with test
> repository - anyway on my TODO list.
>
> >
> > Dirk
> >
> >
> >  > Changes:
> >  >
> > > * current path and revision is present on every screen and URL (also
> > > directory comparison)
> > > * there is warning while browsing other than current revision
> > > * many cases when after renaming / moving link was lost in websvn was
> > > fixed
> > > * revision details page is current path aware (only changes to curent
> > > path are present) - at the same time "root of changes" link is present
> > > which directs to directory with all changes
> > > * different file contents encodings are supported (this is done by
> > > searching for encoding=XXX pattern at the beginning of file and also
> > > works in diff when encoding was changed)
> > > * file encoding and syntax highlighting can be selected by hand
> > > * dir file/contents | revision details | history | diff - are all "tabs"
> > > * size of file is shown on directory listing
> > > * blame is a mode (switch) for file contents view
> > > * binary files which are supported by browser can be viewed as frame
> > > (nice for images but on windows also works for PowerPoint, Excel, Word,
> > > PDF) - samples are in test repository - really nice
> > > * age is presented "the-old-way" only major scale but full name (like "6
> > > months") - I found this more readable - but this has impact on Polish
> > > transaction, in Polish we have three forms (imagine "1 month", "2
> > > months", "5 monthss" - but rule is more complicated) I added support for
> > > that
> > > * current revision (or the newest) is presented in different color on
> > > directory and blame listing
> > > * path memory for directory and log browsing - path@rev is stored as
> > > cookie and can be used for comparison (with standard websvn you cannot
> > > compare arbitrary files and directories - only the ones which are
> > > displayed on the same view) - this is MAJOR change
> > > * new log (history) browser which better supports long list of changes
> > >   * only current page is loaded by PHP - next one is as link
> > >   * starting path for browsing log entries is preserved in URL
> > >   * log it is proof for move/rename
> > >   * log shows root of changes and name of current file/directory at this
> > > change
> > >   * log filtering (searching) is applied on collecting log entries - this
> > > saves a lot of memory and can be used to search much bigger range of
> > > revisions
> > > * template engine extended with [websvn-test:!variable] (means not)
> > > * template engine extended with [websvn:?variable] (include if variable
> > > is set)
> > > * new template GreyPtr - as much as possible compact, similar to browser
> > > look, it has jira-style action icons appended to paths (I found this the
> > > easiest to use) and supports all features I've implemented
> > > * directory listing and file viewing share URL and decision is made
> > > based on checking (file-or-dir)
> > > * op=diff redirects to op=comp for directory comparison
> > > * most (hope) of my comments are prefixed with PTR
> > > * I also used FIXME 2.2.1 while merging changes from websvn 2.2.1 to
> > > patched by me 1.6 (some are commented out because I was not sure if it
> > > will work with my patches)
> > > * directory comparison has links to every diff file I'bve also included
> > > warning at the buttor of screen - this comparison does not show
> > > everything
> > > * ...
> > > * probably some more - I have to check revision log
> > >
> > > All the best,
> > > Piotr
> > >
> > >
> > >
> > > Dnia 22-06-2009 o godz. 15:10 Dirk Thomas / 4wd media napisał(a):
> > >> Hi Piotr,
> > >>
> > >>> I've started a year ago patching WebSvn version 1.6 from Debian. This
> > >>> version had a lot of bugs, I've also made some improvements (layout,
> > >>> missed links, user interface). When you released 2.1 I've started to
> > >>> merge them trying to take best of both. Now I did my best but do not
> > >>> have time to bring it to single patch result - differences are still
> > >>> there. There are some project decisions which I made not present in
> > >>> official websvn (e.g. file encoding guessing).
> > >>>
> > >>> The question is: are you interested in my work and do you see it worth
> > >>> to spend some time (some yours, some mine) to bring my changes to trunk
> > >>> (probably starting with branch)?
> > >> Of course - any input is welome.
> > >>
> > >>> You probably would ask what exactly changes I made. Of course I can make
> > >>> a list but even more informative could be if I would send to you WebSvn
> > >>> version which I use - to play a little with it.
> > >> If you send me a copy i will take a look.
> > >> But a list of the significant modifications/enhancements/fixes you have
> > >> made would be really helpful, so that i don't miss the interesting parts.
> > >>
> > >>> PS. 2.2 was neither merged, nor compared by me, hope it is not that
> > >>> different.
> > >> WebSVN 2.2 had some important fixes as the usage of peg revision for
> > >> example.
> > >> We will see how different the both variant will be.
> > >>
> > >> Dirk
>
> ----------------------------------------------------
> Wygraj wymarzony skuter!
> Wyznacz najprostszą drogę - docelu.pl - Kliknij:
> http://klik.wp.pl/?adr=http%3A%2F%2Fcorto.www.wp.pl%2Fas%2Fchapman1.html&sid=863

----------------------------------------------------
Dołącz się do Manify!
Wyjdźmy na ulice, w WALCE O TAŃSZE PIWO!
http://klik.wp.pl/?adr=www.zatanisci.pl&sid=856

------------------------------------------------------
http://websvn.tigris.org/ds/viewMessage.do?dsForumId=1547&dsMessageId=2401107

To unsubscribe from this discussion, e-mail: [dev-unsubscribe@...].