[WebSVN] Template - listingurl

[Yokav - Mailing]

Hello,

Why do you have remove this tag from the templates?

There are url tags for everything except for listing.

------------------------------------------------------
http://websvn.tigris.org/ds/viewMessage.do?dsForumId=1547&dsMessageId=2410432

To unsubscribe from this discussion, e-mail: [dev-unsubscribe@...].

[Quinn Taylor]

I'm not sure I fully understand your meaning. I see "listingurl" and  
"listinglink" defined for revision.tmpl, but nowhere else. In fact, I  
just uniformized them with "directoryurl"/"directorylink" in log.php.  
(Speaking of which, those variables weren't documented — I added those  
changes too.)

I think most of the pages wouldn't have a use for a dedicated link to  
jump to a listing — filedetails/blame/diff.php all display files, and  
the path links allow users to jump to any parent directory. I can see  
that it would be nice for comp.php to create path links for the paths  
being compared, though... That's going on my to-do list.

With the patch I just submitted to trunk, is there still a shortcoming?

  - Quinn

On Oct 22, 2009, at 2:18 PM, Yokav wrote:

> Hello,
>
> Why do you have remove this tag from the templates?
>
> There are url tags for everything except for listing.
>
> ------------------------------------------------------
> http://websvn.tigris.org/ds/viewMessage.do?dsForumId=1547&dsMessageId=2410432
>
> To unsubscribe from this discussion, e-mail: [dev-
> unsubscribe@...].

------------------------------------------------------
http://websvn.tigris.org/ds/viewMessage.do?dsForumId=1547&dsMessageId=2410468

To unsubscribe from this discussion, e-mail: [dev-unsubscribe@...].

[Yokav - Mailing]

Yes, I spoke about the listingsurl tag from revision.tmpl which is used
only into this file. I try with the last revision of the svn but it
doesn't work, so I replaced listingsurl by directoryurl and it works
fine. Thanks.

Le 23/10/09 01:26, Quinn Taylor a écrit :

> I'm not sure I fully understand your meaning. I see "listingurl" and
> "listinglink" defined for revision.tmpl, but nowhere else. In fact, I
> just uniformized them with "directoryurl"/"directorylink" in log.php.
> (Speaking of which, those variables weren't documented — I added those
> changes too.)
>
> I think most of the pages wouldn't have a use for a dedicated link to
> jump to a listing — filedetails/blame/diff.php all display files, and
> the path links allow users to jump to any parent directory. I can see
> that it would be nice for comp.php to create path links for the paths
> being compared, though... That's going on my to-do list.
>
> With the patch I just submitted to trunk, is there still a shortcoming?
>
>    - Quinn
>
> On Oct 22, 2009, at 2:18 PM, Yokav wrote:
>
>> Hello,
>>
>> Why do you have remove this tag from the templates?
>>
>> There are url tags for everything except for listing.
>>
>> ------------------------------------------------------
>> http://websvn.tigris.org/ds/viewMessage.do?dsForumId=1547&dsMessageId=2410432
>>
>> To unsubscribe from this discussion, e-mail: [dev-
>> unsubscribe@...].
>
> ------------------------------------------------------
> http://websvn.tigris.org/ds/viewMessage.do?dsForumId=1547&dsMessageId=2410468
>
> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@...].

------------------------------------------------------
http://websvn.tigris.org/ds/viewMessage.do?dsForumId=1547&dsMessageId=2410548

To unsubscribe from this discussion, e-mail: [dev-unsubscribe@...].