http://websvn.tigris.org/issues/show_bug.cgi?id=257 Issue #|257
Summary|Empty password not handled properly
Component|websvn
Version|trunk
Platform|All
OS/Version|All
URL|
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|Subversion
Assigned to|issues@websvn
Reported by|piotr_tarnowski
------- Additional comments from
piotr_tarnowski@... Thu Oct 8 03:54:28 -0700 2009 -------
When repository requests user name but no password generated command is not
correct (path takes place of password).
Index: include/configclass.php
===================================================================
--- include/configclass.php (wersja 446)
+++ include/configclass.php (working copy)
@@ -262,11 +262,9 @@
// {{{ svnParams
function svnParams() {
- if (!empty($this->username)) {
- return " --username ".$this->username." --password ".$this->password." ";
- }
-
- return " ";
+ if(empty($this->username)) return " ";
+ return " --username ".quote($this->username)." --password ".
+ (empty($this->password) ? "''" : quote($this->password))." ";
}
// }}}
------------------------------------------------------
http://websvn.tigris.org/ds/viewMessage.do?dsForumId=2390&dsMessageId=2404902
