[brlcad-tracker] [ brlcad-Patches-3527405 ] Unit test has been written for src/libbu/bitv.c

Patches item #3527405, was opened at 2012-05-16 14:32
Message generated for change (Comment added) made by anrgmrty
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3527405&group_id=105292

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Compilation
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: anuragmurty (anrgmrty)
Assigned to: Nobody/Anonymous (nobody)
Summary: Unit test has been written for src/libbu/bitv.c

Initial Comment:
Unit test for testing of src/libbu/bitv.c has been written with appropriate changes to CMakelists.txt and Makefile.am

----------------------------------------------------------------------

Comment By: anuragmurty (anrgmrty)
Date: 2012-05-23 23:03

Message:
Thanks again d_rossberg. I have changed the variable names, the indentation
and have made the newlines more consistent(2 b/w functions and 1 inside).

----------------------------------------------------------------------

Comment By: Daniel Roßberg (d_rossberg)
Date: 2012-05-23 07:28

Message:
Next you have to follow the
- "1) Indentation whitespace" and
- "4) Names"
section in HACKING (see e.g. your PASS variable).

Furthermore, you should look for consistent newlines.  E.g. you have
sometimes 1 and sometimes 2 newlines between the functions.  Sometimes no
newline and then 1 or 2 inside a function.  Look at the other BRL-CAD
sources.  Use 1 newline inside the functions to structure and 2 newlines
between functions.

----------------------------------------------------------------------

Comment By: anuragmurty (anrgmrty)
Date: 2012-05-21 12:55

Message:
thanks for your comment d_rossberg. i have made the changes yyou suggested
and re-submitted a new patch.

----------------------------------------------------------------------

Comment By: Daniel Roßberg (d_rossberg)
Date: 2012-05-21 04:29

Message:
Your patch needs some work.  Here are some hints what's missing:
- missing indentation inside main()
- main() parameters (argn/argv) are missing, even if they won't be unused
- you should return an error code other than 0 if the test failed

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3527405&group_id=105292

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
BRL-CAD Tracker mailing list
brlcad-tracker@...
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker