[bug #21939] Definition of mkdir_p in Makefiles is bad when using install-sh

[Karl Berry-4]

URL:
  <http://savannah.gnu.org/bugs/?21939>

                 Summary: Definition of mkdir_p in Makefiles is bad when
using install-sh
                 Project: grep
            Submitted by: tomculliton
            Submitted on: Thursday 01/03/2008 at 15:52
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

The generated makefiles end up with some variation of the following
definition:

mkdir_p = $(top_builddir)/./install-sh -c -d

The big problem with this is that top_builddir is defined after mkdir_p (the
variable definitions are apparently dumped in alphabetical order).  This
causes "make install" to fail.






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?21939>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/

[Karl Berry]

    mkdir_p = $(top_builddir)/./install-sh -c -d

    The big problem with this is that top_builddir is defined after
    mkdir_p

Definition-before-use is not required with make assignments like this.

    This causes "make install" to fail.

What was the actual failure?

karl

[Karl Berry-4]

Follow-up Comment #1, bug #21939 (project grep):

Here is the MacPorts project's bug report on this issue.

http://trac.macports.org/ticket/13343

As Tom said, "make install" fails with grep 2.5.3. It worked with 2.5.1a.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?21939>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/

[Marc Girod]

Hello,

The problem is still met in po/Makefile (top_builddir not set at all),
for grep 2.5.4 (and 2.5.3), at least when building on i386-pc-solaris2.10

Only given a --prefix to ./configure.

Thanks,
Marc

[Karl Berry-4]

Update of bug #21939 (project grep):

             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #2:

Thank you for the bug report. This bug has been fixed in the
development sources, which can be downloaded using git from
git://git.sv.gnu.org/grep.git

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?21939>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/