[bug #23949] header/config passwords containing quotes badly managed when magic_quotes

View: New views
2 Messages — Rating Filter:   Alert me  

[bug #23949] header/config passwords containing quotes badly managed when magic_quotes

by Mario Castelán Castro :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


URL:
  <http://savannah.gnu.org/bugs/?23949>

                 Summary: header/config passwords containing quotes badly
managed when magic_quotes
                 Project: phpGroupWare
            Submitted by: olberger
            Submitted on: lundi 28.07.2008 à 15:12
              Item Group: 0.9.16.012
                Category: API - Setup
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
       Component Version: DEB
        Operating System: GNU/Linux - Debian
         Reproducibility: None
         Planned Release: None
           Fixed Release:

    _______________________________________________________

Details:

Hi.

If I'm not mistaken, whenever one is using PHP5 with magic_quotes (which is
the default ?), and header or config password is set to a value where it
contains single or double quotes, it's impossible to login in the setup to
access the header or config dialogs.

I think that the following code should be changed from :
if($FormPW ==
stripslashes($GLOBALS['phpgw_info']['server']['header_admin_password']))
to :
if(stripslashes($FormPW) ==
stripslashes($GLOBALS['phpgw_info']['server']['header_admin_password']))

Hope this helps,




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?23949>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.gnu.org/



_______________________________________________
phpGroupWare-tracker mailing list
phpGroupWare-tracker@...
http://lists.gnu.org/mailman/listinfo/phpgroupware-tracker

[bug #23949] header/config passwords containing quotes badly managed when magic_quotes

by Mario Castelán Castro :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Update of bug #23949 (project phpgroupware):

                  Status:                    None => Fixed                  
             Assigned to:                    None => skwashd                
             Open/Closed:                    Open => Closed                
         Reproducibility:                    None => Every Time            

    _______________________________________________________

Follow-up Comment #1:

fix in trunk and will be included in 0.9.16.014

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?23949>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
phpGroupWare-tracker mailing list
phpGroupWare-tracker@...
http://lists.gnu.org/mailman/listinfo/phpgroupware-tracker