[bug #24923] Built in icns drop in replacement not working properly on some operating systems.

[Sylvain Beucler-4]

URL:
  <http://savannah.gnu.org/bugs/?24923>

                 Summary: Built in icns drop in replacement not working
properly on some operating systems.
                 Project: GNUstep
            Submitted by: gcasa
            Submitted on: Mon 24 Nov 2008 05:20:05 PM EST
                Category: None
                Severity: 4 - Important
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

The icns drop in replacement code has problems on some operating systems.  It
does not work properly due to endian issues on solaris and also fails on
windows.  I will post more information as I run more tests.

Part of this issue is that when it fails it allows the NSImage object to be
created and this causes issues in applications since there are no valid
representations to show when they need to be displayed.  GC




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?24923>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Update of bug #24923 (project gnustep):

                Category:                    None => Gui/AppKit            

    _______________________________________________________

Follow-up Comment #1:

This definitly is a gui issue, as the code is located there.

There may be endianness problems, but more likely this is an alignment
problem, where pointers into structures are not properly aligned.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?24923>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Follow-up Comment #2, bug #24923 (project gnustep):

on my sparc machines we determined it to be an alignment problem. The struct
needs to be padded to 4 bytes IIRC.
Possibly other machines were you tried have similar issues.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?24923>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Update of bug #24923 (project gnustep):

                Severity:           4 - Important => 3 - Normal            

    _______________________________________________________

Follow-up Comment #3:

You wrote that this fails on Windows, could you please provide the icon file
that causes this, so I can test on Linux and Windows. I would rather expect
that this problem is hardware specific and not OS.
Perhaps it is a general problem of this implementation.

I set this bug report back to normal, as you never provided the promissed
additional information.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?24923>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Update of bug #24923 (project gnustep):

                  Status:                    None => Need Info              
             Assigned to:                    None => FredKiefer            

    _______________________________________________________

Follow-up Comment #4:

Still waiting for an example that shows the problem in Windows.

We have the know issue on the sparc machine, but if there is a bigger problem
we need an example to fix it.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?24923>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Follow-up Comment #5, bug #24923 (project gnustep):

FlexiSheet opens fine on windows and displays its icon. So I belierve it is
not a windows specific bug, it is an arhcitecture specific bug.
I tested and both Solaris, NetBSD and OpenBSD are affected on sparc for
example. I bet linux would be affected too.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?24923>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Update of bug #24923 (project gnustep):

                  Status:               Need Info => Ready For Test        
             Open/Closed:                    Open => In Test                

    _______________________________________________________

Follow-up Comment #6:

I just added a fix to this code that caused it to fail on 64 bit systems.
Perhaps this was the original cause of this problem. But we will never know as
Greg never provided the promised example file.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?24923>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Follow-up Comment #7, bug #24923 (project gnustep):

on OpenBSD/sparc32 it continues to fail

#0  0x103ed514 in icns_import_family_data (size=17258, bytes=0xeaca000
"icns",
    iconFamily=0xf7ff82bc) at NSBitmapImageRep+ICNS.m:277
#1  0x103edb2c in -[NSBitmapImageRep(ICNS) _initBitmapFromICNS:] (
    self=0xe1b7b08, _cmd=0xe1b7b08, imageData=0xb84eba8)
    at NSBitmapImageRep+ICNS.m:497
#2  0x103e559c in +[NSBitmapImageRep imageRepsWithData:] (self=0x10880b64,
    _cmd=0x108a24d0, imageData=0xb84eba8) at NSBitmapImageRep.m:269
#3  0x1046afc8 in +[NSImageRep imageRepsWithContentsOfFile:]
(self=0x10880b64,
    _cmd=0x108a1570, filename=0xe1b7888) at NSImageRep.m:232
#4  0x10468070 in -[NSImage(Private) _loadFromFile:] (self=<incomplete
type>,
    _cmd=0x108a1178, fileName=0xe1b7888) at NSImage.m:1833
#5  0x10466758 in -[NSImage _representationsWithCachedImages:] (
    self=<incomplete type>, _cmd=0x108a11a0, flag=0 ' 00') at NSImage.m:1404
#6  0x104668e4 in -[NSImage bestRepresentationForDevice:] (
    self=<incomplete type>, _cmd=0x108a0cb8, deviceDescription=0x0)
    at NSImage.m:1434
#7  0x10462be8 in -[NSImage size] (self=<incomplete type>, _cmd=0x1087cc28)
    at NSImage.m:560
#8  0x103d22c4 in -[NSApplication setApplicationIconImage:] (self=0xba21d88,
    _cmd=0x1087c348, anImage=0xdab2248) at NSApplication.m:2210
#9  0x103ce638 in -[NSApplication finishLaunching] (self=0xba21d88,
    _cmd=0x1087c7f0) at NSApplication.m:976
#10 0x103d0190 in -[NSApplication run] (self=0xba21d88, _cmd=0x10875010)


(starting FlexiSheet)

I have no 64bit testcase though. It works on windows 32bit for me.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?24923>

_______________________________________________
  Messaggio inviato con/da Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Update of bug #24923 (project gnustep):

                  Status:          Ready For Test => In Progress            
             Open/Closed:                 In Test => Open                  


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?24923>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep