[bug #26527] bug in unicode conversion.

[Nicodemo Alvaro-3]

URL:
  <http://savannah.nongnu.org/bugs/?26527>

                 Summary: bug in unicode conversion.
                 Project: AVR Downloader/UploaDEr
            Submitted by: None
            Submitted on: Mon 11 May 2009 01:37:11 PM UTC
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: Roger Wolff
        Originator Email: r.e.wolff@...
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

static void convertUniToAscii(char *buffer)
{
    unsigned short  *uni = (void *)buffer;
    char            *ascii = buffer;

    while(*uni != 0){
        if(*uni >= 256){
            *ascii++ = '?';
        }else{
            *ascii++ = *uni++;
        }
    }
    *ascii++ = 0;
}

static void convertUniToAscii(char *buffer)
{
    unsigned short  *uni = (void *)buffer;
    char            *ascii = buffer;

    while(*uni != 0){
        if(*uni >= 256){
            *ascii++ = '?';
uni++;
        }else{
            *ascii++ = *uni++;
        }
    }
    *ascii++ = 0;
}






    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26527>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
avrdude-dev mailing list
avrdude-dev@...
http://lists.nongnu.org/mailman/listinfo/avrdude-dev

[Nicodemo Alvaro-3]

Update of bug #26527 (project avrdude):

                  Status:                    None => Need Info              

    _______________________________________________________

Follow-up Comment #1:

Sorry, I cannot really figure our what you are trying to
tell.

Are you able to attach your suggested change as a unified
context diff?  This is the output of diff -u, as in:

diff -u oldversion yourversion > filename.diff

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26527>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
avrdude-dev mailing list
avrdude-dev@...
http://lists.nongnu.org/mailman/listinfo/avrdude-dev

[Nicodemo Alvaro-3]

Follow-up Comment #2, bug #26527 (project avrdude):

abra2:~> diff -u oldversion yourversion
--- oldversion  2009-07-01 18:05:47.000000000 +0200
+++ yourversion 2009-07-01 18:06:18.000000000 +0200
@@ -6,6 +6,7 @@
 while(*uni != 0){
 if(*uni >= 256){
 *ascii++ = '?';
+uni++;
 }else{
 ascii++ = uni++;
 }
abra2:~>


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26527>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
avrdude-dev mailing list
avrdude-dev@...
http://lists.nongnu.org/mailman/listinfo/avrdude-dev

[Nicodemo Alvaro-3]

Follow-up Comment #3, bug #26527 (project avrdude):

Thanks.  I would have preferred if you had attached it
separately (as a file), as the web interface mangles the
source code posted, but I've finally been able to see what
your intention is.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26527>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
avrdude-dev mailing list
avrdude-dev@...
http://lists.nongnu.org/mailman/listinfo/avrdude-dev

[Nicodemo Alvaro-3]

Update of bug #26527 (project avrdude):

                  Status:               Need Info => Fixed                  
             Assigned to:                    None => joerg_wunsch          
             Open/Closed:                    Open => Closed                


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26527>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
avrdude-dev mailing list
avrdude-dev@...
http://lists.nongnu.org/mailman/listinfo/avrdude-dev