[bug #26876] include io.h into fuse.h

[Ilguiz Latypov-3]

URL:
  <http://savannah.nongnu.org/bugs/?26876>

                 Summary: include io.h into fuse.h
                 Project: AVR C Runtime Library
            Submitted by: wek
            Submitted on: Wed 24 Jun 2009 01:41:31 PM GMT
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Header files
                  Status: None
        Percent Complete: 0%
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 1.6.1
           Fixed Release: None

    _______________________________________________________

Details:

In <avr/fuse.h>, the __fuse_t struct is defined conditionally based on value
of FUSE_MEMORY_SIZE symbol being 1, 2, 3 or above. This symbol is defined by
#including <avr/io.h>. However, if fuse.h is #included *before* io.h, this
symbol is undefined, which may lead to an error confusing for the user,
typically at the place where the FUSES macro is used.

The fix is trivial - #including <avr/io.h> in fuse.h; but to help this fix to
be accepted, I *did* provide a patch... ;-)

Jan Waclawek



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 24 Jun 2009 01:41:31 PM GMT  Name: fuse.h.patch  Size: 179B   By:
wek

<http://savannah.nongnu.org/bugs/download.php?file_id=18314>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26876>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
AVR-libc-dev mailing list
AVR-libc-dev@...
http://lists.nongnu.org/mailman/listinfo/avr-libc-dev

[Ilguiz Latypov-3]

Update of bug #26876 (project avr-libc):

        Percent Complete:                      0% => 30%                    
             Assigned to:                    None => arcanum                


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26876>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
AVR-libc-dev mailing list
AVR-libc-dev@...
http://lists.nongnu.org/mailman/listinfo/avr-libc-dev

[Ilguiz Latypov-3]

Update of bug #26876 (project avr-libc):

        Percent Complete:                     30% => 100%                  
             Open/Closed:                    Open => Closed                
           Fixed Release:                    None => 1.6.7                  

    _______________________________________________________

Follow-up Comment #1:

This is fixed, but in a different way. The avr-libc user manual explicitly
states that fuse.h is included by <avr/io.h> and that the user should include
that file, and not <avr/fuse.h> directly.

The fix now produces an #error if <avr/fuse.h> is called explicitly before
<avr/io.h>.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26876>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
AVR-libc-dev mailing list
AVR-libc-dev@...
http://lists.nongnu.org/mailman/listinfo/avr-libc-dev

[Ilguiz Latypov-3]

Update of bug #26876 (project avr-libc):

           Fixed Release:                   1.6.7 => 1.6.8                  


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26876>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
AVR-libc-dev mailing list
AVR-libc-dev@...
http://lists.nongnu.org/mailman/listinfo/avr-libc-dev