[bug #27101] [NSDocument filePath] does not always return a fully qualified path

View: New views
5 Messages — Rating Filter:   Alert me  

[bug #27101] [NSDocument filePath] does not always return a fully qualified path

by Sylvain Beucler-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


URL:
  <http://savannah.gnu.org/bugs/?27101>

                 Summary: [NSDocument filePath] does not always return a
fully qualified path
                 Project: GNUstep
            Submitted by: jonathanosx
            Submitted on: Fri 24 Jul 2009 05:26:23 PM GMT
                Category: Application
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:


According to the documentation for filePath it:
     Returns the filename (as a fully qualified path) under which the
receiver has been saved.

Normally the path is set as a fully qualified path but if the document is
initialized by passing a command line argument as a relative path then only
the relative path is stored.





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27101>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[bug #27101] [NSDocument filePath] does not always return a fully qualified path

by Sylvain Beucler-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Follow-up Comment #1, bug #27101 (project gnustep):

The name of the method you are referring to is fileName, not filePath.

And before we correct this, could you please confirm what the actual
behaviour on Cocoa is? Quite often the documented behaviour doesn't match the
implemented one.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27101>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[bug #27101] [NSDocument filePath] does not always return a fully qualified path

by Sylvain Beucler-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Follow-up Comment #2, bug #27101 (project gnustep):

You are absolutely correct it is the fileName method (must have had "path"
stuck in my mind when I submitted the bug).

Yes I can absolutely verify that the behavior on Mac OS X is in accordance
with the documentation.  Namely to always provided absolute path return
values, even when the document name is passed in as a launch argument.

Per Greg Casamento, I had intended to submit a check-in after opening the
bug, but I'm having trouble getting my SSH access to the SVN server so I'll
post my proposed patch here.

Thanks for taking a look :)


(file #18482)
    _______________________________________________________

Additional Item Attachment:

File name: NSDocument+FileName.patch      Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27101>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[bug #27101] [NSDocument filePath] does not always return a fully qualified path

by Sylvain Beucler-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Update of bug #27101 (project gnustep):

                  Status:                    None => Ready For Test        
             Open/Closed:                    Open => In Test                

    _______________________________________________________

Follow-up Comment #3:

I applied you patch with small changes.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27101>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[bug #27101] [NSDocument filePath] does not always return a fully qualified path

by Sylvain Beucler-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Update of bug #27101 (project gnustep):

                  Status:          Ready For Test => Fixed                  
             Open/Closed:                 In Test => Closed                


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27101>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep