[bug #27153] Pre-move does not work on xboard 4.4beta1

[Arthur Marsh-2]

URL:
  <http://savannah.gnu.org/bugs/?27153>

                 Summary: Pre-move does not work on xboard 4.4beta1
                 Project: XBoard
            Submitted by: None
            Submitted on: Sat 01 Aug 2009 06:27:58 PM UTC
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

FYI, just compiled today and tried it on FICS, pre-move enabled at start but
nor working.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Update of bug #27153 (project xboard):

                  Status:                    None => Need Info              

    _______________________________________________________

Follow-up Comment #1:

Hi, what operating system, etc are you using. I've been testing the new
version also on FICS and have no problems with pre-move.

Is premove enabled in the Option menu?

ARUN

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Follow-up Comment #2, bug #27153 (project xboard):

To answer the question, I am using Ubuntu Hardy (8.04).

I tried both with the flag set or unset in the Option menu. It looked like a
GUI problem because even the squares highlight that I usually see (when a
pre-move has been entered but not yet played) is not showing.

If it works for you then it may be a problem on my end. I will rebuild
everything, retest, and let you know.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Follow-up Comment #3, bug #27153 (project xboard):

Recompiled today with the following GCC:

$ gcc -v
Using built-in specs.
Target: i486-linux-gnu
Configured with: ../src/configure -v
--enable-languages=c,c++,fortran,objc,obj-c++,treelang --prefix=/usr
--enable-shared --with-system-zlib --libexecdir=/usr/lib
--without-included-gettext --enable-threads=posix --enable-nls
--with-gxx-include-dir=/usr/include/c++/4.2 --program-suffix=-4.2
--enable-clocale=gnu --enable-libstdcxx-debug --enable-objc-gc --enable-mpfr
--enable-targets=all --enable-checking=release --build=i486-linux-gnu
--host=i486-linux-gnu --target=i486-linux-gnu
Thread model: posix
gcc version 4.2.4 (Ubuntu 4.2.4-1ubuntu4)


There is definitely a problem with pre-move for me. Behaves very erratically.
May work a couple of times at the beginning of a game and then stops working.
Also, it does not seem to work at all unless I specify the -premove option on
the command line (true of false by the way).
This is all using the 4.4beta1 sources from ftp://alpha.gnu.org/gnu/xboard/.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Follow-up Comment #4, bug #27153 (project xboard):

I tried it yesterday and pre-move seemed to work fine for me, but I only
tested it a few times, so I'll do some more testing in the next few days,
since you mention that it stopped working for you.

When it stops working for you what's the problem? Does the selection of the
squares stop working or does it just not do the move, but the squares show up
as selected for pre-move, etc?

Could you also confirm that you use these commands to build

./autogen.sh
./configure
make

or if not which commands you are using.

Arun

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Follow-up Comment #5, bug #27153 (project xboard):

When the problem occurs I cannot even select a pre-move, if I try to drag a
piece it does not even get highlighted at all.
And yes, I did all the steps from autogen to final binary.

Actually I did upgrade my system to Jaunty (Ubuntu 9.04, gcc 4.3.3) today and
rebuilt xboard from scratch. I still see the same problem, a little less often
but it still occurs. It is strange, at a given move, the pre-move would work
for one piece move and not for another. For example, there was a position
where I could input a pawn-take-pawn premove but not a Bishop take-pawn (and
of course both are valid moves).

At some point I thought it might be because I use the mouse of my Wacom
tablet but again, I have older version of xboard that work just fine on the
same system so it is more likely a regression.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[h.g. muller]

Can you provide us with an executable that has the premove problem?
I identified some problems with premove in WinBoard (due to lack of
refresh of the display the premove highlights were not always visible
there), and fixed them. But XBoard did not have the same bug, and
for me seems to work as it should on Ubuntu Hardy. So I would like
to try your executable, to see if it is a compilation or an environment
problem.


_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Follow-up Comment #6, bug #27153 (project xboard):

After seeing in Git that H.G. Muller made pre-move fixes for Winboard I
downloaded and compiled the final 4.4.0 tonight, unfortunately problem remains
for xboard.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Follow-up Comment #7, bug #27153 (project xboard):

still working on this one. Other people reported this too, but we (HGM and
Arun) are not able to reproduce this, so it's hard to track down.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Follow-up Comment #8, bug #27153 (project xboard):

Premoving does not work when you try to move a piece onto
one of your own  pieces (which you expect to be captured by
your opponent).

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Follow-up Comment #9, bug #27153 (project xboard):

The following piece of code (in UserMoveTest() in backend.c)
filters out perfectly good premoves - the ones that put a piece
on a piece of the same color. Removing those lines gives
premove handling like in xboard 4.2.7:


    /* note: this code seems to exist for filtering out some obviously
illegal premoves */

    if (    gameMode != EditPosition &&
            (WhitePawn <= pdown && pdown < BlackPawn &&
             WhitePawn <= pup && pup < BlackPawn  ||
             BlackPawn <= pdown && pdown < EmptySquare &&
             BlackPawn <= pup && pup < EmptySquare
            ) && !((gameInfo.variant == VariantFischeRandom ||
gameInfo.variant == VariantCapaRandom) &&
                    (pup == WhiteRook && pdown == WhiteKing && fromY == 0 &&
toY == 0||
                     pup == BlackRook && pdown == BlackKing && fromY ==
BOARD_HEIGHT-1 && toY == BOARD_HEIGHT-1  )
        )           )
         return ImpossibleMove;


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[h.g. muller]

indeed, we got it now. It was just tht no one told that the problem was
entering recaptures as pre-moves. In click-click mode this is not possible,
as clicking a new own piece selects it as new from square rtaher than
to square. But I never realized that this ambiguity does not occur for
drag-drop moves, and that 'capture-own' premoves are actualy supposed
to work there. I thought they were to be treated like the click-click moves,
which is why I moved the code there. My mistake.

As the comment shows I misjudged the function of this code. I thought
it was for filtering out illegal premoves, but in fact it is to give precedence
for selection of a new piece in click-click mode over entering an own
capture.

I have already fixed it in WinBoard, and now I am rewriting the XBoard
mouse handler to use the altered back-end as well as to include the
promotion-popup fix. And now that I am at it, I might s well include
the promotion-piece selection of holdings pieces for Superchess and
Great Shatranj.

In fact this seems to lead to so much duplication of code, that I am
considering to move most of the mouse handler to the back-end,
calling it as mouse(UPCLICK); and mouse(DOWNCLICK); from
the respective front-ends.


_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Follow-up Comment #10, bug #27153 (project xboard):

Also note, that these kind of premoves (to a piece of your own
colour) can only be made by dragging the piece, not if you just click the
from and to squares.
This was the same in xboard 4.2.7.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Follow-up Comment #11, bug #27153 (project xboard):

Indeed, we got it now. If someone had told me that the problem was that
recptures could not be entereds premoves, I would have fixed it in a few
minutes. It was just that no one mentioned that. In click-click mode premove
recaptures are not possible, as clicking a new own piece selects it as new
FROM square rather than as a TO square. So I assumed that it was intended
behavior that recaptures could not be premoves, and that everyone knew this. I
never realized that the ambiguity new-mover / recapture does not occur for
drag-drop moves, and that 'capture-own' premoves are actualy supposed to work
there. My mistake.

As the comment in the source shows I misjudged the function of the offending
code (which I moved from winboard.c to backend.c). I thought it was for
filtering out illegal premoves, but in fact it serves to give precedence for
selection of a new piece in click-click mode over entering a capture-own move.


Simply deleting the offending code in backend.c is no option, as this would
break WinBoard. I will rewrite the mouse handlers of both to be compatible
with a renewed backend. The XBoard mouse andler will then also contain the
promotion-popup fix and selecting promotion pieces from the holdings in
-variant super and great (which WinBoard already has).

H.G. Muller

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Update of bug #27153 (project xboard):

                  Status:               Need Info => Ready For Test        

    _______________________________________________________

Follow-up Comment #12:

uploaded the changes from HGM. Please test.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Update of bug #27153 (project xboard):

                  Status:          Ready For Test => Fixed                  
             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #13:

seems to have fixed it. Closing the report

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Follow-up Comment #14, bug #27153 (project xboard):

Not sure if the fix of HGM is included in 4.4.1pre but FYI I compiled it
today and pre-move still not working.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Follow-up Comment #15, bug #27153 (project xboard):

you want to try the latest git version not the one that's one the ftp server.



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Arthur Marsh-2]

Follow-up Comment #16, bug #27153 (project xboard):

OK, finally got some time to test, built xboard-4.4.1.20091019, and indeed it
seems the issue is now fixed.

As a side note, there seem to be some lingering debug messages in that
version (backend.c at line 3429) as xboard outputs the following lines at each
move:
old: 8x8   new: 8x8 weird=0 variant=0
old: 8x8   new: 8x8 weird=0 variant=0


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27153>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard