[bug #27243] malloc: small error in comment

View: New views
2 Messages — Rating Filter:   Alert me  

[bug #27243] malloc: small error in comment

by Phil Carmody-5 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


URL:
  <http://savannah.nongnu.org/bugs/?27243>

                 Summary: malloc: small error in comment
                 Project: AVR C Runtime Library
            Submitted by: sternst
            Submitted on: Do 13 Aug 2009 13:51:45 GMT
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: None
                  Status: None
        Percent Complete: 0%
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 1.7.*
           Fixed Release: None

    _______________________________________________________

Details:


        /*
         * First, walk the free list and try finding a chunk that
         * would match exactly.  If we found one, we are done.  While
         * walking, note down the size of the largest chunk we found
         * that would still fit the request -- we need it for step 2.
         *
         */
         ...
                        if (s == 0 || fp1->sz < s)
                                s = fp1->sz;


Shouldn't the "largest" actually be a "smallest" (due to the code)?




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?27243>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/



_______________________________________________
AVR-libc-dev mailing list
AVR-libc-dev@...
http://lists.nongnu.org/mailman/listinfo/avr-libc-dev

[bug #27243] malloc: small error in comment

by Phil Carmody-5 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Update of bug #27243 (project avr-libc):

             Assigned to:                    None => joerg_wunsch          

    _______________________________________________________

Follow-up Comment #1:

Joerg, you're the most familiar with malloc stuff. Assigning to you.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?27243>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/



_______________________________________________
AVR-libc-dev mailing list
AVR-libc-dev@...
http://lists.nongnu.org/mailman/listinfo/avr-libc-dev