[bug #27636] Scrollbar a few pixel off on NSWindows95InterfaceStyle

[Sylvain Beucler-4]

URL:
  <http://savannah.gnu.org/bugs/?27636>

                 Summary: Scrollbar a few pixel off on
NSWindows95InterfaceStyle
                 Project: GNUstep
            Submitted by: stefanbidi
            Submitted on: Fri 09 Oct 2009 02:42:57 AM GMT
                Category: Backend
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

I've noticed this when using Riccardo's WinClass theme or just setting
NSInterfaceStyleDefault = NSWindows95InterfaceStyle.

* The whole bar seems to be about 1 pixel to the right;
* The bottom button is about 2 pixel up;
* Top button is about 1 pixel below.

Let me know if a screen shot is needed, I don't have a way to take one, yet.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27636>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Update of bug #27636 (project gnustep):

                Category:                 Backend => Gui/AppKit            

    _______________________________________________________

Follow-up Comment #1:

A screen shot really would help. I tried to reproduce this behaviour with
Ink, but could not see the described offset.

I only set the NSInterfaceStyleDefault to NSWindows95InterfaceStyle and
didn't use any theme. If the issue only shows up for the theme, it must be
regarded as a theme problem.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27636>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Follow-up Comment #2, bug #27636 (project gnustep):

One more question: Which backend are you using? Riccardo has reported a small
offset between art and other backends. I still haven't found time to look into
that.
If your problem goes away when switching to cairo, then it is most likely
that other issue.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27636>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Follow-up Comment #3, bug #27636 (project gnustep):

Sorry it took me a while to reply... screen shots are attached.  I made one
with the Mac and one with Win interface styles for comparison.

(file #18933, file #18934)
    _______________________________________________________

Additional Item Attachment:

File name: NSMacIntStyle.png              Size:86 KB
File name: NSWin95IntStyle.png            Size:90 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27636>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Follow-up Comment #4, bug #27636 (project gnustep):

Oh, and I'm using the Xlib backend.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27636>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Follow-up Comment #5, bug #27636 (project gnustep):

I checked this and the layout is the same for the cairo and the xlib backend.
Next I looked into the NSScroller code and there the difference is even
documented in a comment:

  /* We use the button offset if we in the NeXTstep interface style. */
  if (interfaceStyle == NSNextStepInterfaceStyle
      || interfaceStyle == NSMacintoshInterfaceStyle
      || interfaceStyle == GSWindowMakerInterfaceStyle)
    {
      buttonsWidth = ([isa scrollerWidth] - buttonsOffset);
      x = y = 1.0;
      buttonsSize = 2 * buttonsWidth + 2;
    }
  else
    {
      buttonsWidth = [isa scrollerWidth];
      x = y = 1.0;
      buttonsSize = 2 * buttonsWidth;
    }


So I think this difference is there intentionally, or at least was so
originally. I could not drag down who added this code (SVN blames gives
Richard, but he may just have rearranged that method) perhaps somebody on this
list remembers the reason for this?

As for the vertical offset, I see the same on the screen shot with the
NSMacintoshInterfaceStyle. What is the difference I am missing?


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27636>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Follow-up Comment #6, bug #27636 (project gnustep):

I guess the offset that I saw at the bottom was just my eyes playing tricks
on me.  I just took at look at it again and don't see anything, so forget that
statement.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27636>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Update of bug #27636 (project gnustep):

                  Status:                    None => Fixed                  
             Open/Closed:                    Open => In Test                

    _______________________________________________________

Follow-up Comment #7:

I've been through this code, simplified/clarified a little I hope, and fixed
a minor offset error which could have been your issue.
Please could you give it a go and see if this now acts as you expect.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27636>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Follow-up Comment #8, bug #27636 (project gnustep):

Looks good to me!

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27636>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep

[Sylvain Beucler-4]

Update of bug #27636 (project gnustep):

             Open/Closed:                 In Test => Closed                

    _______________________________________________________

Follow-up Comment #9:

confirmed as fixed.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27636>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@...
http://lists.gnu.org/mailman/listinfo/bug-gnustep