[bug #27667] PV line missing in analysis window

[Sylvain Beucler-4]

URL:
  <http://savannah.gnu.org/bugs/?27667>

                 Summary: PV line missing in analysis window
                 Project: XBoard
            Submitted by: None
            Submitted on: Sun 11 Oct 2009 01:46:42 PM UTC
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Start xboard in analysis mode.

PV is only displayed in analysis window for a short time after it is changed.
Most of the time you only see this:

depth=11 +0.11

In version 4.2.7 the PV was always visible:

depth=12 +0.11 Nc3 Nf6 Nf3 Nc6 d4 d5 Bf4 Nh5






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #1, bug #27667 (project xboard):

The bug is actually that the analysis window appears at all. This window has
been replaced by the Engine-Output window, and it should have been the latter
window that pops up when you select analysis mode. WinBoard already does this
for a long time, but we forgot to make the necessary change in XBoard to alter
what pops up.

I think this is already fixed in git now.

H.G. Muller

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #2, bug #27667 (project xboard):

I checked the latest git. You still get the analysis window.
While you are at it: Changing the window name from "engine output" to "Engine
output" would be more consistent with the other windows.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #3, bug #27667 (project xboard):

Another thing for the "Engine output" window:
Start xboard with one engine. Activate analysis mode. Open the "Engine
output" window (still manually). The window layout is for 2 engines shortly,
then changes to 1 engine. But when you resize the window it reverts to 2
engine layout.

Ah, I just saw the explanation for this: Closing the window and reopening it
shows: "This feature is experimental"



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #4, bug #27667 (project xboard):

Well, that it is experimental makes it all the more important to cure bugs!
But let me make sure what exactly you are seeing:

The Engine-Output window in fact alays contains sections for both engines,
but (mimicking WinBoard) I use the dirty trick of making them so large if
there is only one engine that the second is out of view. The first behavior
you describe is normal: the window always pops up in two-engine mode, and only
when it actually gets used because an engine writes to it, it is decided if
the output for the second should be hidden (outside the window) or not.

But now when I start to size the window afterwards, the contents of it scales
with it. (Not perfectly, as when I make it very large vertically I start to
see the "Engine"  and "NPS" header of the second pane, at the lower edge of
the window, but close enough.)

Do you mean that in your case the output pane of the first engine does not
adapt its size when you size up the window, so that the second pane, which is
supposed to be and remain hidden, gets slowly into view? Or do you see the
layout of the window suddenly jump so that it is subdivided in two equal panes
again?

H.G. Muller

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #5, bug #27667 (project xboard):

I see the layout of the window suddenly jump so that it is subdivided in two
equal panes again. Just exactly like it is in "2 machines" mode.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #6, bug #27667 (project xboard):

And this switch in window layout is triggered by you resizing the window?

For me this does not happen, but this could be a difference in the X-tools
library. It looks like the resizing routine in your library does rescale the
contents of the window such that it exactly fits the new window, rather than
multiplying all sizes with the same factor as the window was enlarged, like
mine does.

So I guess that hiding the nonused pane out of view as WinBoard does, does
not generally work for Board, and that I would really have to destroy and
recreate the widgets when switching from single-engine to two-engine mode.

H.G. Muller

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #7, bug #27667 (project xboard):

Yes, it's triggered just in the moment when releasing the mouse button, after
dragging the window larger.
I must admit, that my Xlibs are pretty antique (9 years old), but any upgrade
is always such a pain (breaking things that worked for years, etc.), that I
normally avoid this like hell.
Upgrading XBoard wasn't an easy decision for me.

So if nobody else experiences this, don't invest time.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #8, bug #27667 (project xboard):

I just tried Xaw3D instead of Xaw (same age), and it works there. So I have a
simple workaround.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #9, bug #27667 (project xboard):

Some final points regarding the XBoard engine output window:

1. If the window overlaps with the board window, it is always in front of the
board. Other subwindows, like "Move list" can also go behind the board. So you
always have to drag the window out of the way, if you want to see the complete
board.

2. Engine state icon: The STATE_THINKING symbol should also be shown in
gameMode MachinePlaysWhite and MachinePlaysBlack, when it's the engine's turn.
Currently it is blank indicating STATE_IDLE.

3. Wish for Engine state string (right to the icon): Can you add the actual
search depth in analyzing mode? A change like

sprintf( buf, "[%d] %d/%d: %s [%02d:%02d:%02d]", ed->depth,ed->an_move_index
.....

would be sufficient.



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #10, bug #27667 (project xboard):

With point 1. I mean:
In xengineoutput.c replace

XtCreatePopupShell(name, transientShellWidgetClass,

with

XtCreatePopupShell(name, topLevelShellWidgetClass,

using the already existing #if TOPLEVEL.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #11, bug #27667 (project xboard):

I will have a look at why the icon does not display, and put in the depth.

I am not sure if the top-level thing is desirable. In WinBoard the default is
that all auxiliary windows open and close together with the main window, and
this works quite well. I guess the bigger problem is not so much that th
Engine-Output is always in front, but more that it pops up in a very
inconvenient place. Now for WinBoard all auxiliary windows also pop up in
front of the board (and each other), and they are even shown by compiled-in
default. But WinBoard saves its settings by default, and remembers the screen
position of all of its windows. So once you have nicely tiled all windows that
you usually want shown, and closed the rest, it will always stary up the way
you like it, and which window is in front is immaterial, as they will simply
not cover each other. And when you move the main window, all auxiliary windows
touching it will move with it, like they are panes of one big window. And then
it is only convenient that they all open and close together.

So perhaps we should not address this point before we hav acheived that.

H.G. Muller


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #12, bug #27667 (project xboard):

With topLevel the window still pops up in front of the board (at least with
my Xlibs), it only doesn't resist to go behind later, just like good old
AnalysisWindow. Your screen also seems to be much larger than mine, because I
can't do without overlapping. PV lines can get very long, so further enlarging
the window is often necessary.

To me transientShell seems to be the mode for windows that require immediate
user action within, before normal operation can continue (error/promotion
popup/File Name Prompt).

This goes to my private patch list then.





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #13, bug #27667 (project xboard):

Well, it depends on how large you make the XBoard main window. As I usually
run with engines, and thus want the engine-output open, I make sure XBoard
pops up small enough to leave ample space for it.

But I have seen that other windows whih in WinBoard behave as transientShells
as well (e.g. move history) are also under control of the TOPLEVEL switch. So
I guess it is natural to bring Engine Output under its control as well. In the
future the default setting of TOPLEVEL ca be changed to 0 then, when we have
added suffiient support for remembering window sizes and positions.

H.G. Muller

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Update of bug #27667 (project xboard):

                  Status:                    None => Ready For Test        

    _______________________________________________________

Follow-up Comment #14:

should be all fixed now. Will close it in a few days if we don't get any
complaints.

ARUN

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #15, bug #27667 (project xboard):

from my comment #9:

point 1 is fixed.
point 2 and 3 are not.

All other things mentioned here are ok.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #16, bug #27667 (project xboard):

OK, sorry, I forgot all about the other two points. The depth I have now
implemented in XBoard. Since in the 5 years that this feature exists in
WinBoard no one ever requested it there, I left WinBoard as it was. (So I
broke the equivalence of the duplicate code xengineoutput.c and wengineo.c
contain; when we re-organize the source this code should go to the back-end,
and I guess WinBoard will then automatically inherit this change.) So this
will appear in git shortly.

As to the icon (point 2): From looking at the code it seems to me this was
intended behavior. The clock icon is only needed in two-machines mode, to
indicate which engine is thinking if neither of them is pondering. In
machine-black / machine-white mode there are only two states, ponder or
thinking, and the ponder icon distinguishes those (with the ponder move
displayed next to it).

I actually like it that way; the less is displayed, the cleaner the display
looks. So I think it is good design philosophy to not display anything to
merely indicate something that is already implied by the situation. Even when
you would have to display something to indicate that same thing in other
situations, where it is not implied.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #17, bug #27667 (project xboard):

All points ok. Thank you!

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Update of bug #27667 (project xboard):

                  Status:          Ready For Test => Fixed                  
             Open/Closed:                    Open => Closed                


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27667>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard