[bug #27760] debug printf in backend.c

[Sylvain Beucler-4]

URL:
  <http://savannah.gnu.org/bugs/?27760>

                 Summary: debug printf in backend.c
                 Project: XBoard
            Submitted by: None
            Submitted on: Tue 20 Oct 2009 07:35:08 AM UTC
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Xboard:
With version v4.4.1.20091019 in backend.c (line 3432) a
fprintf(debugFP ...
was introduced. It is not controlled by "if (appData.debugMode)".
So it spams the console.






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27760>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #1, bug #27760 (project xboard):

Ah, sorry. A leftover of my debugging efforts that should actually have been
removed altogether now that things work. Thanks for spotting it.

Perhaps many "fprintf(debugFP, ..." that are controlled by appData.debugMode
should be deleted as well. (Especially in the legality testing /
disambiguation in moves.c; I have not seen any erroneous illegal-move calls
there for years.) We really should clean up the code in that respect one day.

H.G. Muller

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27760>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Follow-up Comment #2, bug #27760 (project xboard):

I recently had exposure to this and formed one thought: why not design the
debug facility so that it is not necessary to always check for
appData.debugMode?

That extra check really uglifies the code.  At least for the GTK version we
ought to simply have it become a call that operates peroperly based on if
-debug was passed or not.  Plus, as this bug report notes, it's easy enough to
leave behind a buggy call to the debugging system.  It's horrid as is.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27760>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Sylvain Beucler-4]

Update of bug #27760 (project xboard):

                  Status:                    None => Fixed                  
             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #3:

uploaded fix and closing this.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27760>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard