[bug #27826] Tags and comment windows

[Ben Asselstine-2]

URL:
  <http://savannah.gnu.org/bugs/?27826>

                 Summary: Tags and comment windows
                 Project: XBoard
            Submitted by: None
            Submitted on: Tue 27 Oct 2009 02:56:05 PM UTC
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

2 minor observations, when loading a file with tags & comments.
1. In xboard 4.2.7 the "Tags" window opens right after loading. This doesn't
happen with the new xboard.

2. When a commented move is reached, the Comment windows is opened. In 4.2.7
the window title showed "Comment on 15. exd5".
Now the title shows nothing.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27826>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Ben Asselstine-2]

Follow-up Comment #1, bug #27826 (project xboard):

Good point!

In WinBoard (and thus the back-end) the popping up of tags and comment
windows are now under control of the options -autoDisplayTags true/false and
-autoDisplayComment true/false. But I see that those options were never ported
to XBoard. I was not aware that 4.2.7 did not have these options, I thought
they were primordial, but apparently they were introduced in WinBoard_x. There
the default setting is "true", but this requires initialization (in
winboard.c, which handles the options), as un-initialized memory is
interpreted as "false". Which it thus what happens in XBoard.

The missing title is a consequence of that: when you pop up the window
through the menu it is an edit window without a title. I belief this was also
the case in 4.2.7 and WinBoard; the window title only appears on auto-popup.

The command-line options will of course have to be added, and I think their
default settings should be true (as in WinBoard), to reproduce old behavior
(no matter how irritating that was...). I will fix it.

H.G. Muller

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27826>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Ben Asselstine-2]

Update of bug #27826 (project xboard):

                  Status:                    None => Ready For Test        


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27826>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Ben Asselstine-2]

Follow-up Comment #2, bug #27826 (project xboard):

"-autoDisplayComment false" still opens titleless comment windows.

"-autoDisplayComment true" gives the correct window.

"-autoDisplayTags" works as expected.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27826>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Ben Asselstine-2]

Follow-up Comment #3, bug #27826 (project xboard):

uploaded a patch from HGM. Please test again

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27826>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Ben Asselstine-2]

Follow-up Comment #4, bug #27826 (project xboard):

I think this must have not worked correctly in WinBoard either. (i.e. I broke
it somewhere around 4.3.15, and no one ever complained!) I think I have given
it a reasonable behavior now:

Default: -autoDisplayComment true
This pops up the comment window on any move that has a comment, also if it is
a score/depth type comment made by an engine (of the type you get with
-pgnExtendedInfo true).

-autoDisplayComment false
This does not popup the comment window, unless you explicitly request it
through the menu item Mode -> Edit Comment. But once it is up, it will be
refreshed with title and comment of a move that has a comment.

The title now is always the move (if there is one).

H.G. Muller

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27826>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Ben Asselstine-2]

Follow-up Comment #5, bug #27826 (project xboard):

I can only test XBoard. All options work as expected with git
2b102a5aee6ecd7f801208d2c6f6aacf59397ee4.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27826>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard

[Ben Asselstine-2]

Update of bug #27826 (project xboard):

                  Status:          Ready For Test => Fixed                  
             Open/Closed:                    Open => Closed                


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27826>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
http://lists.gnu.org/mailman/listinfo/bug-xboard